qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, laurent@vivier.eu
Subject: Re: [PATCH v2 09/12] linux-user: Rename cpu_clone_regs to cpu_clone_regs_child
Date: Fri, 25 Oct 2019 15:03:49 +0200	[thread overview]
Message-ID: <3ccd5a50-79ba-afad-2844-ecdb62ae0d53@redhat.com> (raw)
In-Reply-To: <20191025113921.9412-10-richard.henderson@linaro.org>

On 10/25/19 1:39 PM, Richard Henderson wrote:
> We will need a target-specific hook for adjusting registers
> in the parent during clone.  To avoid confusion, rename the
> one we have to make it clear it affects the child.
> 
> At the same time, pass in the flags from the clone syscall.
> We will need them for correct behaviour for Sparc.
> 
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> v2: Add flags parameter.
> ---
>   linux-user/aarch64/target_cpu.h    | 3 ++-
>   linux-user/alpha/target_cpu.h      | 3 ++-
>   linux-user/arm/target_cpu.h        | 3 ++-
>   linux-user/cris/target_cpu.h       | 3 ++-
>   linux-user/hppa/target_cpu.h       | 3 ++-
>   linux-user/i386/target_cpu.h       | 3 ++-
>   linux-user/m68k/target_cpu.h       | 3 ++-
>   linux-user/microblaze/target_cpu.h | 3 ++-
>   linux-user/mips/target_cpu.h       | 3 ++-
>   linux-user/nios2/target_cpu.h      | 3 ++-
>   linux-user/openrisc/target_cpu.h   | 4 +++-
>   linux-user/ppc/target_cpu.h        | 3 ++-
>   linux-user/riscv/target_cpu.h      | 3 ++-
>   linux-user/s390x/target_cpu.h      | 3 ++-
>   linux-user/sh4/target_cpu.h        | 3 ++-
>   linux-user/sparc/target_cpu.h      | 3 ++-
>   linux-user/tilegx/target_cpu.h     | 3 ++-
>   linux-user/xtensa/target_cpu.h     | 4 +++-
>   linux-user/syscall.c               | 4 ++--
>   19 files changed, 40 insertions(+), 20 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>



  reply	other threads:[~2019-10-25 13:06 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 11:39 [PATCH v2 00/12] linux-user sparc fixes Richard Henderson
2019-10-25 11:39 ` [PATCH v2 01/12] scripts/qemu-binfmt-conf: Update for sparc64 Richard Henderson
2019-11-05  9:43   ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 02/12] tests/tcg/multiarch/linux-test: Fix error check for shmat Richard Henderson
2019-10-25 12:59   ` Philippe Mathieu-Daudé
2019-10-25 13:00   ` Philippe Mathieu-Daudé
2019-11-05  9:45   ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 03/12] target/sparc: Define an enumeration for accessing env->regwptr Richard Henderson
2019-11-05  9:45   ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 04/12] linux-user/sparc: Use WREG constants in sparc/target_cpu.h Richard Henderson
2019-10-25 12:09   ` Laurent Vivier
2019-11-05  9:49   ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 05/12] linux-user/sparc: Begin using WREG constants in sparc/signal.c Richard Henderson
2019-10-25 12:16   ` Laurent Vivier
2019-11-05  9:49   ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 06/12] linux-user/sparc: Use WREG_SP constant " Richard Henderson
2019-10-25 12:19   ` Laurent Vivier
2019-11-05  9:50   ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 07/12] linux-user/sparc: Fix WREG usage in setup_frame Richard Henderson
2019-11-05  9:50   ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 08/12] linux-user/sparc64: Fix target_signal_frame Richard Henderson
2019-10-25 12:47   ` Laurent Vivier
2019-10-25 13:38     ` Richard Henderson
2019-10-25 13:43       ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 09/12] linux-user: Rename cpu_clone_regs to cpu_clone_regs_child Richard Henderson
2019-10-25 13:03   ` Philippe Mathieu-Daudé [this message]
2019-11-05  9:52   ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 10/12] linux-user: Introduce cpu_clone_regs_parent Richard Henderson
2019-10-25 13:04   ` Philippe Mathieu-Daudé
2019-11-05  9:52   ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 11/12] linux-user/sparc: Fix cpu_clone_regs_* Richard Henderson
2019-11-05  9:54   ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 12/12] linux-user/alpha: Set r20 secondary return value Richard Henderson
2019-10-25 12:56   ` Laurent Vivier
2019-11-05  9:53   ` Laurent Vivier
2019-10-25 12:50 ` [PATCH v2 00/12] linux-user sparc fixes Laurent Vivier
2019-10-26  7:02 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ccd5a50-79ba-afad-2844-ecdb62ae0d53@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).