From: Laurent Vivier <laurent@vivier.eu>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: Re: [PATCH v2 12/12] linux-user/alpha: Set r20 secondary return value
Date: Fri, 25 Oct 2019 14:56:42 +0200 [thread overview]
Message-ID: <68006f7c-7786-568a-9939-ecd1f240a723@vivier.eu> (raw)
In-Reply-To: <20191025113921.9412-13-richard.henderson@linaro.org>
Le 25/10/2019 à 13:39, Richard Henderson a écrit :
> This value is not, as far as I know, used by any linux software,
> but it is set by the kernel and is part of the ABI.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> v2: Do not set the parent secondary return if SETTLS.
> ---
> linux-user/alpha/target_cpu.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/linux-user/alpha/target_cpu.h b/linux-user/alpha/target_cpu.h
> index dd25e18f47..ad408ab5cc 100644
> --- a/linux-user/alpha/target_cpu.h
> +++ b/linux-user/alpha/target_cpu.h
> @@ -27,10 +27,19 @@ static inline void cpu_clone_regs_child(CPUAlphaState *env, target_ulong newsp,
> }
> env->ir[IR_V0] = 0;
> env->ir[IR_A3] = 0;
> + env->ir[IR_A4] = 1; /* OSF/1 secondary return: child */
> }
>
> static inline void cpu_clone_regs_parent(CPUAlphaState *env, unsigned flags)
> {
> + /*
> + * OSF/1 secondary return: parent
> + * Note that the kernel does not do this if SETTLS, because the
> + * settls argument register is still live after copy_thread.
> + */
> + if (!(flags & CLONE_SETTLS)) {
> + env->ir[IR_A4] = 0;
> + }
> }
>
> static inline void cpu_set_tls(CPUAlphaState *env, target_ulong newtls)
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2019-10-25 12:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 11:39 [PATCH v2 00/12] linux-user sparc fixes Richard Henderson
2019-10-25 11:39 ` [PATCH v2 01/12] scripts/qemu-binfmt-conf: Update for sparc64 Richard Henderson
2019-11-05 9:43 ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 02/12] tests/tcg/multiarch/linux-test: Fix error check for shmat Richard Henderson
2019-10-25 12:59 ` Philippe Mathieu-Daudé
2019-10-25 13:00 ` Philippe Mathieu-Daudé
2019-11-05 9:45 ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 03/12] target/sparc: Define an enumeration for accessing env->regwptr Richard Henderson
2019-11-05 9:45 ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 04/12] linux-user/sparc: Use WREG constants in sparc/target_cpu.h Richard Henderson
2019-10-25 12:09 ` Laurent Vivier
2019-11-05 9:49 ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 05/12] linux-user/sparc: Begin using WREG constants in sparc/signal.c Richard Henderson
2019-10-25 12:16 ` Laurent Vivier
2019-11-05 9:49 ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 06/12] linux-user/sparc: Use WREG_SP constant " Richard Henderson
2019-10-25 12:19 ` Laurent Vivier
2019-11-05 9:50 ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 07/12] linux-user/sparc: Fix WREG usage in setup_frame Richard Henderson
2019-11-05 9:50 ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 08/12] linux-user/sparc64: Fix target_signal_frame Richard Henderson
2019-10-25 12:47 ` Laurent Vivier
2019-10-25 13:38 ` Richard Henderson
2019-10-25 13:43 ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 09/12] linux-user: Rename cpu_clone_regs to cpu_clone_regs_child Richard Henderson
2019-10-25 13:03 ` Philippe Mathieu-Daudé
2019-11-05 9:52 ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 10/12] linux-user: Introduce cpu_clone_regs_parent Richard Henderson
2019-10-25 13:04 ` Philippe Mathieu-Daudé
2019-11-05 9:52 ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 11/12] linux-user/sparc: Fix cpu_clone_regs_* Richard Henderson
2019-11-05 9:54 ` Laurent Vivier
2019-10-25 11:39 ` [PATCH v2 12/12] linux-user/alpha: Set r20 secondary return value Richard Henderson
2019-10-25 12:56 ` Laurent Vivier [this message]
2019-11-05 9:53 ` Laurent Vivier
2019-10-25 12:50 ` [PATCH v2 00/12] linux-user sparc fixes Laurent Vivier
2019-10-26 7:02 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68006f7c-7786-568a-9939-ecd1f240a723@vivier.eu \
--to=laurent@vivier.eu \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).