qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] nvdimm: release the correct device list
@ 2021-06-24 11:04 Li Zhijian
  2021-06-29 14:05 ` Igor Mammedov
  0 siblings, 1 reply; 7+ messages in thread
From: Li Zhijian @ 2021-06-24 11:04 UTC (permalink / raw)
  To: xiaoguangrong.eric, mst, imammedo; +Cc: qemu-devel, Li Zhijian

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
 hw/acpi/nvdimm.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index e3d5fe19392..ff317263e85 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi/nvdimm.c
@@ -355,10 +355,10 @@ nvdimm_build_structure_caps(GArray *structures, uint32_t capabilities)
 
 static GArray *nvdimm_build_device_structure(NVDIMMState *state)
 {
-    GSList *device_list = nvdimm_get_device_list();
+    GSList *device_list, *list = nvdimm_get_device_list();
     GArray *structures = g_array_new(false, true /* clear */, 1);
 
-    for (; device_list; device_list = device_list->next) {
+    for (device_list = list; device_list; device_list = device_list->next) {
         DeviceState *dev = device_list->data;
 
         /* build System Physical Address Range Structure. */
@@ -373,7 +373,7 @@ static GArray *nvdimm_build_device_structure(NVDIMMState *state)
         /* build NVDIMM Control Region Structure. */
         nvdimm_build_structure_dcr(structures, dev);
     }
-    g_slist_free(device_list);
+    g_slist_free(list);
 
     if (state->persistence) {
         nvdimm_build_structure_caps(structures, state->persistence);
@@ -1339,9 +1339,9 @@ static void nvdimm_build_ssdt(GArray *table_offsets, GArray *table_data,
 
 void nvdimm_build_srat(GArray *table_data)
 {
-    GSList *device_list = nvdimm_get_device_list();
+    GSList *device_list, *list = nvdimm_get_device_list();
 
-    for (; device_list; device_list = device_list->next) {
+    for (device_list = list; device_list; device_list = device_list->next) {
         AcpiSratMemoryAffinity *numamem = NULL;
         DeviceState *dev = device_list->data;
         Object *obj = OBJECT(dev);
@@ -1356,7 +1356,7 @@ void nvdimm_build_srat(GArray *table_data)
         build_srat_memory(numamem, addr, size, node,
                           MEM_AFFINITY_ENABLED | MEM_AFFINITY_NON_VOLATILE);
     }
-    g_slist_free(device_list);
+    g_slist_free(list);
 }
 
 void nvdimm_build_acpi(GArray *table_offsets, GArray *table_data,
-- 
2.31.1





^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] nvdimm: release the correct device list
  2021-06-24 11:04 [PATCH] nvdimm: release the correct device list Li Zhijian
@ 2021-06-29 14:05 ` Igor Mammedov
  2021-08-03  4:00   ` Li, Zhijian/李 智坚
  0 siblings, 1 reply; 7+ messages in thread
From: Igor Mammedov @ 2021-06-29 14:05 UTC (permalink / raw)
  To: Li Zhijian; +Cc: qemu-devel, xiaoguangrong.eric, mst

On Thu, 24 Jun 2021 19:04:15 +0800
Li Zhijian <lizhijian@cn.fujitsu.com> wrote:

> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  hw/acpi/nvdimm.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
> index e3d5fe19392..ff317263e85 100644
> --- a/hw/acpi/nvdimm.c
> +++ b/hw/acpi/nvdimm.c
> @@ -355,10 +355,10 @@ nvdimm_build_structure_caps(GArray *structures, uint32_t capabilities)
>  
>  static GArray *nvdimm_build_device_structure(NVDIMMState *state)
>  {
> -    GSList *device_list = nvdimm_get_device_list();
> +    GSList *device_list, *list = nvdimm_get_device_list();
>      GArray *structures = g_array_new(false, true /* clear */, 1);
>  
> -    for (; device_list; device_list = device_list->next) {
> +    for (device_list = list; device_list; device_list = device_list->next) {
>          DeviceState *dev = device_list->data;
>  
>          /* build System Physical Address Range Structure. */
> @@ -373,7 +373,7 @@ static GArray *nvdimm_build_device_structure(NVDIMMState *state)
>          /* build NVDIMM Control Region Structure. */
>          nvdimm_build_structure_dcr(structures, dev);
>      }
> -    g_slist_free(device_list);
> +    g_slist_free(list);
>  
>      if (state->persistence) {
>          nvdimm_build_structure_caps(structures, state->persistence);
> @@ -1339,9 +1339,9 @@ static void nvdimm_build_ssdt(GArray *table_offsets, GArray *table_data,
>  
>  void nvdimm_build_srat(GArray *table_data)
>  {
> -    GSList *device_list = nvdimm_get_device_list();
> +    GSList *device_list, *list = nvdimm_get_device_list();
>  
> -    for (; device_list; device_list = device_list->next) {
> +    for (device_list = list; device_list; device_list = device_list->next) {
>          AcpiSratMemoryAffinity *numamem = NULL;
>          DeviceState *dev = device_list->data;
>          Object *obj = OBJECT(dev);
> @@ -1356,7 +1356,7 @@ void nvdimm_build_srat(GArray *table_data)
>          build_srat_memory(numamem, addr, size, node,
>                            MEM_AFFINITY_ENABLED | MEM_AFFINITY_NON_VOLATILE);
>      }
> -    g_slist_free(device_list);
> +    g_slist_free(list);
>  }
>  
>  void nvdimm_build_acpi(GArray *table_offsets, GArray *table_data,



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] nvdimm: release the correct device list
  2021-06-29 14:05 ` Igor Mammedov
@ 2021-08-03  4:00   ` Li, Zhijian/李 智坚
  2021-08-30  1:06     ` lizhijian
  0 siblings, 1 reply; 7+ messages in thread
From: Li, Zhijian/李 智坚 @ 2021-08-03  4:00 UTC (permalink / raw)
  To: Igor Mammedov, mst, xiaoguangrong.eric; +Cc: qemu-devel

ping

Any body could help to review/queue this patch ?



On 2021/6/29 22:05, Igor Mammedov wrote:
> On Thu, 24 Jun 2021 19:04:15 +0800
> Li Zhijian <lizhijian@cn.fujitsu.com> wrote:
>
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>
>> ---
>>   hw/acpi/nvdimm.c | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
>> index e3d5fe19392..ff317263e85 100644
>> --- a/hw/acpi/nvdimm.c
>> +++ b/hw/acpi/nvdimm.c
>> @@ -355,10 +355,10 @@ nvdimm_build_structure_caps(GArray *structures, uint32_t capabilities)
>>   
>>   static GArray *nvdimm_build_device_structure(NVDIMMState *state)
>>   {
>> -    GSList *device_list = nvdimm_get_device_list();
>> +    GSList *device_list, *list = nvdimm_get_device_list();
>>       GArray *structures = g_array_new(false, true /* clear */, 1);
>>   
>> -    for (; device_list; device_list = device_list->next) {
>> +    for (device_list = list; device_list; device_list = device_list->next) {
>>           DeviceState *dev = device_list->data;
>>   
>>           /* build System Physical Address Range Structure. */
>> @@ -373,7 +373,7 @@ static GArray *nvdimm_build_device_structure(NVDIMMState *state)
>>           /* build NVDIMM Control Region Structure. */
>>           nvdimm_build_structure_dcr(structures, dev);
>>       }
>> -    g_slist_free(device_list);
>> +    g_slist_free(list);
>>   
>>       if (state->persistence) {
>>           nvdimm_build_structure_caps(structures, state->persistence);
>> @@ -1339,9 +1339,9 @@ static void nvdimm_build_ssdt(GArray *table_offsets, GArray *table_data,
>>   
>>   void nvdimm_build_srat(GArray *table_data)
>>   {
>> -    GSList *device_list = nvdimm_get_device_list();
>> +    GSList *device_list, *list = nvdimm_get_device_list();
>>   
>> -    for (; device_list; device_list = device_list->next) {
>> +    for (device_list = list; device_list; device_list = device_list->next) {
>>           AcpiSratMemoryAffinity *numamem = NULL;
>>           DeviceState *dev = device_list->data;
>>           Object *obj = OBJECT(dev);
>> @@ -1356,7 +1356,7 @@ void nvdimm_build_srat(GArray *table_data)
>>           build_srat_memory(numamem, addr, size, node,
>>                             MEM_AFFINITY_ENABLED | MEM_AFFINITY_NON_VOLATILE);
>>       }
>> -    g_slist_free(device_list);
>> +    g_slist_free(list);
>>   }
>>   
>>   void nvdimm_build_acpi(GArray *table_offsets, GArray *table_data,
>
>




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] nvdimm: release the correct device list
  2021-08-03  4:00   ` Li, Zhijian/李 智坚
@ 2021-08-30  1:06     ` lizhijian
  2021-09-13  6:40       ` lizhijian
  0 siblings, 1 reply; 7+ messages in thread
From: lizhijian @ 2021-08-30  1:06 UTC (permalink / raw)
  To: Igor Mammedov, mst, xiaoguangrong.eric; +Cc: qemu-devel

ping


On 03/08/2021 12:00, Li, Zhijian wrote:
> ping
>
> Any body could help to review/queue this patch ?
>
>
>
> On 2021/6/29 22:05, Igor Mammedov wrote:
>> On Thu, 24 Jun 2021 19:04:15 +0800
>> Li Zhijian <lizhijian@cn.fujitsu.com> wrote:
>>
>>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>>
>>> ---
>>>   hw/acpi/nvdimm.c | 12 ++++++------
>>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
>>> index e3d5fe19392..ff317263e85 100644
>>> --- a/hw/acpi/nvdimm.c
>>> +++ b/hw/acpi/nvdimm.c
>>> @@ -355,10 +355,10 @@ nvdimm_build_structure_caps(GArray *structures, uint32_t capabilities)
>>>     static GArray *nvdimm_build_device_structure(NVDIMMState *state)
>>>   {
>>> -    GSList *device_list = nvdimm_get_device_list();
>>> +    GSList *device_list, *list = nvdimm_get_device_list();
>>>       GArray *structures = g_array_new(false, true /* clear */, 1);
>>>   -    for (; device_list; device_list = device_list->next) {
>>> +    for (device_list = list; device_list; device_list = device_list->next) {
>>>           DeviceState *dev = device_list->data;
>>>             /* build System Physical Address Range Structure. */
>>> @@ -373,7 +373,7 @@ static GArray *nvdimm_build_device_structure(NVDIMMState *state)
>>>           /* build NVDIMM Control Region Structure. */
>>>           nvdimm_build_structure_dcr(structures, dev);
>>>       }
>>> -    g_slist_free(device_list);
>>> +    g_slist_free(list);
>>>         if (state->persistence) {
>>>           nvdimm_build_structure_caps(structures, state->persistence);
>>> @@ -1339,9 +1339,9 @@ static void nvdimm_build_ssdt(GArray *table_offsets, GArray *table_data,
>>>     void nvdimm_build_srat(GArray *table_data)
>>>   {
>>> -    GSList *device_list = nvdimm_get_device_list();
>>> +    GSList *device_list, *list = nvdimm_get_device_list();
>>>   -    for (; device_list; device_list = device_list->next) {
>>> +    for (device_list = list; device_list; device_list = device_list->next) {
>>>           AcpiSratMemoryAffinity *numamem = NULL;
>>>           DeviceState *dev = device_list->data;
>>>           Object *obj = OBJECT(dev);
>>> @@ -1356,7 +1356,7 @@ void nvdimm_build_srat(GArray *table_data)
>>>           build_srat_memory(numamem, addr, size, node,
>>>                             MEM_AFFINITY_ENABLED | MEM_AFFINITY_NON_VOLATILE);
>>>       }
>>> -    g_slist_free(device_list);
>>> +    g_slist_free(list);
>>>   }
>>>     void nvdimm_build_acpi(GArray *table_offsets, GArray *table_data,
>>
>>
>
>
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] nvdimm: release the correct device list
  2021-08-30  1:06     ` lizhijian
@ 2021-09-13  6:40       ` lizhijian
  2021-09-17 12:59         ` Igor Mammedov
  0 siblings, 1 reply; 7+ messages in thread
From: lizhijian @ 2021-09-13  6:40 UTC (permalink / raw)
  To: Igor Mammedov, mst, xiaoguangrong.eric; +Cc: qemu-devel


ping again




On 30/08/2021 09:04, Li Zhijian wrote:
> ping
>
>
> On 03/08/2021 12:00, Li, Zhijian wrote:
>> ping
>>
>> Any body could help to review/queue this patch ?
>>
>>
>>
>> On 2021/6/29 22:05, Igor Mammedov wrote:
>>> On Thu, 24 Jun 2021 19:04:15 +0800
>>> Li Zhijian <lizhijian@cn.fujitsu.com> wrote:
>>>
>>>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>>> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>>>
>>>> ---
>>>>   hw/acpi/nvdimm.c | 12 ++++++------
>>>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
>>>> index e3d5fe19392..ff317263e85 100644
>>>> --- a/hw/acpi/nvdimm.c
>>>> +++ b/hw/acpi/nvdimm.c
>>>> @@ -355,10 +355,10 @@ nvdimm_build_structure_caps(GArray *structures, uint32_t capabilities)
>>>>     static GArray *nvdimm_build_device_structure(NVDIMMState *state)
>>>>   {
>>>> -    GSList *device_list = nvdimm_get_device_list();
>>>> +    GSList *device_list, *list = nvdimm_get_device_list();
>>>>       GArray *structures = g_array_new(false, true /* clear */, 1);
>>>>   -    for (; device_list; device_list = device_list->next) {
>>>> +    for (device_list = list; device_list; device_list = device_list->next) {
>>>>           DeviceState *dev = device_list->data;
>>>>             /* build System Physical Address Range Structure. */
>>>> @@ -373,7 +373,7 @@ static GArray *nvdimm_build_device_structure(NVDIMMState *state)
>>>>           /* build NVDIMM Control Region Structure. */
>>>>           nvdimm_build_structure_dcr(structures, dev);
>>>>       }
>>>> -    g_slist_free(device_list);
>>>> +    g_slist_free(list);
>>>>         if (state->persistence) {
>>>>           nvdimm_build_structure_caps(structures, state->persistence);
>>>> @@ -1339,9 +1339,9 @@ static void nvdimm_build_ssdt(GArray *table_offsets, GArray *table_data,
>>>>     void nvdimm_build_srat(GArray *table_data)
>>>>   {
>>>> -    GSList *device_list = nvdimm_get_device_list();
>>>> +    GSList *device_list, *list = nvdimm_get_device_list();
>>>>   -    for (; device_list; device_list = device_list->next) {
>>>> +    for (device_list = list; device_list; device_list = device_list->next) {
>>>>           AcpiSratMemoryAffinity *numamem = NULL;
>>>>           DeviceState *dev = device_list->data;
>>>>           Object *obj = OBJECT(dev);
>>>> @@ -1356,7 +1356,7 @@ void nvdimm_build_srat(GArray *table_data)
>>>>           build_srat_memory(numamem, addr, size, node,
>>>>                             MEM_AFFINITY_ENABLED | MEM_AFFINITY_NON_VOLATILE);
>>>>       }
>>>> -    g_slist_free(device_list);
>>>> +    g_slist_free(list);
>>>>   }
>>>>     void nvdimm_build_acpi(GArray *table_offsets, GArray *table_data,
>>>
>>>
>>
>>
>>
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] nvdimm: release the correct device list
  2021-09-13  6:40       ` lizhijian
@ 2021-09-17 12:59         ` Igor Mammedov
  2021-09-22  6:40           ` Michael S. Tsirkin
  0 siblings, 1 reply; 7+ messages in thread
From: Igor Mammedov @ 2021-09-17 12:59 UTC (permalink / raw)
  To: lizhijian, mst; +Cc: xiaoguangrong.eric, qemu-devel

On Mon, 13 Sep 2021 06:40:01 +0000
"lizhijian@fujitsu.com" <lizhijian@fujitsu.com> wrote:

> ping again

Michael,

can you include this in your next pull req, please?

> 
> 
> 
> On 30/08/2021 09:04, Li Zhijian wrote:
> > ping
> >
> >
> > On 03/08/2021 12:00, Li, Zhijian wrote:  
> >> ping
> >>
> >> Any body could help to review/queue this patch ?
> >>
> >>
> >>
> >> On 2021/6/29 22:05, Igor Mammedov wrote:  
> >>> On Thu, 24 Jun 2021 19:04:15 +0800
> >>> Li Zhijian <lizhijian@cn.fujitsu.com> wrote:
> >>>  
> >>>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>  
> >>> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> >>>  
> >>>> ---
> >>>>   hw/acpi/nvdimm.c | 12 ++++++------
> >>>>   1 file changed, 6 insertions(+), 6 deletions(-)
> >>>>
> >>>> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
> >>>> index e3d5fe19392..ff317263e85 100644
> >>>> --- a/hw/acpi/nvdimm.c
> >>>> +++ b/hw/acpi/nvdimm.c
> >>>> @@ -355,10 +355,10 @@ nvdimm_build_structure_caps(GArray *structures, uint32_t capabilities)
> >>>>     static GArray *nvdimm_build_device_structure(NVDIMMState *state)
> >>>>   {
> >>>> -    GSList *device_list = nvdimm_get_device_list();
> >>>> +    GSList *device_list, *list = nvdimm_get_device_list();
> >>>>       GArray *structures = g_array_new(false, true /* clear */, 1);
> >>>>   -    for (; device_list; device_list = device_list->next) {
> >>>> +    for (device_list = list; device_list; device_list = device_list->next) {
> >>>>           DeviceState *dev = device_list->data;
> >>>>             /* build System Physical Address Range Structure. */
> >>>> @@ -373,7 +373,7 @@ static GArray *nvdimm_build_device_structure(NVDIMMState *state)
> >>>>           /* build NVDIMM Control Region Structure. */
> >>>>           nvdimm_build_structure_dcr(structures, dev);
> >>>>       }
> >>>> -    g_slist_free(device_list);
> >>>> +    g_slist_free(list);
> >>>>         if (state->persistence) {
> >>>>           nvdimm_build_structure_caps(structures, state->persistence);
> >>>> @@ -1339,9 +1339,9 @@ static void nvdimm_build_ssdt(GArray *table_offsets, GArray *table_data,
> >>>>     void nvdimm_build_srat(GArray *table_data)
> >>>>   {
> >>>> -    GSList *device_list = nvdimm_get_device_list();
> >>>> +    GSList *device_list, *list = nvdimm_get_device_list();
> >>>>   -    for (; device_list; device_list = device_list->next) {
> >>>> +    for (device_list = list; device_list; device_list = device_list->next) {
> >>>>           AcpiSratMemoryAffinity *numamem = NULL;
> >>>>           DeviceState *dev = device_list->data;
> >>>>           Object *obj = OBJECT(dev);
> >>>> @@ -1356,7 +1356,7 @@ void nvdimm_build_srat(GArray *table_data)
> >>>>           build_srat_memory(numamem, addr, size, node,
> >>>>                             MEM_AFFINITY_ENABLED | MEM_AFFINITY_NON_VOLATILE);
> >>>>       }
> >>>> -    g_slist_free(device_list);
> >>>> +    g_slist_free(list);
> >>>>   }
> >>>>     void nvdimm_build_acpi(GArray *table_offsets, GArray *table_data,  
> >>>
> >>>  
> >>
> >>
> >>  
> >  



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] nvdimm: release the correct device list
  2021-09-17 12:59         ` Igor Mammedov
@ 2021-09-22  6:40           ` Michael S. Tsirkin
  0 siblings, 0 replies; 7+ messages in thread
From: Michael S. Tsirkin @ 2021-09-22  6:40 UTC (permalink / raw)
  To: Igor Mammedov; +Cc: xiaoguangrong.eric, lizhijian, qemu-devel

On Fri, Sep 17, 2021 at 02:59:33PM +0200, Igor Mammedov wrote:
> On Mon, 13 Sep 2021 06:40:01 +0000
> "lizhijian@fujitsu.com" <lizhijian@fujitsu.com> wrote:
> 
> > ping again
> 
> Michael,
> 
> can you include this in your next pull req, please?

ok

> > 
> > 
> > 
> > On 30/08/2021 09:04, Li Zhijian wrote:
> > > ping
> > >
> > >
> > > On 03/08/2021 12:00, Li, Zhijian wrote:  
> > >> ping
> > >>
> > >> Any body could help to review/queue this patch ?
> > >>
> > >>
> > >>
> > >> On 2021/6/29 22:05, Igor Mammedov wrote:  
> > >>> On Thu, 24 Jun 2021 19:04:15 +0800
> > >>> Li Zhijian <lizhijian@cn.fujitsu.com> wrote:
> > >>>  
> > >>>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>  
> > >>> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> > >>>  
> > >>>> ---
> > >>>>   hw/acpi/nvdimm.c | 12 ++++++------
> > >>>>   1 file changed, 6 insertions(+), 6 deletions(-)
> > >>>>
> > >>>> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
> > >>>> index e3d5fe19392..ff317263e85 100644
> > >>>> --- a/hw/acpi/nvdimm.c
> > >>>> +++ b/hw/acpi/nvdimm.c
> > >>>> @@ -355,10 +355,10 @@ nvdimm_build_structure_caps(GArray *structures, uint32_t capabilities)
> > >>>>     static GArray *nvdimm_build_device_structure(NVDIMMState *state)
> > >>>>   {
> > >>>> -    GSList *device_list = nvdimm_get_device_list();
> > >>>> +    GSList *device_list, *list = nvdimm_get_device_list();
> > >>>>       GArray *structures = g_array_new(false, true /* clear */, 1);
> > >>>>   -    for (; device_list; device_list = device_list->next) {
> > >>>> +    for (device_list = list; device_list; device_list = device_list->next) {
> > >>>>           DeviceState *dev = device_list->data;
> > >>>>             /* build System Physical Address Range Structure. */
> > >>>> @@ -373,7 +373,7 @@ static GArray *nvdimm_build_device_structure(NVDIMMState *state)
> > >>>>           /* build NVDIMM Control Region Structure. */
> > >>>>           nvdimm_build_structure_dcr(structures, dev);
> > >>>>       }
> > >>>> -    g_slist_free(device_list);
> > >>>> +    g_slist_free(list);
> > >>>>         if (state->persistence) {
> > >>>>           nvdimm_build_structure_caps(structures, state->persistence);
> > >>>> @@ -1339,9 +1339,9 @@ static void nvdimm_build_ssdt(GArray *table_offsets, GArray *table_data,
> > >>>>     void nvdimm_build_srat(GArray *table_data)
> > >>>>   {
> > >>>> -    GSList *device_list = nvdimm_get_device_list();
> > >>>> +    GSList *device_list, *list = nvdimm_get_device_list();
> > >>>>   -    for (; device_list; device_list = device_list->next) {
> > >>>> +    for (device_list = list; device_list; device_list = device_list->next) {
> > >>>>           AcpiSratMemoryAffinity *numamem = NULL;
> > >>>>           DeviceState *dev = device_list->data;
> > >>>>           Object *obj = OBJECT(dev);
> > >>>> @@ -1356,7 +1356,7 @@ void nvdimm_build_srat(GArray *table_data)
> > >>>>           build_srat_memory(numamem, addr, size, node,
> > >>>>                             MEM_AFFINITY_ENABLED | MEM_AFFINITY_NON_VOLATILE);
> > >>>>       }
> > >>>> -    g_slist_free(device_list);
> > >>>> +    g_slist_free(list);
> > >>>>   }
> > >>>>     void nvdimm_build_acpi(GArray *table_offsets, GArray *table_data,  
> > >>>
> > >>>  
> > >>
> > >>
> > >>  
> > >  



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-09-22  6:42 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-24 11:04 [PATCH] nvdimm: release the correct device list Li Zhijian
2021-06-29 14:05 ` Igor Mammedov
2021-08-03  4:00   ` Li, Zhijian/李 智坚
2021-08-30  1:06     ` lizhijian
2021-09-13  6:40       ` lizhijian
2021-09-17 12:59         ` Igor Mammedov
2021-09-22  6:40           ` Michael S. Tsirkin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).