* [PATCH] target/i386: Correct the warning message of Intel PT
@ 2020-06-30 6:38 Luwei Kang
2020-07-01 14:21 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Luwei Kang @ 2020-06-30 6:38 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, Luwei Kang, ehabkost, rth
The CPUID level need to be set to 0x14 manually on old
machine-type if Intel PT is enabled in guest. E.g. the
CPUID[0].EAX(level)=7 and CPUID[7].EBX[25](intel-pt)=1 when the
Qemu with "-machine pc-i440fx-3.1 -cpu qemu64,+intel-pt" parameter.
This patch corrects the warning message of the previous
submission(ddc2fc9).
Signed-off-by: Luwei Kang <luwei.kang@intel.com>
---
target/i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 90ffc5f..a0e39d1 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -6375,7 +6375,7 @@ static void x86_cpu_expand_features(X86CPU *cpu, Error **errp)
} else if (cpu->env.cpuid_min_level < 0x14) {
mark_unavailable_features(cpu, FEAT_7_0_EBX,
CPUID_7_0_EBX_INTEL_PT,
- "Intel PT need CPUID leaf 0x14, please set by \"-cpu ...,+intel-pt,level=0x14\"");
+ "Intel PT need CPUID leaf 0x14, please set by \"-cpu ...,+intel-pt,min-level=0x14\"");
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] target/i386: Correct the warning message of Intel PT
2020-06-30 6:38 [PATCH] target/i386: Correct the warning message of Intel PT Luwei Kang
@ 2020-07-01 14:21 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2020-07-01 14:21 UTC (permalink / raw)
To: Luwei Kang, qemu-devel; +Cc: ehabkost, rth
On 30/06/20 08:38, Luwei Kang wrote:
> The CPUID level need to be set to 0x14 manually on old
> machine-type if Intel PT is enabled in guest. E.g. the
> CPUID[0].EAX(level)=7 and CPUID[7].EBX[25](intel-pt)=1 when the
> Qemu with "-machine pc-i440fx-3.1 -cpu qemu64,+intel-pt" parameter.
>
> This patch corrects the warning message of the previous
> submission(ddc2fc9).
>
> Signed-off-by: Luwei Kang <luwei.kang@intel.com>
> ---
> target/i386/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 90ffc5f..a0e39d1 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -6375,7 +6375,7 @@ static void x86_cpu_expand_features(X86CPU *cpu, Error **errp)
> } else if (cpu->env.cpuid_min_level < 0x14) {
> mark_unavailable_features(cpu, FEAT_7_0_EBX,
> CPUID_7_0_EBX_INTEL_PT,
> - "Intel PT need CPUID leaf 0x14, please set by \"-cpu ...,+intel-pt,level=0x14\"");
> + "Intel PT need CPUID leaf 0x14, please set by \"-cpu ...,+intel-pt,min-level=0x14\"");
> }
> }
>
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-01 14:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-30 6:38 [PATCH] target/i386: Correct the warning message of Intel PT Luwei Kang
2020-07-01 14:21 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).