[PATCH] qdev-monitor: Forbid repeated device_del

* [PATCH] qdev-monitor: Forbid repeated device_del
@ 2020-02-20 16:55 Julia Suvorova
  2020-02-21 13:53 ` Stefan Hajnoczi
  0 siblings, 1 reply; 3+ messages in thread
From: Julia Suvorova @ 2020-02-20 16:55 UTC (permalink / raw)
  To: qemu-devel
  Cc: Paolo Bonzini, Daniel P. Berrangé,
	Eduardo Habkost, Julia Suvorova, Michael S. Tsirkin

Device unplug can be done asynchronously. Thus, sending the second
device_del before the previous unplug is complete may lead to
unexpected results. On PCIe devices, this cancels the hot-unplug
process.

Signed-off-by: Julia Suvorova <jusual@redhat.com>
---
 qdev-monitor.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/qdev-monitor.c b/qdev-monitor.c
index 8ce71a206b..8a2a9538cd 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -887,6 +887,12 @@ void qmp_device_del(const char *id, Error **errp)
 {
     DeviceState *dev = find_device_state(id, errp);
     if (dev != NULL) {
+        if (dev->pending_deleted_event) {
+            error_setg(errp, "Device %s is already in the "
+                             "process of unplug", id);
+            return;
+        }
+
         qdev_unplug(dev, errp);
     }
 }
-- 
2.24.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread