qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] gitlab-ci: Test linux-user on CentOS 7
@ 2021-01-21 17:28 Philippe Mathieu-Daudé
  2021-01-21 17:28 ` [PATCH v2 1/2] tests/docker: Install static libc package in " Philippe Mathieu-Daudé
  2021-01-21 17:28 ` [PATCH v2 2/2] gitlab-ci: Test building linux-user targets on " Philippe Mathieu-Daudé
  0 siblings, 2 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-21 17:28 UTC (permalink / raw)
  To: qemu-devel
  Cc: Fam Zheng, Peter Maydell, Thomas Huth,
	Philippe Mathieu-Daudé,
	Laurent Vivier, Wainer dos Santos Moschetta,
	Philippe Mathieu-Daudé,
	Alex Bennée

The first patch adds the static libc package to the CentOS 7
Docker image so then we can run the TCG linux-user tests on
it (second patch).

Since v1:
- added first patch

Philippe Mathieu-Daudé (2):
  tests/docker: Install static libc package in CentOS 7
  gitlab-ci: Test building linux-user targets on CentOS 7

 .gitlab-ci.yml                          | 7 +++++++
 tests/docker/dockerfiles/centos7.docker | 1 +
 2 files changed, 8 insertions(+)

-- 
2.26.2



^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH v2 1/2] tests/docker: Install static libc package in CentOS 7
  2021-01-21 17:28 [PATCH v2 0/2] gitlab-ci: Test linux-user on CentOS 7 Philippe Mathieu-Daudé
@ 2021-01-21 17:28 ` Philippe Mathieu-Daudé
  2021-01-21 18:25   ` Thomas Huth
  2021-01-21 18:30   ` Wainer dos Santos Moschetta
  2021-01-21 17:28 ` [PATCH v2 2/2] gitlab-ci: Test building linux-user targets on " Philippe Mathieu-Daudé
  1 sibling, 2 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-21 17:28 UTC (permalink / raw)
  To: qemu-devel
  Cc: Fam Zheng, Peter Maydell, Thomas Huth,
	Philippe Mathieu-Daudé,
	Laurent Vivier, Wainer dos Santos Moschetta,
	Philippe Mathieu-Daudé,
	Alex Bennée

We need to install the static libc package to be able to run
the TCG tests:

  $ make check-tcg
  ...
    BUILD   TCG tests for x86_64-softmmu
    BUILD   x86_64-softmmu guest-tests with cc
  /usr/bin/ld: hello: warning: allocated section `.notes' not in segment
  /usr/bin/ld: memory: warning: allocated section `.notes' not in segment
    BUILD   TCG tests for x86_64-linux-user
    BUILD   x86_64-linux-user guest-tests with cc
  /usr/bin/ld: cannot find -lpthread
  /usr/bin/ld: cannot find -lc
  collect2: error: ld returned 1 exit status
  make[2]: *** [threadcount] Error 1
  make[1]: *** [cross-build-guest-tests] Error 2
  make: *** [build-tcg-tests-x86_64-linux-user] Error 2

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 tests/docker/dockerfiles/centos7.docker | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/docker/dockerfiles/centos7.docker b/tests/docker/dockerfiles/centos7.docker
index 6f11af1989e..75fdb53c7c0 100644
--- a/tests/docker/dockerfiles/centos7.docker
+++ b/tests/docker/dockerfiles/centos7.docker
@@ -15,6 +15,7 @@ ENV PACKAGES \
     gettext \
     git \
     glib2-devel \
+    glibc-static \
     gnutls-devel \
     libaio-devel \
     libepoxy-devel \
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH v2 2/2] gitlab-ci: Test building linux-user targets on CentOS 7
  2021-01-21 17:28 [PATCH v2 0/2] gitlab-ci: Test linux-user on CentOS 7 Philippe Mathieu-Daudé
  2021-01-21 17:28 ` [PATCH v2 1/2] tests/docker: Install static libc package in " Philippe Mathieu-Daudé
@ 2021-01-21 17:28 ` Philippe Mathieu-Daudé
  2021-01-21 17:45   ` Wainer dos Santos Moschetta
                     ` (2 more replies)
  1 sibling, 3 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-21 17:28 UTC (permalink / raw)
  To: qemu-devel
  Cc: Fam Zheng, Peter Maydell, Thomas Huth, Daniel P . Berrangé,
	Philippe Mathieu-Daudé,
	Laurent Vivier, Wainer dos Santos Moschetta,
	Philippe Mathieu-Daudé,
	Alex Bennée

Add a configuration tested by Peter Maydell (see [1] and [2])
but not covered in our CI [3]:

  [705/2910] Compiling C object libqemu-arm-linux-user.fa.p/linux-user_strace.c.o
  FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o
  ../linux-user/strace.c: In function 'do_print_sockopt':
  ../linux-user/strace.c:2831:14: error: 'IPV6_ADDR_PREFERENCES' undeclared (first use in this function)
           case IPV6_ADDR_PREFERENCES:
                ^

This job currently takes 31 minutes 32 seconds ([4]).

[1] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05086.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05379.html
[3] https://gitlab.com/philmd/qemu/-/jobs/977408284
[4] https://gitlab.com/philmd/qemu/-/jobs/978223286

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 .gitlab-ci.yml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index de3a3d25b58..af4d74757d8 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -411,6 +411,13 @@ build-user-plugins:
     MAKE_CHECK_ARGS: check-tcg
   timeout: 1h 30m
 
+build-user-centos7:
+  <<: *native_build_job_definition
+  variables:
+    IMAGE: centos7
+    CONFIGURE_ARGS: --disable-system --disable-tools --disable-docs
+    MAKE_CHECK_ARGS: check-tcg
+
 build-some-softmmu-plugins:
   <<: *native_build_job_definition
   variables:
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/2] gitlab-ci: Test building linux-user targets on CentOS 7
  2021-01-21 17:28 ` [PATCH v2 2/2] gitlab-ci: Test building linux-user targets on " Philippe Mathieu-Daudé
@ 2021-01-21 17:45   ` Wainer dos Santos Moschetta
  2021-01-21 18:20     ` Philippe Mathieu-Daudé
  2021-01-21 18:25   ` Thomas Huth
  2021-01-21 18:33   ` Wainer dos Santos Moschetta
  2 siblings, 1 reply; 10+ messages in thread
From: Wainer dos Santos Moschetta @ 2021-01-21 17:45 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: Fam Zheng, Peter Maydell, Thomas Huth, Daniel P . Berrangé,
	Philippe Mathieu-Daudé,
	Laurent Vivier, Alex Bennée

Hi,

On 1/21/21 2:28 PM, Philippe Mathieu-Daudé wrote:
> Add a configuration tested by Peter Maydell (see [1] and [2])
> but not covered in our CI [3]:
>
>    [705/2910] Compiling C object libqemu-arm-linux-user.fa.p/linux-user_strace.c.o
>    FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o
>    ../linux-user/strace.c: In function 'do_print_sockopt':
>    ../linux-user/strace.c:2831:14: error: 'IPV6_ADDR_PREFERENCES' undeclared (first use in this function)
>             case IPV6_ADDR_PREFERENCES:

Why the following builder did not catch that issue?

build-user:
   <<: *native_build_job_definition
   variables:
     IMAGE: debian-all-test-cross
     CONFIGURE_ARGS: --disable-tools --disable-system
     MAKE_CHECK_ARGS: check-tcg

>                  ^
>
> This job currently takes 31 minutes 32 seconds ([4]).
>
> [1] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05086.html
> [2] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05379.html
> [3] https://gitlab.com/philmd/qemu/-/jobs/977408284
> [4] https://gitlab.com/philmd/qemu/-/jobs/978223286
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   .gitlab-ci.yml | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index de3a3d25b58..af4d74757d8 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -411,6 +411,13 @@ build-user-plugins:
>       MAKE_CHECK_ARGS: check-tcg
>     timeout: 1h 30m
>   
> +build-user-centos7:
> +  <<: *native_build_job_definition
> +  variables:
> +    IMAGE: centos7
> +    CONFIGURE_ARGS: --disable-system --disable-tools --disable-docs
> +    MAKE_CHECK_ARGS: check-tcg
> +
>   build-some-softmmu-plugins:
>     <<: *native_build_job_definition
>     variables:



^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/2] gitlab-ci: Test building linux-user targets on CentOS 7
  2021-01-21 17:45   ` Wainer dos Santos Moschetta
@ 2021-01-21 18:20     ` Philippe Mathieu-Daudé
  2021-01-21 18:29       ` Wainer dos Santos Moschetta
  0 siblings, 1 reply; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-21 18:20 UTC (permalink / raw)
  To: Wainer dos Santos Moschetta
  Cc: Fam Zheng, Peter Maydell, Thomas Huth, Daniel P . Berrangé,
	Philippe Mathieu-Daudé,
	qemu-devel@nongnu.org Developers, Laurent Vivier,
	Alex Bennée

On Thu, Jan 21, 2021 at 6:45 PM Wainer dos Santos Moschetta
<wainersm@redhat.com> wrote:
> On 1/21/21 2:28 PM, Philippe Mathieu-Daudé wrote:
> > Add a configuration tested by Peter Maydell (see [1] and [2])
> > but not covered in our CI [3]:
> >
> >    [705/2910] Compiling C object libqemu-arm-linux-user.fa.p/linux-user_strace.c.o
> >    FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o
> >    ../linux-user/strace.c: In function 'do_print_sockopt':
> >    ../linux-user/strace.c:2831:14: error: 'IPV6_ADDR_PREFERENCES' undeclared (first use in this function)
> >             case IPV6_ADDR_PREFERENCES:
>
> Why the following builder did not catch that issue?
>
> build-user:
>    <<: *native_build_job_definition
>    variables:
>      IMAGE: debian-all-test-cross
>      CONFIGURE_ARGS: --disable-tools --disable-system
>      MAKE_CHECK_ARGS: check-tcg

It uses a different base image, debian-all-test-cross, which is based
on Debian 10.

Packages are more recent than CentOS 7.
QEMU aims to support the 2 latest releases from major distribs.
CentOS 7 is likely the oldest.


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/2] tests/docker: Install static libc package in CentOS 7
  2021-01-21 17:28 ` [PATCH v2 1/2] tests/docker: Install static libc package in " Philippe Mathieu-Daudé
@ 2021-01-21 18:25   ` Thomas Huth
  2021-01-21 18:30   ` Wainer dos Santos Moschetta
  1 sibling, 0 replies; 10+ messages in thread
From: Thomas Huth @ 2021-01-21 18:25 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: Fam Zheng, Peter Maydell, Philippe Mathieu-Daudé,
	Laurent Vivier, Wainer dos Santos Moschetta, Alex Bennée

On 21/01/2021 18.28, Philippe Mathieu-Daudé wrote:
> We need to install the static libc package to be able to run
> the TCG tests:
> 
>    $ make check-tcg
>    ...
>      BUILD   TCG tests for x86_64-softmmu
>      BUILD   x86_64-softmmu guest-tests with cc
>    /usr/bin/ld: hello: warning: allocated section `.notes' not in segment
>    /usr/bin/ld: memory: warning: allocated section `.notes' not in segment
>      BUILD   TCG tests for x86_64-linux-user
>      BUILD   x86_64-linux-user guest-tests with cc
>    /usr/bin/ld: cannot find -lpthread
>    /usr/bin/ld: cannot find -lc
>    collect2: error: ld returned 1 exit status
>    make[2]: *** [threadcount] Error 1
>    make[1]: *** [cross-build-guest-tests] Error 2
>    make: *** [build-tcg-tests-x86_64-linux-user] Error 2
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   tests/docker/dockerfiles/centos7.docker | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/docker/dockerfiles/centos7.docker b/tests/docker/dockerfiles/centos7.docker
> index 6f11af1989e..75fdb53c7c0 100644
> --- a/tests/docker/dockerfiles/centos7.docker
> +++ b/tests/docker/dockerfiles/centos7.docker
> @@ -15,6 +15,7 @@ ENV PACKAGES \
>       gettext \
>       git \
>       glib2-devel \
> +    glibc-static \
>       gnutls-devel \
>       libaio-devel \
>       libepoxy-devel \

Reviewed-by: Thomas Huth <thuth@redhat.com>



^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/2] gitlab-ci: Test building linux-user targets on CentOS 7
  2021-01-21 17:28 ` [PATCH v2 2/2] gitlab-ci: Test building linux-user targets on " Philippe Mathieu-Daudé
  2021-01-21 17:45   ` Wainer dos Santos Moschetta
@ 2021-01-21 18:25   ` Thomas Huth
  2021-01-21 18:33   ` Wainer dos Santos Moschetta
  2 siblings, 0 replies; 10+ messages in thread
From: Thomas Huth @ 2021-01-21 18:25 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: Fam Zheng, Peter Maydell, Daniel P . Berrangé,
	Philippe Mathieu-Daudé,
	Laurent Vivier, Wainer dos Santos Moschetta, Alex Bennée

On 21/01/2021 18.28, Philippe Mathieu-Daudé wrote:
> Add a configuration tested by Peter Maydell (see [1] and [2])
> but not covered in our CI [3]:
> 
>    [705/2910] Compiling C object libqemu-arm-linux-user.fa.p/linux-user_strace.c.o
>    FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o
>    ../linux-user/strace.c: In function 'do_print_sockopt':
>    ../linux-user/strace.c:2831:14: error: 'IPV6_ADDR_PREFERENCES' undeclared (first use in this function)
>             case IPV6_ADDR_PREFERENCES:
>                  ^
> 
> This job currently takes 31 minutes 32 seconds ([4]).
> 
> [1] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05086.html
> [2] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05379.html
> [3] https://gitlab.com/philmd/qemu/-/jobs/977408284
> [4] https://gitlab.com/philmd/qemu/-/jobs/978223286
> 
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   .gitlab-ci.yml | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index de3a3d25b58..af4d74757d8 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -411,6 +411,13 @@ build-user-plugins:
>       MAKE_CHECK_ARGS: check-tcg
>     timeout: 1h 30m
>   
> +build-user-centos7:
> +  <<: *native_build_job_definition
> +  variables:
> +    IMAGE: centos7
> +    CONFIGURE_ARGS: --disable-system --disable-tools --disable-docs
> +    MAKE_CHECK_ARGS: check-tcg
> +
>   build-some-softmmu-plugins:
>     <<: *native_build_job_definition
>     variables:
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>



^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/2] gitlab-ci: Test building linux-user targets on CentOS 7
  2021-01-21 18:20     ` Philippe Mathieu-Daudé
@ 2021-01-21 18:29       ` Wainer dos Santos Moschetta
  0 siblings, 0 replies; 10+ messages in thread
From: Wainer dos Santos Moschetta @ 2021-01-21 18:29 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: Fam Zheng, Peter Maydell, Thomas Huth, Daniel P . Berrangé,
	Philippe Mathieu-Daudé,
	qemu-devel@nongnu.org Developers, Laurent Vivier,
	Alex Bennée


On 1/21/21 3:20 PM, Philippe Mathieu-Daudé wrote:
> On Thu, Jan 21, 2021 at 6:45 PM Wainer dos Santos Moschetta
> <wainersm@redhat.com> wrote:
>> On 1/21/21 2:28 PM, Philippe Mathieu-Daudé wrote:
>>> Add a configuration tested by Peter Maydell (see [1] and [2])
>>> but not covered in our CI [3]:
>>>
>>>     [705/2910] Compiling C object libqemu-arm-linux-user.fa.p/linux-user_strace.c.o
>>>     FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o
>>>     ../linux-user/strace.c: In function 'do_print_sockopt':
>>>     ../linux-user/strace.c:2831:14: error: 'IPV6_ADDR_PREFERENCES' undeclared (first use in this function)
>>>              case IPV6_ADDR_PREFERENCES:
>> Why the following builder did not catch that issue?
>>
>> build-user:
>>     <<: *native_build_job_definition
>>     variables:
>>       IMAGE: debian-all-test-cross
>>       CONFIGURE_ARGS: --disable-tools --disable-system
>>       MAKE_CHECK_ARGS: check-tcg
> It uses a different base image, debian-all-test-cross, which is based
> on Debian 10.
>
> Packages are more recent than CentOS 7.
> QEMU aims to support the 2 latest releases from major distribs.
> CentOS 7 is likely the oldest.


Oh sorry, my emails filters aren't working fine so I missed Daniel's 
reply on talking about it. Thanks for explaining again. :)

- Wainer

>



^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/2] tests/docker: Install static libc package in CentOS 7
  2021-01-21 17:28 ` [PATCH v2 1/2] tests/docker: Install static libc package in " Philippe Mathieu-Daudé
  2021-01-21 18:25   ` Thomas Huth
@ 2021-01-21 18:30   ` Wainer dos Santos Moschetta
  1 sibling, 0 replies; 10+ messages in thread
From: Wainer dos Santos Moschetta @ 2021-01-21 18:30 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: Fam Zheng, Peter Maydell, Thomas Huth,
	Philippe Mathieu-Daudé,
	Laurent Vivier, Alex Bennée


On 1/21/21 2:28 PM, Philippe Mathieu-Daudé wrote:
> We need to install the static libc package to be able to run
> the TCG tests:
>
>    $ make check-tcg
>    ...
>      BUILD   TCG tests for x86_64-softmmu
>      BUILD   x86_64-softmmu guest-tests with cc
>    /usr/bin/ld: hello: warning: allocated section `.notes' not in segment
>    /usr/bin/ld: memory: warning: allocated section `.notes' not in segment
>      BUILD   TCG tests for x86_64-linux-user
>      BUILD   x86_64-linux-user guest-tests with cc
>    /usr/bin/ld: cannot find -lpthread
>    /usr/bin/ld: cannot find -lc
>    collect2: error: ld returned 1 exit status
>    make[2]: *** [threadcount] Error 1
>    make[1]: *** [cross-build-guest-tests] Error 2
>    make: *** [build-tcg-tests-x86_64-linux-user] Error 2
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   tests/docker/dockerfiles/centos7.docker | 1 +
>   1 file changed, 1 insertion(+)


Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>


>
> diff --git a/tests/docker/dockerfiles/centos7.docker b/tests/docker/dockerfiles/centos7.docker
> index 6f11af1989e..75fdb53c7c0 100644
> --- a/tests/docker/dockerfiles/centos7.docker
> +++ b/tests/docker/dockerfiles/centos7.docker
> @@ -15,6 +15,7 @@ ENV PACKAGES \
>       gettext \
>       git \
>       glib2-devel \
> +    glibc-static \
>       gnutls-devel \
>       libaio-devel \
>       libepoxy-devel \



^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/2] gitlab-ci: Test building linux-user targets on CentOS 7
  2021-01-21 17:28 ` [PATCH v2 2/2] gitlab-ci: Test building linux-user targets on " Philippe Mathieu-Daudé
  2021-01-21 17:45   ` Wainer dos Santos Moschetta
  2021-01-21 18:25   ` Thomas Huth
@ 2021-01-21 18:33   ` Wainer dos Santos Moschetta
  2 siblings, 0 replies; 10+ messages in thread
From: Wainer dos Santos Moschetta @ 2021-01-21 18:33 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: Fam Zheng, Peter Maydell, Thomas Huth, Daniel P . Berrangé,
	Alex Bennée, Laurent Vivier, Philippe Mathieu-Daudé


On 1/21/21 2:28 PM, Philippe Mathieu-Daudé wrote:
> Add a configuration tested by Peter Maydell (see [1] and [2])
> but not covered in our CI [3]:
>
>    [705/2910] Compiling C object libqemu-arm-linux-user.fa.p/linux-user_strace.c.o
>    FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o
>    ../linux-user/strace.c: In function 'do_print_sockopt':
>    ../linux-user/strace.c:2831:14: error: 'IPV6_ADDR_PREFERENCES' undeclared (first use in this function)
>             case IPV6_ADDR_PREFERENCES:
>                  ^
>
> This job currently takes 31 minutes 32 seconds ([4]).
>
> [1] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05086.html
> [2] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05379.html
> [3] https://gitlab.com/philmd/qemu/-/jobs/977408284
> [4] https://gitlab.com/philmd/qemu/-/jobs/978223286
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   .gitlab-ci.yml | 7 +++++++
>   1 file changed, 7 insertions(+)


Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>


>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index de3a3d25b58..af4d74757d8 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -411,6 +411,13 @@ build-user-plugins:
>       MAKE_CHECK_ARGS: check-tcg
>     timeout: 1h 30m
>   
> +build-user-centos7:
> +  <<: *native_build_job_definition
> +  variables:
> +    IMAGE: centos7
> +    CONFIGURE_ARGS: --disable-system --disable-tools --disable-docs
> +    MAKE_CHECK_ARGS: check-tcg
> +
>   build-some-softmmu-plugins:
>     <<: *native_build_job_definition
>     variables:



^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-01-21 18:42 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 17:28 [PATCH v2 0/2] gitlab-ci: Test linux-user on CentOS 7 Philippe Mathieu-Daudé
2021-01-21 17:28 ` [PATCH v2 1/2] tests/docker: Install static libc package in " Philippe Mathieu-Daudé
2021-01-21 18:25   ` Thomas Huth
2021-01-21 18:30   ` Wainer dos Santos Moschetta
2021-01-21 17:28 ` [PATCH v2 2/2] gitlab-ci: Test building linux-user targets on " Philippe Mathieu-Daudé
2021-01-21 17:45   ` Wainer dos Santos Moschetta
2021-01-21 18:20     ` Philippe Mathieu-Daudé
2021-01-21 18:29       ` Wainer dos Santos Moschetta
2021-01-21 18:25   ` Thomas Huth
2021-01-21 18:33   ` Wainer dos Santos Moschetta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).