From: Paolo Bonzini <bonzini@gnu.org>
To: Wanpeng Li <kernellwp@gmail.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] target-i386: adds PV_DEDICATED hint CPUID feature bit
Date: Fri, 9 Feb 2018 09:41:09 +0100 [thread overview]
Message-ID: <5100a4b2-0fe4-b6be-5d6f-4b61a23dc870@gnu.org> (raw)
In-Reply-To: <1518083060-5881-1-git-send-email-wanpengli@tencent.com>
On 08/02/2018 10:44, Wanpeng Li wrote:
> From: Wanpeng Li <wanpengli@tencent.com>
>
> Add PV_DEDICATED hint cpuid feature bit.
Please add a new feature word, since this is not a PV feature but more
like a performance hint.
Thanks,
Paolo
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> ---
> target/i386/cpu.c | 4 ++++
> target/i386/cpu.h | 3 +++
> 2 files changed, 7 insertions(+)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index d70954b..cf48931 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -4076,6 +4076,9 @@ static int x86_cpu_filter_features(X86CPU *cpu)
> x86_cpu_get_supported_feature_word(w, false);
> uint32_t requested_features = env->features[w];
> env->features[w] &= host_feat;
> + if (cpu->pv_dedicated && (w == FEAT_KVM)) {
> + env->features[w] |= CPUID_PV_DEDICATED;
> + }
> cpu->filtered_features[w] = requested_features & ~env->features[w];
> if (cpu->filtered_features[w]) {
> rv = 1;
> @@ -4682,6 +4685,7 @@ static Property x86_cpu_properties[] = {
> false),
> DEFINE_PROP_BOOL("vmware-cpuid-freq", X86CPU, vmware_cpuid_freq, true),
> DEFINE_PROP_BOOL("tcg-cpuid", X86CPU, expose_tcg, true),
> + DEFINE_PROP_BOOL("pv-dedicated", X86CPU, pv_dedicated, false),
>
> /*
> * From "Requirements for Implementing the Microsoft
> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
> index f91e37d..8000da5 100644
> --- a/target/i386/cpu.h
> +++ b/target/i386/cpu.h
> @@ -672,6 +672,8 @@ typedef uint32_t FeatureWordArray[FEATURE_WORDS];
>
> #define CPUID_8000_0008_EBX_IBPB (1U << 12) /* Indirect Branch Prediction Barrier */
>
> +#define CPUID_PV_DEDICATED (1U << 8)
> +
> #define CPUID_XSAVE_XSAVEOPT (1U << 0)
> #define CPUID_XSAVE_XSAVEC (1U << 1)
> #define CPUID_XSAVE_XGETBV1 (1U << 2)
> @@ -1276,6 +1278,7 @@ struct X86CPU {
> bool expose_kvm;
> bool expose_tcg;
> bool migratable;
> + bool pv_dedicated;
> bool max_features; /* Enable all supported features automatically */
> uint32_t apic_id;
>
>
next prev parent reply other threads:[~2018-02-09 8:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 9:44 [Qemu-devel] [PATCH] target-i386: adds PV_DEDICATED hint CPUID feature bit Wanpeng Li
2018-02-08 18:12 ` Eduardo Habkost
2018-02-09 3:18 ` Wanpeng Li
2018-02-09 8:41 ` Paolo Bonzini
2018-02-09 11:46 ` Eduardo Habkost
2018-02-09 12:24 ` Wanpeng Li
2018-02-09 12:46 ` Paolo Bonzini
2018-02-09 12:46 ` Eduardo Habkost
2018-02-09 14:26 ` Wanpeng Li
2018-02-09 8:41 ` Paolo Bonzini [this message]
2018-02-09 14:27 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5100a4b2-0fe4-b6be-5d6f-4b61a23dc870@gnu.org \
--to=bonzini@gnu.org \
--cc=ehabkost@redhat.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).