qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, Wanpeng Li <kernellwp@gmail.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] target-i386: adds PV_DEDICATED hint CPUID feature bit
Date: Fri, 9 Feb 2018 09:41:41 +0100	[thread overview]
Message-ID: <fcb084ce-1615-f100-4137-e0fa46098d7b@redhat.com> (raw)
In-Reply-To: <20180208181207.GB13981@localhost.localdomain>

On 08/02/2018 19:12, Eduardo Habkost wrote:
> On Thu, Feb 08, 2018 at 05:44:20PM +0800, Wanpeng Li wrote:
>> From: Wanpeng Li <wanpengli@tencent.com>
>>
>> Add PV_DEDICATED hint cpuid feature bit.
>>
> [...]
>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> index d70954b..cf48931 100644
>> --- a/target/i386/cpu.c
>> +++ b/target/i386/cpu.c
>> @@ -4076,6 +4076,9 @@ static int x86_cpu_filter_features(X86CPU *cpu)
>>              x86_cpu_get_supported_feature_word(w, false);
>>          uint32_t requested_features = env->features[w];
>>          env->features[w] &= host_feat;
>> +        if (cpu->pv_dedicated && (w == FEAT_KVM)) {
>> +            env->features[w] |= CPUID_PV_DEDICATED;
>> +        }
> 
> Why do this trick here instead of just adding "pv-dedicated" to
> feature_word_info[FEAT_KVM].feat_names?

I think because it can be added independent of KVM_GET_SUPPORTED_CPUID.

Paolo

  parent reply	other threads:[~2018-02-09  8:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-08  9:44 [Qemu-devel] [PATCH] target-i386: adds PV_DEDICATED hint CPUID feature bit Wanpeng Li
2018-02-08 18:12 ` Eduardo Habkost
2018-02-09  3:18   ` Wanpeng Li
2018-02-09  8:41   ` Paolo Bonzini [this message]
2018-02-09 11:46     ` Eduardo Habkost
2018-02-09 12:24       ` Wanpeng Li
2018-02-09 12:46         ` Paolo Bonzini
2018-02-09 12:46         ` Eduardo Habkost
2018-02-09 14:26           ` Wanpeng Li
2018-02-09  8:41 ` Paolo Bonzini
2018-02-09 14:27   ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcb084ce-1615-f100-4137-e0fa46098d7b@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).