From: BALATON Zoltan via <qemu-devel@nongnu.org>
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Herve Poussineau <hpoussin@reactos.org>,
Philippe Mathieu-Daude <f4bug@amsat.org>,
Artyom Tarasenko <atar4qemu@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 1/6] m48t59-isa: remove legacy m48t59_init_isa() function
Date: Sat, 17 Oct 2020 22:13:41 +0200 [thread overview]
Message-ID: <540c1f05cdd1c01ce45f46355d2829aa494e2adb.1602965621.git.balaton@eik.bme.hu> (raw)
In-Reply-To: <cover.1602965621.git.balaton@eik.bme.hu>
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
This function is no longer used within the codebase.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/rtc/m48t59-isa.c | 25 -------------------------
include/hw/rtc/m48t59.h | 2 --
2 files changed, 27 deletions(-)
diff --git a/hw/rtc/m48t59-isa.c b/hw/rtc/m48t59-isa.c
index cae315e488..dc21fb10a5 100644
--- a/hw/rtc/m48t59-isa.c
+++ b/hw/rtc/m48t59-isa.c
@@ -58,31 +58,6 @@ static M48txxInfo m48txx_isa_info[] = {
}
};
-Nvram *m48t59_init_isa(ISABus *bus, uint32_t io_base, uint16_t size,
- int base_year, int model)
-{
- ISADevice *isa_dev;
- DeviceState *dev;
- int i;
-
- for (i = 0; i < ARRAY_SIZE(m48txx_isa_info); i++) {
- if (m48txx_isa_info[i].size != size ||
- m48txx_isa_info[i].model != model) {
- continue;
- }
-
- isa_dev = isa_new(m48txx_isa_info[i].bus_name);
- dev = DEVICE(isa_dev);
- qdev_prop_set_uint32(dev, "iobase", io_base);
- qdev_prop_set_int32(dev, "base-year", base_year);
- isa_realize_and_unref(isa_dev, bus, &error_fatal);
- return NVRAM(dev);
- }
-
- assert(false);
- return NULL;
-}
-
static uint32_t m48txx_isa_read(Nvram *obj, uint32_t addr)
{
M48txxISAState *d = M48TXX_ISA(obj);
diff --git a/include/hw/rtc/m48t59.h b/include/hw/rtc/m48t59.h
index 04abedf3b2..9defe578d1 100644
--- a/include/hw/rtc/m48t59.h
+++ b/include/hw/rtc/m48t59.h
@@ -47,8 +47,6 @@ struct NvramClass {
void (*toggle_lock)(Nvram *obj, int lock);
};
-Nvram *m48t59_init_isa(ISABus *bus, uint32_t io_base, uint16_t size,
- int base_year, int type);
Nvram *m48t59_init(qemu_irq IRQ, hwaddr mem_base,
uint32_t io_base, uint16_t size, int base_year,
int type);
--
2.21.3
next prev parent reply other threads:[~2020-10-17 20:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 20:13 [PATCH 0/6] m48t59: remove legacy init functions BALATON Zoltan via
2020-10-17 20:13 ` [PATCH 6/6] m48t59: remove legacy m48t59_init() function BALATON Zoltan via
2020-10-17 20:13 ` [PATCH 4/6] sun4u: use qdev instead of " BALATON Zoltan via
2020-10-18 7:15 ` Philippe Mathieu-Daudé
2020-10-17 20:13 ` [PATCH 5/6] ppc405_boards: " BALATON Zoltan via
2020-10-18 7:13 ` Philippe Mathieu-Daudé
2020-10-17 20:13 ` BALATON Zoltan via [this message]
2020-10-17 20:13 ` [PATCH 3/6] sun4m: " BALATON Zoltan via
2020-10-18 7:12 ` Philippe Mathieu-Daudé
2020-10-17 20:13 ` [PATCH 2/6] mt48t59: Set default value of base-year property to 1968 BALATON Zoltan via
2020-10-18 7:11 ` Philippe Mathieu-Daudé
2020-10-18 16:13 ` [PATCH 0/6] m48t59: remove legacy init functions Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540c1f05cdd1c01ce45f46355d2829aa494e2adb.1602965621.git.balaton@eik.bme.hu \
--to=qemu-devel@nongnu.org \
--cc=atar4qemu@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=hpoussin@reactos.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).