From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: BALATON Zoltan <balaton@eik.bme.hu>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Herve Poussineau <hpoussin@reactos.org>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Artyom Tarasenko <atar4qemu@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 4/6] sun4u: use qdev instead of legacy m48t59_init() function
Date: Sun, 18 Oct 2020 09:15:36 +0200 [thread overview]
Message-ID: <c9866686-02d5-3fe1-444f-5091b1f7dfe8@amsat.org> (raw)
In-Reply-To: <2b7a5594c8c41dcae0ade3354a13540f83570ab0.1602965621.git.balaton@eik.bme.hu>
On 10/17/20 10:13 PM, BALATON Zoltan via wrote:
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/sparc64/sun4u.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
> index ad5ca2472a..a89ebed6f0 100644
> --- a/hw/sparc64/sun4u.c
> +++ b/hw/sparc64/sun4u.c
> @@ -671,10 +671,12 @@ static void sun4uv_init(MemoryRegion *address_space_mem,
> pci_ide_create_devs(pci_dev);
>
> /* Map NVRAM into I/O (ebus) space */
> - nvram = m48t59_init(NULL, 0, 0, NVRAM_SIZE, 1968, 59);
> - s = SYS_BUS_DEVICE(nvram);
> + dev = qdev_new("sysbus-m48t59");
> + s = SYS_BUS_DEVICE(dev);
> + sysbus_realize_and_unref(s, &error_fatal);
I'd use &error_abort here (so if that ever happens, it is
easier to debug it), otherwise:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> memory_region_add_subregion(pci_address_space_io(ebus), 0x2000,
> sysbus_mmio_get_region(s, 0));
> + nvram = NVRAM(dev);
>
> initrd_size = 0;
> initrd_addr = 0;
>
next prev parent reply other threads:[~2020-10-18 7:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 20:13 [PATCH 0/6] m48t59: remove legacy init functions BALATON Zoltan via
2020-10-17 20:13 ` [PATCH 6/6] m48t59: remove legacy m48t59_init() function BALATON Zoltan via
2020-10-17 20:13 ` [PATCH 4/6] sun4u: use qdev instead of " BALATON Zoltan via
2020-10-18 7:15 ` Philippe Mathieu-Daudé [this message]
2020-10-17 20:13 ` [PATCH 5/6] ppc405_boards: " BALATON Zoltan via
2020-10-18 7:13 ` Philippe Mathieu-Daudé
2020-10-17 20:13 ` [PATCH 1/6] m48t59-isa: remove legacy m48t59_init_isa() function BALATON Zoltan via
2020-10-17 20:13 ` [PATCH 3/6] sun4m: use qdev instead of legacy m48t59_init() function BALATON Zoltan via
2020-10-18 7:12 ` Philippe Mathieu-Daudé
2020-10-17 20:13 ` [PATCH 2/6] mt48t59: Set default value of base-year property to 1968 BALATON Zoltan via
2020-10-18 7:11 ` Philippe Mathieu-Daudé
2020-10-18 16:13 ` [PATCH 0/6] m48t59: remove legacy init functions Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9866686-02d5-3fe1-444f-5091b1f7dfe8@amsat.org \
--to=f4bug@amsat.org \
--cc=atar4qemu@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=hpoussin@reactos.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).