From: Pierre Morel <pmorel@linux.ibm.com>
To: Halil Pasic <pasic@linux.ibm.com>, Cornelia Huck <cohuck@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org, thuth@redhat.com,
frankja@linux.ibm.com, david@redhat.com
Subject: Re: [PATCH v1] s390x: kvm-unit-tests: a PONG device for Sub Channels tests
Date: Thu, 14 Nov 2019 18:37:42 +0100 [thread overview]
Message-ID: <558e18e3-631b-bf85-e6be-b43308a2acfc@linux.ibm.com> (raw)
In-Reply-To: <20191114140235.30a788d6.pasic@linux.ibm.com>
On 2019-11-14 14:02, Halil Pasic wrote:
> On Thu, 14 Nov 2019 11:38:23 +0100
> Cornelia Huck <cohuck@redhat.com> wrote:
>
>> On Wed, 13 Nov 2019 20:02:33 +0100
>> Pierre Morel <pmorel@linux.ibm.com> wrote:
>>
>> Minor nit for $SUBJECT: this isn't a kvm-unit-tests patch, that's just
>> one consumer :)
> And subchannel is one word in s390-speak.
OK, surely better for grep
>
> [..]
>
>> Some questions regarding this device and its intended usage:
>>
>> - What are you trying to test? Basic ccw processing, or something more
>> specific? Is there any way you can use the kvm-unit-test
>> infrastructure to test basic processing with an existing device?
> I'm also curious about the big picture (what is in scope and what out
> of scope). Your design should be evaluated in the light of intended
> usage.
>
> BTW have you had a look at this abandoned patch-set of mine:
>
> https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg04220.html
No, but now yes.
Yes, it is something similar, I can remember as you did it.
>
> We made some different design decisions, while aiming essentially for the
> same. Maybe it's due to different scope, maybe not. For instance one
> can't test IDA with PONG, I guess.
No not now.
Regards,
Pierre
--
Pierre Morel
IBM Lab Boeblingen
next prev parent reply other threads:[~2019-11-14 17:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 19:02 [PATCH v1] s390x: kvm-unit-tests: a PONG device for Sub Channels tests Pierre Morel
2019-11-14 10:38 ` Cornelia Huck
2019-11-14 12:33 ` Thomas Huth
2019-11-14 17:17 ` Pierre Morel
2019-11-15 14:22 ` Thomas Huth
2019-11-15 15:23 ` Pierre Morel
2019-11-14 13:02 ` Halil Pasic
2019-11-14 13:19 ` Cornelia Huck
2019-11-14 13:42 ` Halil Pasic
2019-11-14 17:42 ` Pierre Morel
2019-11-15 10:35 ` Cornelia Huck
2019-11-15 15:15 ` Pierre Morel
2019-11-14 17:37 ` Pierre Morel [this message]
2019-11-14 17:11 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558e18e3-631b-bf85-e6be-b43308a2acfc@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).