* [Qemu-devel] [PATCH 0/2] pci core function cleanup
@ 2016-01-27 10:29 Cao jin
2016-01-27 10:29 ` [Qemu-devel] [PATCH 1/2] pci core: function pci_host_bus_register() cleanup Cao jin
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Cao jin @ 2016-01-27 10:29 UTC (permalink / raw)
To: qemu-devel; +Cc: ehabkost, mst
See each commit message says please.
Cao jin (2):
pci core: function pci_host_bus_register() cleanup
pci core: function pci_bus_init() cleanup
hw/pci/pci.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
--
2.1.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH 1/2] pci core: function pci_host_bus_register() cleanup
2016-01-27 10:29 [Qemu-devel] [PATCH 0/2] pci core function cleanup Cao jin
@ 2016-01-27 10:29 ` Cao jin
2016-01-28 19:01 ` Eduardo Habkost
2016-01-27 10:29 ` [Qemu-devel] [PATCH 2/2] pci core: function pci_bus_init() cleanup Cao jin
2016-02-05 1:37 ` [Qemu-devel] [PATCH 0/2] pci core function cleanup Cao jin
2 siblings, 1 reply; 6+ messages in thread
From: Cao jin @ 2016-01-27 10:29 UTC (permalink / raw)
To: qemu-devel; +Cc: David Gibson, ehabkost, mst
remove unused param, and rename the other to a meaningful one.
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
hw/pci/pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 168b9cc..2a6fb98 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -277,9 +277,9 @@ static void pcibus_reset(BusState *qbus)
}
}
-static void pci_host_bus_register(PCIBus *bus, DeviceState *parent)
+static void pci_host_bus_register(DeviceState *host)
{
- PCIHostState *host_bridge = PCI_HOST_BRIDGE(parent);
+ PCIHostState *host_bridge = PCI_HOST_BRIDGE(host);
QLIST_INSERT_HEAD(&pci_host_bridges, host_bridge, next);
}
@@ -343,7 +343,7 @@ static void pci_bus_init(PCIBus *bus, DeviceState *parent,
/* host bridge */
QLIST_INIT(&bus->child);
- pci_host_bus_register(bus, parent);
+ pci_host_bus_register(parent);
}
bool pci_bus_is_express(PCIBus *bus)
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH 2/2] pci core: function pci_bus_init() cleanup
2016-01-27 10:29 [Qemu-devel] [PATCH 0/2] pci core function cleanup Cao jin
2016-01-27 10:29 ` [Qemu-devel] [PATCH 1/2] pci core: function pci_host_bus_register() cleanup Cao jin
@ 2016-01-27 10:29 ` Cao jin
2016-01-28 19:02 ` Eduardo Habkost
2016-02-05 1:37 ` [Qemu-devel] [PATCH 0/2] pci core function cleanup Cao jin
2 siblings, 1 reply; 6+ messages in thread
From: Cao jin @ 2016-01-27 10:29 UTC (permalink / raw)
To: qemu-devel; +Cc: ehabkost, mst
remove unused param
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
hw/pci/pci.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 2a6fb98..b7c2681 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -330,7 +330,6 @@ const char *pci_root_bus_path(PCIDevice *dev)
}
static void pci_bus_init(PCIBus *bus, DeviceState *parent,
- const char *name,
MemoryRegion *address_space_mem,
MemoryRegion *address_space_io,
uint8_t devfn_min)
@@ -363,8 +362,7 @@ void pci_bus_new_inplace(PCIBus *bus, size_t bus_size, DeviceState *parent,
uint8_t devfn_min, const char *typename)
{
qbus_create_inplace(bus, bus_size, typename, parent, name);
- pci_bus_init(bus, parent, name, address_space_mem,
- address_space_io, devfn_min);
+ pci_bus_init(bus, parent, address_space_mem, address_space_io, devfn_min);
}
PCIBus *pci_bus_new(DeviceState *parent, const char *name,
@@ -375,8 +373,7 @@ PCIBus *pci_bus_new(DeviceState *parent, const char *name,
PCIBus *bus;
bus = PCI_BUS(qbus_create(typename, parent, name));
- pci_bus_init(bus, parent, name, address_space_mem,
- address_space_io, devfn_min);
+ pci_bus_init(bus, parent, address_space_mem, address_space_io, devfn_min);
return bus;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] pci core: function pci_host_bus_register() cleanup
2016-01-27 10:29 ` [Qemu-devel] [PATCH 1/2] pci core: function pci_host_bus_register() cleanup Cao jin
@ 2016-01-28 19:01 ` Eduardo Habkost
0 siblings, 0 replies; 6+ messages in thread
From: Eduardo Habkost @ 2016-01-28 19:01 UTC (permalink / raw)
To: Cao jin; +Cc: David Gibson, qemu-devel, mst
On Wed, Jan 27, 2016 at 06:29:01PM +0800, Cao jin wrote:
> remove unused param, and rename the other to a meaningful one.
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] pci core: function pci_bus_init() cleanup
2016-01-27 10:29 ` [Qemu-devel] [PATCH 2/2] pci core: function pci_bus_init() cleanup Cao jin
@ 2016-01-28 19:02 ` Eduardo Habkost
0 siblings, 0 replies; 6+ messages in thread
From: Eduardo Habkost @ 2016-01-28 19:02 UTC (permalink / raw)
To: Cao jin; +Cc: qemu-devel, mst
On Wed, Jan 27, 2016 at 06:29:02PM +0800, Cao jin wrote:
> remove unused param
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH 0/2] pci core function cleanup
2016-01-27 10:29 [Qemu-devel] [PATCH 0/2] pci core function cleanup Cao jin
2016-01-27 10:29 ` [Qemu-devel] [PATCH 1/2] pci core: function pci_host_bus_register() cleanup Cao jin
2016-01-27 10:29 ` [Qemu-devel] [PATCH 2/2] pci core: function pci_bus_init() cleanup Cao jin
@ 2016-02-05 1:37 ` Cao jin
2 siblings, 0 replies; 6+ messages in thread
From: Cao jin @ 2016-02-05 1:37 UTC (permalink / raw)
To: qemu-devel; +Cc: ehabkost, mst
And this one got reviewed-by too, could it be accepted?
On 01/27/2016 06:29 PM, Cao jin wrote:
> See each commit message says please.
>
> Cao jin (2):
> pci core: function pci_host_bus_register() cleanup
> pci core: function pci_bus_init() cleanup
>
> hw/pci/pci.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
--
Yours Sincerely,
Cao jin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-05 1:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-27 10:29 [Qemu-devel] [PATCH 0/2] pci core function cleanup Cao jin
2016-01-27 10:29 ` [Qemu-devel] [PATCH 1/2] pci core: function pci_host_bus_register() cleanup Cao jin
2016-01-28 19:01 ` Eduardo Habkost
2016-01-27 10:29 ` [Qemu-devel] [PATCH 2/2] pci core: function pci_bus_init() cleanup Cao jin
2016-01-28 19:02 ` Eduardo Habkost
2016-02-05 1:37 ` [Qemu-devel] [PATCH 0/2] pci core function cleanup Cao jin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).