From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
Stephen Warren <swarren@wwwdotorg.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@
Date: Mon, 8 Feb 2016 13:52:37 -0500 [thread overview]
Message-ID: <56B8E3F5.3020108@redhat.com> (raw)
In-Reply-To: <87h9hj7etf.fsf@blackfin.pond.sub.org>
On 02/08/2016 04:05 AM, Markus Armbruster wrote:
> Stephen Warren <swarren@wwwdotorg.org> writes:
>
>> Add an entry to MAINTAINERS that matches every patch, and requests the
>> user send patches to qemu-devel@nongnu.org.
>>
>> It's not 100% obvious to project newcomers that all patches should be sent
>> there; checkpatch doesn't say so, and since it mentions other lists to CC,
>> the wording "the list" from the SubmitAPatch wiki page can be taken
>> to mean only those lists, not the main list too.
>>
>> The F: entries were taken from a similar entry in the Linux kernel.
>>
>> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
>> ---
>> MAINTAINERS | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index b6ed87a26349..2d78eea5d62d 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -52,6 +52,11 @@ General Project Administration
>> ------------------------------
>> M: Peter Maydell <peter.maydell@linaro.org>
>>
>> +All patches CC here
>> +L: qemu-devel@nongnu.org
>> +F: *
>> +F: */
>> +
>> Responsible Disclosure, Reporting Security Issues
>> ------------------------------
>> W: http://wiki.qemu.org/SecurityProcess
>
> I acknowledge the problem, but your patch breaks the "No maintainers
> found, printing recent contributors" functionality.
>
> Before:
>
> $ scripts/get_maintainer.pl -f MAINTAINERS
> get_maintainer.pl: No maintainers found, printing recent contributors.
> get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.
>
> Paolo Bonzini <pbonzini@redhat.com> (commit_signer:20/74=27%)
> Kevin Wolf <kwolf@redhat.com> (commit_signer:13/74=18%)
> Stefan Hajnoczi <stefanha@redhat.com> (commit_signer:13/74=18%)
> "Michael S. Tsirkin" <mst@redhat.com> (commit_signer:10/74=14%)
> Peter Maydell <peter.maydell@linaro.org> (commit_signer:8/74=11%)
>
> After:
>
> $ scripts/get_maintainer.pl -f MAINTAINERS
> qemu-devel@nongnu.org (open list:All patches CC here)
>
Agree ... Might this also break any "unmaintained" scripts we use?
How about:
1) Update the wiki to be clearer on the submission process, and
2) Update the "no contributors found" output to also include the list
to send to?
next prev parent reply other threads:[~2016-02-08 18:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 17:22 [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@ Stephen Warren
2016-02-08 9:05 ` Markus Armbruster
2016-02-08 18:52 ` John Snow [this message]
2016-02-08 19:04 ` Stephen Warren
2016-02-08 19:15 ` Peter Maydell
2016-02-08 19:56 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B8E3F5.3020108@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).