[Qemu-devel] make distclean can fail do to a configuration check

[Qemu-devel] make distclean can fail do to a configuration check

[John Snow]

Stuff like this:

> ~/s/q/b/git> make distclean
> config-host.mak is out-of-date, running configure
>
> ERROR: sizeof(size_t) doesn't match GLIB_SIZEOF_SIZE_T.
>        You probably need to set PKG_CONFIG_LIBDIR
>        to point to the right pkg-config files for your
>        build target
>
> Makefile:35: recipe for target 'config-host.mak' failed
> make: *** [config-host.mak] Error 1`

is obnoxious. We had patches from Fam to allow some targets to bypass
the configuration check, did those die? Did we not want them for some
reason?

--js

Re: [Qemu-devel] make distclean can fail do to a configuration check

[Fam Zheng]

On Wed, 02/10 14:28, John Snow wrote:
> Stuff like this:
> 
> > ~/s/q/b/git> make distclean
> > config-host.mak is out-of-date, running configure
> >
> > ERROR: sizeof(size_t) doesn't match GLIB_SIZEOF_SIZE_T.
> >        You probably need to set PKG_CONFIG_LIBDIR
> >        to point to the right pkg-config files for your
> >        build target
> >
> > Makefile:35: recipe for target 'config-host.mak' failed
> > make: *** [config-host.mak] Error 1`
> 
> is obnoxious. We had patches from Fam to allow some targets to bypass
> the configuration check, did those die? Did we not want them for some
> reason?

What are your preceding commands? I have a clean checkout here (git clean -dfx)
and "make distclean" works for me.

Fam

Re: [Qemu-devel] make distclean can fail do to a configuration check

[John Snow]

On 02/14/2016 02:17 AM, Fam Zheng wrote:
> On Wed, 02/10 14:28, John Snow wrote:
>> Stuff like this:
>>
>>> ~/s/q/b/git> make distclean
>>> config-host.mak is out-of-date, running configure
>>>
>>> ERROR: sizeof(size_t) doesn't match GLIB_SIZEOF_SIZE_T.
>>>        You probably need to set PKG_CONFIG_LIBDIR
>>>        to point to the right pkg-config files for your
>>>        build target
>>>
>>> Makefile:35: recipe for target 'config-host.mak' failed
>>> make: *** [config-host.mak] Error 1`
>>
>> is obnoxious. We had patches from Fam to allow some targets to bypass
>> the configuration check, did those die? Did we not want them for some
>> reason?
> 
> What are your preceding commands? I have a clean checkout here (git clean -dfx)
> and "make distclean" works for me.
> 
> Fam
> 

This is due to the new glib-version-detection code that was checked in.
I had a configuration using clang, which does not appear to support the
mechanisms that are being used to tell what version of glib is being
linked against.

Practical upshot is that I can't even clean my clang configuration
because our makefile insists on re-configuring before it tries to clean.

Fam, didn't you have patches to allow e.g. cleans and "make tags" and so
on without re-incurring a full reconfiguration?

--js

Re: [Qemu-devel] make distclean can fail do to a configuration check

[Peter Maydell]

On 29 February 2016 at 16:49, John Snow <jsnow@redhat.com> wrote:
> This is due to the new glib-version-detection code that was checked in.
> I had a configuration using clang, which does not appear to support the
> mechanisms that are being used to tell what version of glib is being
> linked against.

FWIW my clang configurations work ok...

thanks
-- PMM

Re: [Qemu-devel] make distclean can fail do to a configuration check

[John Snow]

On 02/29/2016 11:54 AM, Peter Maydell wrote:
> On 29 February 2016 at 16:49, John Snow <jsnow@redhat.com> wrote:
>> This is due to the new glib-version-detection code that was checked in.
>> I had a configuration using clang, which does not appear to support the
>> mechanisms that are being used to tell what version of glib is being
>> linked against.
> 
> FWIW my clang configurations work ok...
> 
> thanks
> -- PMM
> 

jhuston@scv (master) ~/s/q/b/git> ../../configure --cxx=clang++
--cc=clang --host-cc=clang --extra-cflags=-Werror
--extra-cflags=-fsanitize=undefined
--extra-cflags=-Wno-deprecated-declarations
--extra-cflags=-fno-sanitize=float-divide-by-zero
--target-list="x86_64-softmmu"

ERROR: sizeof(size_t) doesn't match GLIB_SIZEOF_SIZE_T.
       You probably need to set PKG_CONFIG_LIBDIR
       to point to the right pkg-config files for your
       build target



Hasn't worked since 977a82ab; Paolo filed a bug against Clang -- it was
discussed here:
https://lists.nongnu.org/archive/html/qemu-devel/2016-02/msg02482.html
and filed here: https://bugzilla.redhat.com/show_bug.cgi?id=1306455


In the meantime, though, I haven't been able to use Clang on Fedora with
QEMU this month, and it reveals other interesting features of our
makefile like the one I was kvetching about here. :)

--js

Re: [Qemu-devel] make distclean can fail do to a configuration check

[Fam Zheng]

On Mon, 02/29 11:49, John Snow wrote:
> 
> 
> On 02/14/2016 02:17 AM, Fam Zheng wrote:
> Fam, didn't you have patches to allow e.g. cleans and "make tags" and so
> on without re-incurring a full reconfiguration?

Do you mean this?

    fam@fam-t430:~/work/qemu [master]$ git grep UNCHECKED_GOALS
    Makefile:UNCHECKED_GOALS := %clean TAGS cscope ctags
    Makefile:ifneq ($(filter-out $(UNCHECKED_GOALS),$(MAKECMDGOALS)),$(if $(MAKECMDGOALS),,fail))
    Makefile:ifneq ($(filter-out $(UNCHECKED_GOALS),$(MAKECMDGOALS)),$(if $(MAKECMDGOALS),,fail))

Fam

Re: [Qemu-devel] make distclean can fail do to a configuration check

[John Snow]

On 02/29/2016 08:55 PM, Fam Zheng wrote:
> On Mon, 02/29 11:49, John Snow wrote:
>>
>>
>> On 02/14/2016 02:17 AM, Fam Zheng wrote:
>> Fam, didn't you have patches to allow e.g. cleans and "make tags" and so
>> on without re-incurring a full reconfiguration?
> 
> Do you mean this?
> 
>     fam@fam-t430:~/work/qemu [master]$ git grep UNCHECKED_GOALS
>     Makefile:UNCHECKED_GOALS := %clean TAGS cscope ctags
>     Makefile:ifneq ($(filter-out $(UNCHECKED_GOALS),$(MAKECMDGOALS)),$(if $(MAKECMDGOALS),,fail))
>     Makefile:ifneq ($(filter-out $(UNCHECKED_GOALS),$(MAKECMDGOALS)),$(if $(MAKECMDGOALS),,fail))
> 
> Fam
> 

Aha, yes. I guess it's not quite working to avoid certain sanity checks,
I'll check something in. Thanks, sorry for the noise.