[PATCH] multi-process: Avoid logical AND of mutually exclusive tests

[PATCH] multi-process: Avoid logical AND of mutually exclusive tests

[Jagannathan Raman]

Fixes an if statement that performs a logical AND of mutually exclusive
tests

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
---
 hw/remote/mpqemu-link.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/remote/mpqemu-link.c b/hw/remote/mpqemu-link.c
index 9ce3152..e67a5de 100644
--- a/hw/remote/mpqemu-link.c
+++ b/hw/remote/mpqemu-link.c
@@ -218,7 +218,7 @@ uint64_t mpqemu_msg_send_and_await_reply(MPQemuMsg *msg, PCIProxyDev *pdev,
 
 bool mpqemu_msg_valid(MPQemuMsg *msg)
 {
-    if (msg->cmd >= MPQEMU_CMD_MAX && msg->cmd < 0) {
+    if (msg->cmd >= MPQEMU_CMD_MAX || msg->cmd < 0) {
         return false;
     }
 
-- 
1.8.3.1

Re: [PATCH] multi-process: Avoid logical AND of mutually exclusive tests

[Thomas Huth]

On 07/05/2021 17.53, Jagannathan Raman wrote:
> Fixes an if statement that performs a logical AND of mutually exclusive
> tests
> 
> Reported-by: Thomas Huth <thuth@redhat.com>

I just spotted the bug ticket on Launchpad :-) So whoever picks this patch 
up, please add this instead:

Buglink: https://bugs.launchpad.net/qemu/+bug/1926995
Reviewed-by: Thomas Huth <thuth@redhat.com>

> Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
> ---
>   hw/remote/mpqemu-link.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/remote/mpqemu-link.c b/hw/remote/mpqemu-link.c
> index 9ce3152..e67a5de 100644
> --- a/hw/remote/mpqemu-link.c
> +++ b/hw/remote/mpqemu-link.c
> @@ -218,7 +218,7 @@ uint64_t mpqemu_msg_send_and_await_reply(MPQemuMsg *msg, PCIProxyDev *pdev,
>   
>   bool mpqemu_msg_valid(MPQemuMsg *msg)
>   {
> -    if (msg->cmd >= MPQEMU_CMD_MAX && msg->cmd < 0) {
> +    if (msg->cmd >= MPQEMU_CMD_MAX || msg->cmd < 0) {
>           return false;
>       }

Re: [PATCH] multi-process: Avoid logical AND of mutually exclusive tests

[Laurent Vivier]

Le 08/05/2021 à 06:34, Thomas Huth a écrit :
> On 07/05/2021 17.53, Jagannathan Raman wrote:
>> Fixes an if statement that performs a logical AND of mutually exclusive
>> tests
>>
>> Reported-by: Thomas Huth <thuth@redhat.com>
> 
> I just spotted the bug ticket on Launchpad :-) So whoever picks this patch up, please add this instead:
> 
> Buglink: https://bugs.launchpad.net/qemu/+bug/1926995
> Reviewed-by: Thomas Huth <thuth@redhat.com>

Applied to my trivial-patches branch.

Thanks,
Laurent

>> Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
>> ---
>>   hw/remote/mpqemu-link.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/remote/mpqemu-link.c b/hw/remote/mpqemu-link.c
>> index 9ce3152..e67a5de 100644
>> --- a/hw/remote/mpqemu-link.c
>> +++ b/hw/remote/mpqemu-link.c
>> @@ -218,7 +218,7 @@ uint64_t mpqemu_msg_send_and_await_reply(MPQemuMsg *msg, PCIProxyDev *pdev,
>>     bool mpqemu_msg_valid(MPQemuMsg *msg)
>>   {
>> -    if (msg->cmd >= MPQEMU_CMD_MAX && msg->cmd < 0) {
>> +    if (msg->cmd >= MPQEMU_CMD_MAX || msg->cmd < 0) {
>>           return false;
>>       }
> 
> 

Re: [PATCH] multi-process: Avoid logical AND of mutually exclusive tests

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

On Fri, May 07, 2021 at 11:53:23AM -0400, Jagannathan Raman wrote:
> Fixes an if statement that performs a logical AND of mutually exclusive
> tests
> 
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
> ---
>  hw/remote/mpqemu-link.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]