qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Harry Coin <1895399@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: Re: [Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto'
Date: Mon, 14 Sep 2020 14:53:57 -0000	[thread overview]
Message-ID: <5d7c2982-4282-d521-82d7-196468b45fee@gmail.com> (raw)
In-Reply-To: 20200914100806.GC579094@stefanha-x1.localdomain

On 9/14/20 5:08 AM, Stefan Hajnoczi wrote:
> On Sat, Sep 12, 2020 at 04:53:54PM -0000, Harry Coin wrote:
>> Public bug reported:
>>
>> The usage command line for virtiofsd has:
>>
>> void fuse_cmdline_help(void)
>> {
>>     printf("    -h   --help                print help\n"
>> ...
>>            "    -o cache=<mode>            cache mode. could be one of \"auto, "
>>            "always, none\"\n"
>>            "                               default: auto\n"
>>
>>
>> But the default: auto info is missing from the man page.  I suggest this patch:
>>
>> --- docs/tools/virtiofsd.rst    2020-09-10 18:07:45.380430677 -0500
>> +++ /tmp/virtiofsd.rst  2020-09-12 11:48:10.440815204 -0500
>> @@ -106,6 +106,7 @@
>>    forbids the FUSE client from caching to achieve best coherency at the cost of
>>    performance.  ``auto`` acts similar to NFS with a 1 second metadata cache
>>    timeout.  ``always`` sets a long cache lifetime at the expense of coherency.
>> +  The default is ``auto``.
>>  
>>  Examples
>>  --------
>>
> Thanks, that looks good.
>
> Please either submit a patch
> (https://wiki.qemu.org/Contribute/SubmitAPatch) or reply with a line in
> the following format so I can send a patch on your behalf:
>
>   Signed-off-by: Full Name <your@email.com>
>
> The "Signed-off-by:" tag indicates that you are contributing under the
> Developer Certificate of Origin (https://developercertificate.org/) that
> QEMU, Linux, and other open source projects use.
>
OK.  First time for everything:

Signed-off-by: Harry G. Coin <hgcoin@gmail.com>

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895399

Title:
  Docfix: add missing virtiofsd cache default 'auto'

Status in QEMU:
  New

Bug description:
  The usage command line for virtiofsd has:

  void fuse_cmdline_help(void)
  {
      printf("    -h   --help                print help\n"
  ...
             "    -o cache=<mode>            cache mode. could be one of \"auto, "
             "always, none\"\n"
             "                               default: auto\n"

  
  But the default: auto info is missing from the man page.  I suggest this patch:

  --- docs/tools/virtiofsd.rst    2020-09-10 18:07:45.380430677 -0500
  +++ /tmp/virtiofsd.rst  2020-09-12 11:48:10.440815204 -0500
  @@ -106,6 +106,7 @@
     forbids the FUSE client from caching to achieve best coherency at the cost of
     performance.  ``auto`` acts similar to NFS with a 1 second metadata cache
     timeout.  ``always`` sets a long cache lifetime at the expense of coherency.
  +  The default is ``auto``.
   
   Examples
   --------

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1895399/+subscriptions


  parent reply	other threads:[~2020-09-14 16:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-12 16:53 [Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto' Harry Coin
2020-09-14 10:08 ` Stefan Hajnoczi
2020-09-14 10:08   ` Stefan Hajnoczi
2020-09-14 14:53   ` Harry Coin [this message]
2020-09-16 11:34     ` Stefan Hajnoczi
2020-09-16 11:34       ` Stefan Hajnoczi
2021-05-09 14:06 ` [Bug 1895399] " Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d7c2982-4282-d521-82d7-196468b45fee@gmail.com \
    --to=1895399@bugs.launchpad.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).