* [Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto'
@ 2020-09-12 16:53 Harry Coin
2020-09-14 10:08 ` Stefan Hajnoczi
2021-05-09 14:06 ` [Bug 1895399] " Thomas Huth
0 siblings, 2 replies; 7+ messages in thread
From: Harry Coin @ 2020-09-12 16:53 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
The usage command line for virtiofsd has:
void fuse_cmdline_help(void)
{
printf(" -h --help print help\n"
...
" -o cache=<mode> cache mode. could be one of \"auto, "
"always, none\"\n"
" default: auto\n"
But the default: auto info is missing from the man page. I suggest this patch:
--- docs/tools/virtiofsd.rst 2020-09-10 18:07:45.380430677 -0500
+++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500
@@ -106,6 +106,7 @@
forbids the FUSE client from caching to achieve best coherency at the cost of
performance. ``auto`` acts similar to NFS with a 1 second metadata cache
timeout. ``always`` sets a long cache lifetime at the expense of coherency.
+ The default is ``auto``.
Examples
--------
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895399
Title:
Docfix: add missing virtiofsd cache default 'auto'
Status in QEMU:
New
Bug description:
The usage command line for virtiofsd has:
void fuse_cmdline_help(void)
{
printf(" -h --help print help\n"
...
" -o cache=<mode> cache mode. could be one of \"auto, "
"always, none\"\n"
" default: auto\n"
But the default: auto info is missing from the man page. I suggest this patch:
--- docs/tools/virtiofsd.rst 2020-09-10 18:07:45.380430677 -0500
+++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500
@@ -106,6 +106,7 @@
forbids the FUSE client from caching to achieve best coherency at the cost of
performance. ``auto`` acts similar to NFS with a 1 second metadata cache
timeout. ``always`` sets a long cache lifetime at the expense of coherency.
+ The default is ``auto``.
Examples
--------
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1895399/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto'
2020-09-12 16:53 [Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto' Harry Coin
@ 2020-09-14 10:08 ` Stefan Hajnoczi
2020-09-14 10:08 ` Stefan Hajnoczi
2020-09-14 14:53 ` Harry Coin
2021-05-09 14:06 ` [Bug 1895399] " Thomas Huth
1 sibling, 2 replies; 7+ messages in thread
From: Stefan Hajnoczi @ 2020-09-14 10:08 UTC (permalink / raw)
To: Bug 1895399; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1425 bytes --]
On Sat, Sep 12, 2020 at 04:53:54PM -0000, Harry Coin wrote:
> Public bug reported:
>
> The usage command line for virtiofsd has:
>
> void fuse_cmdline_help(void)
> {
> printf(" -h --help print help\n"
> ...
> " -o cache=<mode> cache mode. could be one of \"auto, "
> "always, none\"\n"
> " default: auto\n"
>
>
> But the default: auto info is missing from the man page. I suggest this patch:
>
> --- docs/tools/virtiofsd.rst 2020-09-10 18:07:45.380430677 -0500
> +++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500
> @@ -106,6 +106,7 @@
> forbids the FUSE client from caching to achieve best coherency at the cost of
> performance. ``auto`` acts similar to NFS with a 1 second metadata cache
> timeout. ``always`` sets a long cache lifetime at the expense of coherency.
> + The default is ``auto``.
>
> Examples
> --------
>
Thanks, that looks good.
Please either submit a patch
(https://wiki.qemu.org/Contribute/SubmitAPatch) or reply with a line in
the following format so I can send a patch on your behalf:
Signed-off-by: Full Name <your@email.com>
The "Signed-off-by:" tag indicates that you are contributing under the
Developer Certificate of Origin (https://developercertificate.org/) that
QEMU, Linux, and other open source projects use.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto'
2020-09-14 10:08 ` Stefan Hajnoczi
@ 2020-09-14 10:08 ` Stefan Hajnoczi
2020-09-14 14:53 ` Harry Coin
1 sibling, 0 replies; 7+ messages in thread
From: Stefan Hajnoczi @ 2020-09-14 10:08 UTC (permalink / raw)
To: qemu-devel
On Sat, Sep 12, 2020 at 04:53:54PM -0000, Harry Coin wrote:
> Public bug reported:
>
> The usage command line for virtiofsd has:
>
> void fuse_cmdline_help(void)
> {
> printf(" -h --help print help\n"
> ...
> " -o cache=<mode> cache mode. could be one of \"auto, "
> "always, none\"\n"
> " default: auto\n"
>
>
> But the default: auto info is missing from the man page. I suggest this patch:
>
> --- docs/tools/virtiofsd.rst 2020-09-10 18:07:45.380430677 -0500
> +++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500
> @@ -106,6 +106,7 @@
> forbids the FUSE client from caching to achieve best coherency at the cost of
> performance. ``auto`` acts similar to NFS with a 1 second metadata cache
> timeout. ``always`` sets a long cache lifetime at the expense of coherency.
> + The default is ``auto``.
>
> Examples
> --------
>
Thanks, that looks good.
Please either submit a patch
(https://wiki.qemu.org/Contribute/SubmitAPatch) or reply with a line in
the following format so I can send a patch on your behalf:
Signed-off-by: Full Name <your@email.com>
The "Signed-off-by:" tag indicates that you are contributing under the
Developer Certificate of Origin (https://developercertificate.org/) that
QEMU, Linux, and other open source projects use.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895399
Title:
Docfix: add missing virtiofsd cache default 'auto'
Status in QEMU:
New
Bug description:
The usage command line for virtiofsd has:
void fuse_cmdline_help(void)
{
printf(" -h --help print help\n"
...
" -o cache=<mode> cache mode. could be one of \"auto, "
"always, none\"\n"
" default: auto\n"
But the default: auto info is missing from the man page. I suggest this patch:
--- docs/tools/virtiofsd.rst 2020-09-10 18:07:45.380430677 -0500
+++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500
@@ -106,6 +106,7 @@
forbids the FUSE client from caching to achieve best coherency at the cost of
performance. ``auto`` acts similar to NFS with a 1 second metadata cache
timeout. ``always`` sets a long cache lifetime at the expense of coherency.
+ The default is ``auto``.
Examples
--------
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1895399/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto'
2020-09-14 10:08 ` Stefan Hajnoczi
2020-09-14 10:08 ` Stefan Hajnoczi
@ 2020-09-14 14:53 ` Harry Coin
2020-09-16 11:34 ` Stefan Hajnoczi
1 sibling, 1 reply; 7+ messages in thread
From: Harry Coin @ 2020-09-14 14:53 UTC (permalink / raw)
To: qemu-devel
On 9/14/20 5:08 AM, Stefan Hajnoczi wrote:
> On Sat, Sep 12, 2020 at 04:53:54PM -0000, Harry Coin wrote:
>> Public bug reported:
>>
>> The usage command line for virtiofsd has:
>>
>> void fuse_cmdline_help(void)
>> {
>> printf(" -h --help print help\n"
>> ...
>> " -o cache=<mode> cache mode. could be one of \"auto, "
>> "always, none\"\n"
>> " default: auto\n"
>>
>>
>> But the default: auto info is missing from the man page. I suggest this patch:
>>
>> --- docs/tools/virtiofsd.rst 2020-09-10 18:07:45.380430677 -0500
>> +++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500
>> @@ -106,6 +106,7 @@
>> forbids the FUSE client from caching to achieve best coherency at the cost of
>> performance. ``auto`` acts similar to NFS with a 1 second metadata cache
>> timeout. ``always`` sets a long cache lifetime at the expense of coherency.
>> + The default is ``auto``.
>>
>> Examples
>> --------
>>
> Thanks, that looks good.
>
> Please either submit a patch
> (https://wiki.qemu.org/Contribute/SubmitAPatch) or reply with a line in
> the following format so I can send a patch on your behalf:
>
> Signed-off-by: Full Name <your@email.com>
>
> The "Signed-off-by:" tag indicates that you are contributing under the
> Developer Certificate of Origin (https://developercertificate.org/) that
> QEMU, Linux, and other open source projects use.
>
OK. First time for everything:
Signed-off-by: Harry G. Coin <hgcoin@gmail.com>
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895399
Title:
Docfix: add missing virtiofsd cache default 'auto'
Status in QEMU:
New
Bug description:
The usage command line for virtiofsd has:
void fuse_cmdline_help(void)
{
printf(" -h --help print help\n"
...
" -o cache=<mode> cache mode. could be one of \"auto, "
"always, none\"\n"
" default: auto\n"
But the default: auto info is missing from the man page. I suggest this patch:
--- docs/tools/virtiofsd.rst 2020-09-10 18:07:45.380430677 -0500
+++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500
@@ -106,6 +106,7 @@
forbids the FUSE client from caching to achieve best coherency at the cost of
performance. ``auto`` acts similar to NFS with a 1 second metadata cache
timeout. ``always`` sets a long cache lifetime at the expense of coherency.
+ The default is ``auto``.
Examples
--------
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1895399/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto'
2020-09-14 14:53 ` Harry Coin
@ 2020-09-16 11:34 ` Stefan Hajnoczi
2020-09-16 11:34 ` Stefan Hajnoczi
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Hajnoczi @ 2020-09-16 11:34 UTC (permalink / raw)
To: Bug 1895399; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
On Mon, Sep 14, 2020 at 02:53:57PM -0000, Harry Coin wrote:
> OK. First time for everything:
>
> Signed-off-by: Harry G. Coin <hgcoin@gmail.com>
Thank you. I posted your patch to the QEMU mailing list with your
authorship information:
https://patchew.org/QEMU/20200916112250.760245-1-stefanha@redhat.com/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto'
2020-09-16 11:34 ` Stefan Hajnoczi
@ 2020-09-16 11:34 ` Stefan Hajnoczi
0 siblings, 0 replies; 7+ messages in thread
From: Stefan Hajnoczi @ 2020-09-16 11:34 UTC (permalink / raw)
To: qemu-devel
On Mon, Sep 14, 2020 at 02:53:57PM -0000, Harry Coin wrote:
> OK. First time for everything:
>
> Signed-off-by: Harry G. Coin <hgcoin@gmail.com>
Thank you. I posted your patch to the QEMU mailing list with your
authorship information:
https://patchew.org/QEMU/20200916112250.760245-1-stefanha@redhat.com/
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895399
Title:
Docfix: add missing virtiofsd cache default 'auto'
Status in QEMU:
New
Bug description:
The usage command line for virtiofsd has:
void fuse_cmdline_help(void)
{
printf(" -h --help print help\n"
...
" -o cache=<mode> cache mode. could be one of \"auto, "
"always, none\"\n"
" default: auto\n"
But the default: auto info is missing from the man page. I suggest this patch:
--- docs/tools/virtiofsd.rst 2020-09-10 18:07:45.380430677 -0500
+++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500
@@ -106,6 +106,7 @@
forbids the FUSE client from caching to achieve best coherency at the cost of
performance. ``auto`` acts similar to NFS with a 1 second metadata cache
timeout. ``always`` sets a long cache lifetime at the expense of coherency.
+ The default is ``auto``.
Examples
--------
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1895399/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug 1895399] Re: Docfix: add missing virtiofsd cache default 'auto'
2020-09-12 16:53 [Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto' Harry Coin
2020-09-14 10:08 ` Stefan Hajnoczi
@ 2021-05-09 14:06 ` Thomas Huth
1 sibling, 0 replies; 7+ messages in thread
From: Thomas Huth @ 2021-05-09 14:06 UTC (permalink / raw)
To: qemu-devel
Fix had been included here:
https://gitlab.com/qemu-project/qemu/-/commit/f1303afe222759105f
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895399
Title:
Docfix: add missing virtiofsd cache default 'auto'
Status in QEMU:
Fix Released
Bug description:
The usage command line for virtiofsd has:
void fuse_cmdline_help(void)
{
printf(" -h --help print help\n"
...
" -o cache=<mode> cache mode. could be one of \"auto, "
"always, none\"\n"
" default: auto\n"
But the default: auto info is missing from the man page. I suggest this patch:
--- docs/tools/virtiofsd.rst 2020-09-10 18:07:45.380430677 -0500
+++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500
@@ -106,6 +106,7 @@
forbids the FUSE client from caching to achieve best coherency at the cost of
performance. ``auto`` acts similar to NFS with a 1 second metadata cache
timeout. ``always`` sets a long cache lifetime at the expense of coherency.
+ The default is ``auto``.
Examples
--------
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1895399/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-05-09 14:16 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-12 16:53 [Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto' Harry Coin
2020-09-14 10:08 ` Stefan Hajnoczi
2020-09-14 10:08 ` Stefan Hajnoczi
2020-09-14 14:53 ` Harry Coin
2020-09-16 11:34 ` Stefan Hajnoczi
2020-09-16 11:34 ` Stefan Hajnoczi
2021-05-09 14:06 ` [Bug 1895399] " Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).