qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>,
	Ard Biesheuvel <ardb@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiahui Cen <cenjiahui@huawei.com>,
	qemu-devel@nongnu.org
Subject: Re: aarch64 efi boot failures with qemu 6.0+
Date: Thu, 29 Jul 2021 10:08:19 +0200	[thread overview]
Message-ID: <5de773d1-48c8-1e56-493d-7c94cca78ee7@redhat.com> (raw)
In-Reply-To: <80674caa-817a-8be0-2122-fe543ec08a50@roeck-us.net>

On 7/28/21 4:03 PM, Guenter Roeck wrote:
> On 7/28/21 6:25 AM, Ard Biesheuvel wrote:
>> On Wed, 28 Jul 2021 at 15:11, Michael S. Tsirkin <mst@redhat.com> wrote:
>>>
>>> On Tue, Jul 27, 2021 at 12:36:03PM +0200, Igor Mammedov wrote:

>>> As others noted the original commit was kind of vague:
>>>
>>> 1. it said "Using _DSM #5 method to inform guest os not to ignore the
>>> PCI configuration
>>> that firmware has done at boot time could handle the differences."
>>> which is not what the spec says and not what the patch did -
>>> guest os does not ignore configuration even without this,
>>> it is just allowed to change it.
>>>
>>>
>>> 2. is says could result but does not report whether that happened in the
>>> field.
>>>
>>>
>>> Given this causes a regression I'm inclined to just revert for now.
>>> We can figure it out for the next release.
>>>
>>
>> For a revert of commit 0cf8882fd06ba0aeb1e90fa6f23fce85504d7e14, feel
>> free to include
>>
>> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>>
> 
> and:
> 
> Tested-by: Guenter Roeck <linux@roeck-us.net>
> 
>> and please also involve me if any future debates on this subject flare
>> up again.

Thanks all, this thread has been very instructive.

Michael, if describing the issue in the revert is too complex, could you
include a link to this thread in the revert description?
(Message-Id: <20210724185234.GA2265457@roeck-us.net> or
https://www.mail-archive.com/qemu-devel@nongnu.org/msg826392.html)



  reply	other threads:[~2021-07-29  8:09 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-24 18:52 Guenter Roeck
2021-07-25 22:14 ` Michael S. Tsirkin
2021-07-25 22:56   ` Guenter Roeck
2021-07-26  9:08     ` Philippe Mathieu-Daudé
2021-07-26 16:00       ` Ard Biesheuvel
2021-07-26 21:16         ` Bjorn Helgaas
2021-07-26 21:31           ` Bjorn Helgaas
2021-07-27  4:22             ` Guenter Roeck
2021-07-27 14:25               ` Bjorn Helgaas
2021-07-27  4:45         ` Michael S. Tsirkin
2021-07-27  5:12           ` Guenter Roeck
2021-07-27  7:04             ` Ard Biesheuvel
2021-07-27  9:02               ` Michael S. Tsirkin
2021-07-27  9:30               ` Michael S. Tsirkin
2021-07-27  9:50                 ` Ard Biesheuvel
2021-07-27 10:07                   ` Michael S. Tsirkin
2021-07-27 10:14                     ` Ard Biesheuvel
2022-03-18 11:48                       ` Lorenzo Pieralisi
2021-07-27 11:18                 ` Guenter Roeck
2021-07-27  9:01             ` Michael S. Tsirkin
2021-07-27 10:36               ` Igor Mammedov
2021-07-27 11:32                 ` Guenter Roeck
2021-07-28 13:11                 ` Michael S. Tsirkin
2021-07-28 13:25                   ` Ard Biesheuvel
2021-07-28 14:03                     ` Guenter Roeck
2021-07-29  8:08                       ` Philippe Mathieu-Daudé [this message]
2021-07-29 14:42                         ` Bjorn Helgaas
2021-07-29 15:59                           ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5de773d1-48c8-1e56-493d-7c94cca78ee7@redhat.com \
    --to=philmd@redhat.com \
    --cc=ardb+tianocore@kernel.org \
    --cc=ardb@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=cenjiahui@huawei.com \
    --cc=imammedo@redhat.com \
    --cc=linux@roeck-us.net \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --subject='Re: aarch64 efi boot failures with qemu 6.0+' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).