From: BALATON Zoltan <balaton@eik.bme.hu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
David Gibson <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v10 3/7] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it
Date: Wed, 17 Mar 2021 20:24:07 +0100 (CET) [thread overview]
Message-ID: <5f1ac469-9f5a-525c-2d2-8bd5a6198cc@eik.bme.hu> (raw)
In-Reply-To: <67bc4257-7b46-628c-6e46-916eff4206be@amsat.org>
[-- Attachment #1: Type: text/plain, Size: 990 bytes --]
On Wed, 17 Mar 2021, Philippe Mathieu-Daudé wrote:
> On 3/17/21 2:17 AM, BALATON Zoltan wrote:
>> To allow reusing ISA bridge emulation for vt8231_isa move the device
>> state of vt82c686b_isa emulation in an abstract via_isa class. This
>> change breaks migration back compatibility but this is not an issue
>> for Fuloong2E machine which is not versioned or migration supported.
>>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>> hw/isa/vt82c686.c | 70 ++++++++++++++++++++++------------------
>> include/hw/pci/pci_ids.h | 2 +-
>> 2 files changed, 40 insertions(+), 32 deletions(-)
>
> Now than "hw/usb: Extract VT82C686 UHCI PCI function into a new unit"
> is merged as commit 6f2bcd5fc84, this is acceptable IMHO, so:
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Still don't see what does the USB function do with this that does not have
any reference to USB but thanks. Will you send a pull requests with the
series?
Regards,
BALATON Zoltan
next prev parent reply other threads:[~2021-03-17 19:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 1:17 [PATCH v10 0/7] Pegasos2 emulation BALATON Zoltan
2021-03-17 1:17 ` [PATCH v10 7/7] hw/ppc: Add emulation of Genesi/bPlan Pegasos II BALATON Zoltan
2021-03-23 0:55 ` David Gibson
2021-03-23 13:01 ` BALATON Zoltan
2021-03-24 1:45 ` David Gibson
2021-03-24 11:21 ` BALATON Zoltan
2021-03-25 2:00 ` David Gibson
2021-03-17 1:17 ` [PATCH v10 1/7] vt82c686: QOM-ify superio related functionality BALATON Zoltan
2021-03-17 1:17 ` [PATCH v10 6/7] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller BALATON Zoltan
2021-03-23 0:40 ` David Gibson
2021-03-23 13:31 ` BALATON Zoltan
2021-03-24 1:48 ` David Gibson
2021-03-24 11:11 ` BALATON Zoltan
2021-03-25 1:56 ` David Gibson
2021-03-17 1:17 ` [PATCH v10 4/7] vt82c686: Add emulation of VT8231 south bridge BALATON Zoltan
2021-03-17 1:17 ` [PATCH v10 5/7] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM BALATON Zoltan
2021-03-17 1:17 ` [PATCH v10 3/7] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it BALATON Zoltan
2021-03-17 18:23 ` Philippe Mathieu-Daudé
2021-03-17 19:24 ` BALATON Zoltan [this message]
2021-03-17 1:17 ` [PATCH v10 2/7] vt82c686: Add VT8231_SUPERIO based on VIA_SUPERIO BALATON Zoltan
2021-03-23 0:42 ` [PATCH v10 0/7] Pegasos2 emulation David Gibson
2021-03-23 12:57 ` BALATON Zoltan
2021-03-25 1:54 ` David Gibson
2021-03-25 14:04 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f1ac469-9f5a-525c-2d2-8bd5a6198cc@eik.bme.hu \
--to=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).