From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Fredrik Noring <noring@nocrew.org>
Subject: Re: [RFC PATCH v2 17/22] target/mips/tx79: Introduce PEXE[HW] opcodes (Parallel Exchange Even)
Date: Sat, 13 Mar 2021 08:13:50 -0600 [thread overview]
Message-ID: <62040b8a-5313-cb8f-6c2e-d12dd4e64956@linaro.org> (raw)
In-Reply-To: <20210309145653.743937-18-f4bug@amsat.org>
On 3/9/21 8:56 AM, Philippe Mathieu-Daudé wrote:
> + tcg_gen_mov_i64(ax, cpu_gpr[a->rt]);
> + if (a->rd != a->rt) {
> + tcg_gen_mov_i64(cpu_gpr[a->rd], cpu_gpr[a->rt]);
> + }
tcg_gen_mov will perform this test.
> + if (a->rt == 0) {
> + tcg_gen_movi_i64(cpu_gpr[a->rd], 0);
> + tcg_gen_movi_i64(cpu_gpr_hi[a->rd], 0);
> + return true;
> + }
Why not let gen_load_gpr handle this?
It'll all fold away...
r~
next prev parent reply other threads:[~2021-03-13 14:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 14:56 [RFC PATCH v2 00/22] target/mips: Reintroduce the R5900 CPU (without testing) Philippe Mathieu-Daudé
2021-03-09 14:56 ` [RFC PATCH v2 01/22] target/mips/tx79: Move MFHI1 / MFLO1 opcodes to decodetree Philippe Mathieu-Daudé
2021-03-09 14:56 ` [RFC PATCH v2 02/22] target/mips/tx79: Move MTHI1 / MTLO1 " Philippe Mathieu-Daudé
2021-03-09 14:56 ` [RFC PATCH v2 03/22] target/mips/translate: Make gen_rdhwr() public Philippe Mathieu-Daudé
2021-03-09 14:56 ` [RFC PATCH v2 04/22] target/mips/translate: Simplify PCPYH using deposit_i64() Philippe Mathieu-Daudé
2021-03-09 14:56 ` [RFC PATCH v2 05/22] target/mips/tx79: Move PCPYH opcode to decodetree Philippe Mathieu-Daudé
2021-03-09 14:56 ` [RFC PATCH v2 06/22] target/mips/tx79: Move PCPYLD / PCPYUD opcodes " Philippe Mathieu-Daudé
2021-03-09 14:56 ` [RFC PATCH v2 07/22] target/mips: Remove 'C790 Multimedia Instructions' dead code Philippe Mathieu-Daudé
2021-03-09 14:56 ` [RFC PATCH v2 08/22] target/mips/tx79: Salvage instructions description comment Philippe Mathieu-Daudé
2021-03-09 14:56 ` [RFC PATCH v2 09/22] target/mips/tx79: Introduce PAND/POR/PXOR/PNOR opcodes (parallel logic) Philippe Mathieu-Daudé
2021-03-09 14:56 ` [RFC PATCH v2 10/22] target/mips/tx79: Introduce PSUB* opcodes (Parallel Subtract) Philippe Mathieu-Daudé
2021-03-13 14:04 ` Richard Henderson
2021-03-09 14:56 ` [RFC PATCH v2 11/22] target/mips/tx79: Introduce PEXTUW (Parallel Extend Upper from Word) Philippe Mathieu-Daudé
2021-03-13 14:04 ` Richard Henderson
2021-03-09 14:56 ` [RFC PATCH v2 12/22] target/mips/tx79: Introduce PEXTL[BHW] opcodes (Parallel Extend Lower) Philippe Mathieu-Daudé
2021-03-13 14:08 ` Richard Henderson
2021-03-09 14:56 ` [RFC PATCH v2 13/22] target/mips/tx79: Introduce PCEQ* opcodes (Parallel Compare for Equal) Philippe Mathieu-Daudé
2021-03-13 14:09 ` Richard Henderson
2021-03-09 14:56 ` [RFC PATCH v2 14/22] target/mips/tx79: Introduce PCGT* (Parallel Compare for Greater Than) Philippe Mathieu-Daudé
2021-03-13 14:10 ` Richard Henderson
2021-03-09 14:56 ` [RFC PATCH v2 15/22] target/mips/tx79: Introduce PPACW opcode (Parallel Pack to Word) Philippe Mathieu-Daudé
2021-03-09 14:56 ` [RFC PATCH v2 16/22] target/mips/tx79: Introduce PINTEH (Parallel Interleave Even Halfword) Philippe Mathieu-Daudé
2021-03-13 14:11 ` Richard Henderson
2021-03-09 14:56 ` [RFC PATCH v2 17/22] target/mips/tx79: Introduce PEXE[HW] opcodes (Parallel Exchange Even) Philippe Mathieu-Daudé
2021-03-13 14:13 ` Richard Henderson [this message]
2021-03-09 14:56 ` [RFC PATCH v2 18/22] target/mips/tx79: Introduce PROT3W opcode (Parallel Rotate 3 Words) Philippe Mathieu-Daudé
2021-03-09 14:56 ` [RFC PATCH v2 19/22] target/mips/tx79: Introduce LQ opcode (Load Quadword) Philippe Mathieu-Daudé
2021-03-09 14:56 ` [RFC PATCH v2 20/22] target/mips/tx79: Introduce SQ opcode (Store Quadword) Philippe Mathieu-Daudé
2021-03-09 14:56 ` [RFC PATCH v2 21/22] target/mips/tx79: Move RDHWR usermode kludge to trans_SQ() Philippe Mathieu-Daudé
2021-03-13 15:21 ` Richard Henderson
2021-03-09 14:56 ` [RFC PATCH v2 22/22] target/mips: Reintroduce the R5900 CPU Philippe Mathieu-Daudé
2021-03-12 0:01 ` [RFC PATCH v2 00/22] target/mips: Reintroduce the R5900 CPU (without testing) Philippe Mathieu-Daudé
2021-07-11 20:27 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62040b8a-5313-cb8f-6c2e-d12dd4e64956@linaro.org \
--to=richard.henderson@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=noring@nocrew.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).