From: Thomas Huth <thuth@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/4] tests/qemu-iotests/group: Remove some more tests from the "auto" group
Date: Tue, 16 Jul 2019 17:31:20 +0200 [thread overview]
Message-ID: <62ec1243-3bb9-c18d-0ff6-4c4ad193620c@redhat.com> (raw)
In-Reply-To: <1832e90b-0fd2-19ac-f90e-572147e51f53@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
On 16/07/2019 17.26, Max Reitz wrote:
> On 16.07.19 14:28, Thomas Huth wrote:
>> Remove some more tests from the "auto" group that either have issues
>> in certain environments (like macOS or FreeBSD, or on certain file systems
>> like ZFS or tmpfs), do not work with the qcow2 format, or that are simply
>> taking too much time.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> tests/qemu-iotests/group | 114 ++++++++++++++++++++-------------------
>> 1 file changed, 58 insertions(+), 56 deletions(-)
>
> I just looked through the list to see whether any of the test seems like
> we’d want to keep it even though it is a bit slow. Mostly I was looking
> for tests that cover complex cases.
>
> 255 is the only one that seemed to fit that bill to me. So why do you
> remove it? Is it because it takes two seconds?
No, I removed it because it was failing on macOS:
https://cirrus-ci.com/task/4860239294234624
("OSError: AF_UNIX path too long" is the error, if I got that right)
Thomas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2019-07-16 15:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 12:28 [Qemu-devel] [PATCH v2 0/4] Enable iotests during "make check" Thomas Huth
2019-07-16 12:28 ` [Qemu-devel] [PATCH v2 1/4] tests/qemu-iotests/check: Allow tests without groups Thomas Huth
2019-07-16 15:27 ` Max Reitz
2019-07-16 15:52 ` Alex Bennée
2019-07-16 12:28 ` [Qemu-devel] [PATCH v2 2/4] tests/qemu-iotests/group: Remove some more tests from the "auto" group Thomas Huth
2019-07-16 15:26 ` Max Reitz
2019-07-16 15:31 ` Thomas Huth [this message]
2019-07-16 15:44 ` Max Reitz
2019-07-16 15:45 ` Max Reitz
2019-07-16 15:56 ` Eric Blake
2019-07-16 15:58 ` Max Reitz
2019-07-16 16:09 ` Eric Blake
2019-07-16 16:12 ` Max Reitz
2019-07-18 7:42 ` Thomas Huth
2019-07-16 12:28 ` [Qemu-devel] [PATCH v2 3/4] tests: Run the iotests during "make check" again Thomas Huth
2019-07-16 15:37 ` Max Reitz
2019-07-17 9:41 ` Thomas Huth
2019-07-16 12:28 ` [Qemu-devel] [PATCH v2 4/4] gitlab-ci: Remove qcow2 tests that are handled by "make check" already Thomas Huth
2019-07-16 15:41 ` Max Reitz
2019-07-16 15:51 ` Thomas Huth
2019-07-16 15:57 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62ec1243-3bb9-c18d-0ff6-4c4ad193620c@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).