From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/4] tests/qemu-iotests/group: Remove some more tests from the "auto" group
Date: Tue, 16 Jul 2019 18:12:42 +0200 [thread overview]
Message-ID: <94a85c94-5758-0e09-1a34-127cb26fe115@redhat.com> (raw)
In-Reply-To: <f2cde3ed-f776-5c1e-cc57-a9cff7190502@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 2048 bytes --]
On 16.07.19 18:09, Eric Blake wrote:
> On 7/16/19 10:58 AM, Max Reitz wrote:
>
>>>> Ah, OK. So, uh, we effectively can’t run any Python tests on macOS?
>>>
>>> Not when our CI is set up to use super-long file names:
>>>
>>> + File
>>> "/private/var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/cirrus-ci-build/tests/qemu-iotests/../../python/qemu/machine.py",
>>> line 294, in launch
>>
>> That isn’t really long.
>
> The MacOS limit is 104 (or 103 if you insist on using the trailing NUL
> yourself), compared to Linux at 108 (107). And:
>
> $ printf
> "/private/var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/cirrus-ci-build/tests/qemu-iotests/scratch/name"
> | wc -c
> 104
>
> shows that we are right on the verge of overflowing the space allotted,
> with any socket name worth using when the socket lives inside
> qemu-iotests/scratch.
>
>>
>>> Is there any way to create our sockets somewhere under /tmp instead of
>>> inside tests/qemu-iotests, so that we have a shorter filename for
>>> sockets no matter how deep in the file hierarchy the tests themselves live?
>>>
>>> Also, at one point, we tossed around the idea of
>>> s/qemu-iotests/iotests/, to shave off 5 characters that don't really add
>>> anything.
>>
>> I’d personally rather just skip the iotests if we detect such a silly
>> OS, but maybe that’s just me.
>
> It's a rather unfortunate limit, but it's not all that silly (the limit
> is based on the fact that struct sockaddr has to fit inside a nice
> power-of-2 structure somewhere in the kernel, and enough else is used
> that you really are left with just 104/108 bytes, or even 92 bytes if
> you use HP-UX 11). POSIX does not place a minimum length on sun_path,
> but I know of no system that does not allow at least 92 bytes, if you
> are aiming for a portably-small name.
It does come to me as a surprise that the sockaddr is a path instead of,
say, an inode number.
But shaving off the “qemu-” seems like the wrong approach to me still.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-16 16:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 12:28 [Qemu-devel] [PATCH v2 0/4] Enable iotests during "make check" Thomas Huth
2019-07-16 12:28 ` [Qemu-devel] [PATCH v2 1/4] tests/qemu-iotests/check: Allow tests without groups Thomas Huth
2019-07-16 15:27 ` Max Reitz
2019-07-16 15:52 ` Alex Bennée
2019-07-16 12:28 ` [Qemu-devel] [PATCH v2 2/4] tests/qemu-iotests/group: Remove some more tests from the "auto" group Thomas Huth
2019-07-16 15:26 ` Max Reitz
2019-07-16 15:31 ` Thomas Huth
2019-07-16 15:44 ` Max Reitz
2019-07-16 15:45 ` Max Reitz
2019-07-16 15:56 ` Eric Blake
2019-07-16 15:58 ` Max Reitz
2019-07-16 16:09 ` Eric Blake
2019-07-16 16:12 ` Max Reitz [this message]
2019-07-18 7:42 ` Thomas Huth
2019-07-16 12:28 ` [Qemu-devel] [PATCH v2 3/4] tests: Run the iotests during "make check" again Thomas Huth
2019-07-16 15:37 ` Max Reitz
2019-07-17 9:41 ` Thomas Huth
2019-07-16 12:28 ` [Qemu-devel] [PATCH v2 4/4] gitlab-ci: Remove qcow2 tests that are handled by "make check" already Thomas Huth
2019-07-16 15:41 ` Max Reitz
2019-07-16 15:51 ` Thomas Huth
2019-07-16 15:57 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a85c94-5758-0e09-1a34-127cb26fe115@redhat.com \
--to=mreitz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).