* [Qemu-devel] [PATCH v2] Update the avx2 configure test to be compatible with clang
@ 2019-08-09 4:29 Rebecca Cran
2019-08-09 5:14 ` no-reply
2019-08-09 5:44 ` Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Rebecca Cran @ 2019-08-09 4:29 UTC (permalink / raw)
To: qemu-devel, Michael Tokarev, Laurent Vivier, qemu-trivial; +Cc: Rebecca Cran
clang doesn't support the GCC pragma to enable AVX2, but instead
requires the command line option -mavx2. Since GCC also supports that,
remove the pragma lines and add the -mavx2 option when building the
test. If AVX2 is supported, update QEMU_CFLAGS to include -mavx2 .
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
configure | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index 714e7fb6a1..227fce6561 100755
--- a/configure
+++ b/configure
@@ -5392,8 +5392,6 @@ fi
if test "$cpuid_h" = "yes" && test "$avx2_opt" != "no"; then
cat > $TMPC << EOF
-#pragma GCC push_options
-#pragma GCC target("avx2")
#include <cpuid.h>
#include <immintrin.h>
static int bar(void *a) {
@@ -5402,7 +5400,8 @@ static int bar(void *a) {
}
int main(int argc, char *argv[]) { return bar(argv[0]); }
EOF
- if compile_object "" ; then
+ if compile_object "-mavx2" ; then
+ QEMU_CFLAGS="-mavx2 $QEMU_CFLAGS"
avx2_opt="yes"
else
avx2_opt="no"
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] Update the avx2 configure test to be compatible with clang
2019-08-09 4:29 [Qemu-devel] [PATCH v2] Update the avx2 configure test to be compatible with clang Rebecca Cran
@ 2019-08-09 5:14 ` no-reply
2019-08-09 5:44 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: no-reply @ 2019-08-09 5:14 UTC (permalink / raw)
To: rebecca; +Cc: qemu-trivial, rebecca, mjt, qemu-devel, laurent
Patchew URL: https://patchew.org/QEMU/20190809042909.74988-1-rebecca@bsdio.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===
CC util/oslib-posix.o
CC util/qemu-openpty.o
CC util/qemu-thread-posix.o
/tmp/qemu-test/src/util/bufferiszero.c:71:13: error: unknown pragma ignored [-Werror,-Wunknown-pragmas]
#pragma GCC push_options
^
/tmp/qemu-test/src/util/bufferiszero.c:72:13: error: unknown pragma ignored [-Werror,-Wunknown-pragmas]
#pragma GCC target("sse2")
^
/tmp/qemu-test/src/util/bufferiszero.c:108:13: error: unknown pragma ignored [-Werror,-Wunknown-pragmas]
#pragma GCC pop_options
^
/tmp/qemu-test/src/util/bufferiszero.c:116:13: error: unknown pragma ignored [-Werror,-Wunknown-pragmas]
#pragma GCC push_options
^
/tmp/qemu-test/src/util/bufferiszero.c:117:13: error: unknown pragma ignored [-Werror,-Wunknown-pragmas]
#pragma GCC target("sse4")
^
/tmp/qemu-test/src/util/bufferiszero.c:148:13: error: unknown pragma ignored [-Werror,-Wunknown-pragmas]
#pragma GCC pop_options
^
/tmp/qemu-test/src/util/bufferiszero.c:149:13: error: unknown pragma ignored [-Werror,-Wunknown-pragmas]
#pragma GCC push_options
^
/tmp/qemu-test/src/util/bufferiszero.c:150:13: error: unknown pragma ignored [-Werror,-Wunknown-pragmas]
#pragma GCC target("avx2")
^
/tmp/qemu-test/src/util/bufferiszero.c:187:13: error: unknown pragma ignored [-Werror,-Wunknown-pragmas]
#pragma GCC pop_options
^
9 errors generated.
The full log is available at
http://patchew.org/logs/20190809042909.74988-1-rebecca@bsdio.com/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] Update the avx2 configure test to be compatible with clang
2019-08-09 4:29 [Qemu-devel] [PATCH v2] Update the avx2 configure test to be compatible with clang Rebecca Cran
2019-08-09 5:14 ` no-reply
@ 2019-08-09 5:44 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2019-08-09 5:44 UTC (permalink / raw)
To: Rebecca Cran, qemu-devel, Michael Tokarev, Laurent Vivier, qemu-trivial
On 8/8/19 9:29 PM, Rebecca Cran wrote:
> clang doesn't support the GCC pragma to enable AVX2, but instead
> requires the command line option -mavx2. Since GCC also supports that,
> remove the pragma lines and add the -mavx2 option when building the
> test. If AVX2 is supported, update QEMU_CFLAGS to include -mavx2 .
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> configure | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
No, this has the same problem as v1.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-09 5:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09 4:29 [Qemu-devel] [PATCH v2] Update the avx2 configure test to be compatible with clang Rebecca Cran
2019-08-09 5:14 ` no-reply
2019-08-09 5:44 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).