QEMU-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Jason Wang <jasowang@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: hw/net/rocker: Dubious code in tx_consume()
Date: Sat, 15 Feb 2020 14:15:22 +0100
Message-ID: <63e927fd-a462-a871-fcd7-c54dac07173e@redhat.com> (raw)

Hi Jiri,

I am trying to understand this code Scott Feldman added in commit 
dc488f88806:

  157 static int tx_consume(Rocker *r, DescInfo *info)
  158 {
  ...
  212     if (tlvs[ROCKER_TLV_TX_TSO_MSS]) {
  213         tx_tso_mss = rocker_tlv_get_le16(tlvs[ROCKER_TLV_TX_TSO_MSS]);
  214     }
  ...
  252     if (iovcnt) {
  253         /* XXX perform Tx offloads */
  254         /* XXX   silence compiler for now */
  255         tx_l3_csum_off += tx_tso_mss = tx_tso_hdr_len = 0;
  256     }

Nobody complained TSO_MSS is not implemented during almost 5 years.
Can we remove this code?

Thanks,

Phil.



             reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-15 13:15 Philippe Mathieu-Daudé [this message]
2020-02-16  6:59 ` Jiri Pirko

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63e927fd-a462-a871-fcd7-c54dac07173e@redhat.com \
    --to=philmd@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

QEMU-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
	git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
		qemu-devel@nongnu.org
	public-inbox-index qemu-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git