From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Jason Wang <jasowang@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: hw/net/rocker: Dubious code in tx_consume()
Date: Sat, 15 Feb 2020 14:15:22 +0100 [thread overview]
Message-ID: <63e927fd-a462-a871-fcd7-c54dac07173e@redhat.com> (raw)
Hi Jiri,
I am trying to understand this code Scott Feldman added in commit
dc488f88806:
157 static int tx_consume(Rocker *r, DescInfo *info)
158 {
...
212 if (tlvs[ROCKER_TLV_TX_TSO_MSS]) {
213 tx_tso_mss = rocker_tlv_get_le16(tlvs[ROCKER_TLV_TX_TSO_MSS]);
214 }
...
252 if (iovcnt) {
253 /* XXX perform Tx offloads */
254 /* XXX silence compiler for now */
255 tx_l3_csum_off += tx_tso_mss = tx_tso_hdr_len = 0;
256 }
Nobody complained TSO_MSS is not implemented during almost 5 years.
Can we remove this code?
Thanks,
Phil.
next reply other threads:[~2020-02-15 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 13:15 Philippe Mathieu-Daudé [this message]
2020-02-16 6:59 ` hw/net/rocker: Dubious code in tx_consume() Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63e927fd-a462-a871-fcd7-c54dac07173e@redhat.com \
--to=philmd@redhat.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).