From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-trivial@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
zhang.zhanghailiang@huawei.com,
"Michael S . Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Gan Qixin <ganqixin@huawei.com>,
kuhn.chenqun@huawei.com
Subject: Re: [PATCH v2 05/12] mc146818rtc: put it into the 'misc' category
Date: Wed, 24 Mar 2021 18:23:28 +0100 [thread overview]
Message-ID: <65fe4d98-7f79-191e-34c5-c3e5021d2f36@amsat.org> (raw)
In-Reply-To: <8c45ab34-2534-d5ad-ca0b-43b49a681e55@redhat.com>
On 12/21/20 12:53 PM, Thomas Huth wrote:
> On 30/11/2020 09.36, Gan Qixin wrote:
>> The category of the mc146818rtc device is not set, put it into the 'misc'
>> category.
>>
>> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
>> ---
>> Cc: Michael S. Tsirkin <mst@redhat.com>
>> ---
>> hw/rtc/mc146818rtc.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c
>> index 7a38540cb9..39edca0996 100644
>> --- a/hw/rtc/mc146818rtc.c
>> +++ b/hw/rtc/mc146818rtc.c
>> @@ -1039,6 +1039,7 @@ static void rtc_class_initfn(ObjectClass *klass, void *data)
>> dc->vmsd = &vmstate_rtc;
>> isa->build_aml = rtc_build_aml;
>> device_class_set_props(dc, mc146818rtc_properties);
>> + set_bit(DEVICE_CATEGORY_MISC, dc->categories);
>> }
>
> I wonder whether this device should be user_creatable at all (e.g. it uses a
> hard-coded IO port)... Anyway setting the category certainly does not hurt,
> thus:
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Can this go via qemu-trivial?
next prev parent reply other threads:[~2021-03-24 17:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 8:36 [PATCH v2 00/12] Categorize some uncategorized devices Gan Qixin
2020-11-30 8:36 ` [PATCH v2 01/12] pc-dimm: put it into the 'storage' category Gan Qixin
2020-11-30 10:18 ` Pankaj Gupta
2020-12-03 6:53 ` ganqixin
2020-12-04 7:13 ` Pankaj Gupta
2020-12-07 9:09 ` ganqixin
2020-11-30 8:36 ` [PATCH v2 02/12] virtio-pmem: " Gan Qixin
2021-02-13 23:08 ` Laurent Vivier
2020-11-30 8:36 ` [PATCH v2 03/12] vmmouse: put it into the 'input' category Gan Qixin
2020-12-21 11:49 ` Thomas Huth
2021-02-13 23:08 ` Laurent Vivier
2020-11-30 8:36 ` [PATCH v2 04/12] nvdimm: put it into the 'storage' category Gan Qixin
2020-11-30 10:16 ` Pankaj Gupta
2020-12-21 11:50 ` Thomas Huth
2021-02-13 23:09 ` Laurent Vivier
2020-11-30 8:36 ` [PATCH v2 05/12] mc146818rtc: put it into the 'misc' category Gan Qixin
2020-12-21 11:53 ` Thomas Huth
2021-03-24 17:23 ` Philippe Mathieu-Daudé [this message]
2021-04-30 16:40 ` Laurent Vivier
2020-11-30 8:36 ` [PATCH v2 06/12] ipmi: put some ipmi devices into the correct category Gan Qixin
2020-11-30 8:36 ` [PATCH v2 07/12] tpm: put some tpm " Gan Qixin
2020-11-30 21:02 ` Stefan Berger
2021-02-13 23:11 ` Laurent Vivier
2020-11-30 8:36 ` [PATCH v2 08/12] AMDVI-PCI: put it into the 'misc' category Gan Qixin
2020-11-30 8:36 ` [PATCH v2 09/12] u2f-passthru: " Gan Qixin
2020-11-30 9:18 ` Gerd Hoffmann
2021-02-13 23:12 ` Laurent Vivier
2020-11-30 8:36 ` [PATCH v2 10/12] tosa-ssp: " Gan Qixin
2020-11-30 8:36 ` [PATCH v2 11/12] spitz: put some Spitz-family devices into the correct category Gan Qixin
2021-02-15 11:53 ` Philippe Mathieu-Daudé
2020-11-30 8:36 ` [PATCH v2 12/12] SPI flash devices: put them into the 'storage' category Gan Qixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65fe4d98-7f79-191e-34c5-c3e5021d2f36@amsat.org \
--to=f4bug@amsat.org \
--cc=ganqixin@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).