qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
To: Gan Qixin <ganqixin@huawei.com>
Cc: thuth@redhat.com, Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
	qemu-trivial@nongnu.org, Qemu Developers <qemu-devel@nongnu.org>,
	kuhn.chenqun@huawei.com, zhang.zhanghailiang@huawei.com
Subject: Re: [PATCH v2 04/12] nvdimm: put it into the 'storage' category
Date: Mon, 30 Nov 2020 11:16:30 +0100	[thread overview]
Message-ID: <CAM9Jb+ivQCcO9LZUpPnfUXG180+G2NXUNZyCTVQXgsHscChazQ@mail.gmail.com> (raw)
In-Reply-To: <20201130083630.2520597-5-ganqixin@huawei.com>

> The category of the nvdimm device is not set, put it into the 'storage'
> category.
>
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
> Cc: Xiao Guangrong <xiaoguangrong.eric@gmail.com>
> ---
>  hw/mem/nvdimm.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
> index e1574bc07c..e30695b2ce 100644
> --- a/hw/mem/nvdimm.c
> +++ b/hw/mem/nvdimm.c
> @@ -236,6 +236,7 @@ static void nvdimm_class_init(ObjectClass *oc, void *data)
>
>      nvc->read_label_data = nvdimm_read_label_data;
>      nvc->write_label_data = nvdimm_write_label_data;
> +    set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>  }
>
>  static TypeInfo nvdimm_info = {

Reviewed-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>


  reply	other threads:[~2020-11-30 10:17 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30  8:36 [PATCH v2 00/12] Categorize some uncategorized devices Gan Qixin
2020-11-30  8:36 ` [PATCH v2 01/12] pc-dimm: put it into the 'storage' category Gan Qixin
2020-11-30 10:18   ` Pankaj Gupta
2020-12-03  6:53     ` ganqixin
2020-12-04  7:13       ` Pankaj Gupta
2020-12-07  9:09         ` ganqixin
2020-11-30  8:36 ` [PATCH v2 02/12] virtio-pmem: " Gan Qixin
2021-02-13 23:08   ` Laurent Vivier
2020-11-30  8:36 ` [PATCH v2 03/12] vmmouse: put it into the 'input' category Gan Qixin
2020-12-21 11:49   ` Thomas Huth
2021-02-13 23:08   ` Laurent Vivier
2020-11-30  8:36 ` [PATCH v2 04/12] nvdimm: put it into the 'storage' category Gan Qixin
2020-11-30 10:16   ` Pankaj Gupta [this message]
2020-12-21 11:50   ` Thomas Huth
2021-02-13 23:09   ` Laurent Vivier
2020-11-30  8:36 ` [PATCH v2 05/12] mc146818rtc: put it into the 'misc' category Gan Qixin
2020-12-21 11:53   ` Thomas Huth
2021-03-24 17:23     ` Philippe Mathieu-Daudé
2021-04-30 16:40       ` Laurent Vivier
2020-11-30  8:36 ` [PATCH v2 06/12] ipmi: put some ipmi devices into the correct category Gan Qixin
2020-11-30  8:36 ` [PATCH v2 07/12] tpm: put some tpm " Gan Qixin
2020-11-30 21:02   ` Stefan Berger
2021-02-13 23:11   ` Laurent Vivier
2020-11-30  8:36 ` [PATCH v2 08/12] AMDVI-PCI: put it into the 'misc' category Gan Qixin
2020-11-30  8:36 ` [PATCH v2 09/12] u2f-passthru: " Gan Qixin
2020-11-30  9:18   ` Gerd Hoffmann
2021-02-13 23:12   ` Laurent Vivier
2020-11-30  8:36 ` [PATCH v2 10/12] tosa-ssp: " Gan Qixin
2020-11-30  8:36 ` [PATCH v2 11/12] spitz: put some Spitz-family devices into the correct category Gan Qixin
2021-02-15 11:53   ` Philippe Mathieu-Daudé
2020-11-30  8:36 ` [PATCH v2 12/12] SPI flash devices: put them into the 'storage' category Gan Qixin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM9Jb+ivQCcO9LZUpPnfUXG180+G2NXUNZyCTVQXgsHscChazQ@mail.gmail.com \
    --to=pankaj.gupta.linux@gmail.com \
    --cc=ganqixin@huawei.com \
    --cc=kuhn.chenqun@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=xiaoguangrong.eric@gmail.com \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).