* [Qemu-devel] [PATCH] blockdev: enable non-root nodes for transaction drive-backup source
@ 2019-06-18 14:08 Vladimir Sementsov-Ogievskiy
2019-06-18 14:24 ` John Snow
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2019-06-18 14:08 UTC (permalink / raw)
To: qemu-devel, qemu-block; +Cc: kwolf, vsementsov, jsnow, armbru, mreitz
We forget to enable it for transaction .prepare, while it is already
enabled in do_drive_backup since commit a2d665c1bc362
"blockdev: loosen restrictions on drive-backup source node"
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
Hmm, I've to add John by hand, get_maintainer.pl don't report him.
Shouldn't we include blockdev.c into Block Jobs in MAINTAINERS?
It definitely related to block jobs.
blockdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index b5c0fd3c49..4ae81d687a 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1775,7 +1775,7 @@ static void drive_backup_prepare(BlkActionState *common, Error **errp)
assert(common->action->type == TRANSACTION_ACTION_KIND_DRIVE_BACKUP);
backup = common->action->u.drive_backup.data;
- bs = qmp_get_root_bs(backup->device, errp);
+ bs = bdrv_lookup_bs(backup->device, backup->device, errp);
if (!bs) {
return;
}
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] blockdev: enable non-root nodes for transaction drive-backup source
2019-06-18 14:08 [Qemu-devel] [PATCH] blockdev: enable non-root nodes for transaction drive-backup source Vladimir Sementsov-Ogievskiy
@ 2019-06-18 14:24 ` John Snow
2019-06-18 14:32 ` Vladimir Sementsov-Ogievskiy
2019-06-18 14:57 ` John Snow
2019-06-19 19:12 ` Max Reitz
2 siblings, 1 reply; 5+ messages in thread
From: John Snow @ 2019-06-18 14:24 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy, qemu-devel, qemu-block
Cc: kwolf, armbru, mreitz
On 6/18/19 10:08 AM, Vladimir Sementsov-Ogievskiy wrote:
> We forget to enable it for transaction .prepare, while it is already
> enabled in do_drive_backup since commit a2d665c1bc362
> "blockdev: loosen restrictions on drive-backup source node"
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>
> Hmm, I've to add John by hand, get_maintainer.pl don't report him.
> Shouldn't we include blockdev.c into Block Jobs in MAINTAINERS?
> It definitely related to block jobs.
>
> blockdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index b5c0fd3c49..4ae81d687a 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -1775,7 +1775,7 @@ static void drive_backup_prepare(BlkActionState *common, Error **errp)
> assert(common->action->type == TRANSACTION_ACTION_KIND_DRIVE_BACKUP);
> backup = common->action->u.drive_backup.data;
>
> - bs = qmp_get_root_bs(backup->device, errp);
> + bs = bdrv_lookup_bs(backup->device, backup->device, errp);
> if (!bs) {
> return;
> }
>
Ah, tch. I should extend 256 too in this case. Would you like me to take
care of that?
Jokingly: "drive-backup is a legacy interface, please don't use it!"
--js
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] blockdev: enable non-root nodes for transaction drive-backup source
2019-06-18 14:24 ` John Snow
@ 2019-06-18 14:32 ` Vladimir Sementsov-Ogievskiy
0 siblings, 0 replies; 5+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2019-06-18 14:32 UTC (permalink / raw)
To: John Snow, qemu-devel, qemu-block; +Cc: kwolf, armbru, mreitz
18.06.2019 17:24, John Snow wrote:
>
>
> On 6/18/19 10:08 AM, Vladimir Sementsov-Ogievskiy wrote:
>> We forget to enable it for transaction .prepare, while it is already
>> enabled in do_drive_backup since commit a2d665c1bc362
>> "blockdev: loosen restrictions on drive-backup source node"
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>>
>> Hmm, I've to add John by hand, get_maintainer.pl don't report him.
>> Shouldn't we include blockdev.c into Block Jobs in MAINTAINERS?
>> It definitely related to block jobs.
>>
>> blockdev.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/blockdev.c b/blockdev.c
>> index b5c0fd3c49..4ae81d687a 100644
>> --- a/blockdev.c
>> +++ b/blockdev.c
>> @@ -1775,7 +1775,7 @@ static void drive_backup_prepare(BlkActionState *common, Error **errp)
>> assert(common->action->type == TRANSACTION_ACTION_KIND_DRIVE_BACKUP);
>> backup = common->action->u.drive_backup.data;
>>
>> - bs = qmp_get_root_bs(backup->device, errp);
>> + bs = bdrv_lookup_bs(backup->device, backup->device, errp);
>> if (!bs) {
>> return;
>> }
>>
>
> Ah, tch. I should extend 256 too in this case. Would you like me to take
> care of that?
It will be great
>
> Jokingly: "drive-backup is a legacy interface, please don't use it!"
>
> --js
>
--
Best regards,
Vladimir
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] blockdev: enable non-root nodes for transaction drive-backup source
2019-06-18 14:08 [Qemu-devel] [PATCH] blockdev: enable non-root nodes for transaction drive-backup source Vladimir Sementsov-Ogievskiy
2019-06-18 14:24 ` John Snow
@ 2019-06-18 14:57 ` John Snow
2019-06-19 19:12 ` Max Reitz
2 siblings, 0 replies; 5+ messages in thread
From: John Snow @ 2019-06-18 14:57 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy, qemu-devel, qemu-block
Cc: kwolf, armbru, mreitz
On 6/18/19 10:08 AM, Vladimir Sementsov-Ogievskiy wrote:
> We forget to enable it for transaction .prepare, while it is already
> enabled in do_drive_backup since commit a2d665c1bc362
> "blockdev: loosen restrictions on drive-backup source node"
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>
> Hmm, I've to add John by hand, get_maintainer.pl don't report him.
> Shouldn't we include blockdev.c into Block Jobs in MAINTAINERS?
> It definitely related to block jobs.
>
> blockdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index b5c0fd3c49..4ae81d687a 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -1775,7 +1775,7 @@ static void drive_backup_prepare(BlkActionState *common, Error **errp)
> assert(common->action->type == TRANSACTION_ACTION_KIND_DRIVE_BACKUP);
> backup = common->action->u.drive_backup.data;
>
> - bs = qmp_get_root_bs(backup->device, errp);
> + bs = bdrv_lookup_bs(backup->device, backup->device, errp);
> if (!bs) {
> return;
> }
>
I'm half asleep, sorry, this isn't related to the patch that
necessitated 256. This is fine as-is.
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] blockdev: enable non-root nodes for transaction drive-backup source
2019-06-18 14:08 [Qemu-devel] [PATCH] blockdev: enable non-root nodes for transaction drive-backup source Vladimir Sementsov-Ogievskiy
2019-06-18 14:24 ` John Snow
2019-06-18 14:57 ` John Snow
@ 2019-06-19 19:12 ` Max Reitz
2 siblings, 0 replies; 5+ messages in thread
From: Max Reitz @ 2019-06-19 19:12 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy, qemu-devel, qemu-block; +Cc: kwolf, jsnow, armbru
[-- Attachment #1.1: Type: text/plain, Size: 703 bytes --]
On 18.06.19 16:08, Vladimir Sementsov-Ogievskiy wrote:
> We forget to enable it for transaction .prepare, while it is already
> enabled in do_drive_backup since commit a2d665c1bc362
> "blockdev: loosen restrictions on drive-backup source node"
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>
> Hmm, I've to add John by hand, get_maintainer.pl don't report him.
> Shouldn't we include blockdev.c into Block Jobs in MAINTAINERS?
> It definitely related to block jobs.
>
> blockdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-19 19:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-18 14:08 [Qemu-devel] [PATCH] blockdev: enable non-root nodes for transaction drive-backup source Vladimir Sementsov-Ogievskiy
2019-06-18 14:24 ` John Snow
2019-06-18 14:32 ` Vladimir Sementsov-Ogievskiy
2019-06-18 14:57 ` John Snow
2019-06-19 19:12 ` Max Reitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).