From: Christian Borntraeger <borntraeger@de.ibm.com>
To: David Hildenbrand <david@redhat.com>, Cornelia Huck <cohuck@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
qemu-s390x@nongnu.org, Claudio Imbrenda <imbrenda@linux.ibm.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH RFC 2/5] s390x: implement diag260
Date: Mon, 13 Jul 2020 13:54:41 +0200 [thread overview]
Message-ID: <68e4c043-2d4a-f538-1f86-a7171098b0db@de.ibm.com> (raw)
In-Reply-To: <520dafce-917f-9a88-a3ee-c7d614ac113f@redhat.com>
On 10.07.20 10:32, David Hildenbrand wrote:
>>> --- a/target/s390x/misc_helper.c
>>> +++ b/target/s390x/misc_helper.c
>>> @@ -116,6 +116,12 @@ void HELPER(diag)(CPUS390XState *env, uint32_t r1, uint32_t r3, uint32_t num)
>>> uint64_t r;
>>>
>>> switch (num) {
>>> + case 0x260:
>>> + qemu_mutex_lock_iothread();
>>> + handle_diag_260(env, r1, r3, GETPC());
>>> + qemu_mutex_unlock_iothread();
>>> + r = 0;
>>> + break;
>>> case 0x500:
>>> /* KVM hypercall */
>>> qemu_mutex_lock_iothread();
>>
>> Looking at the doc referenced above, it seems that we treat every diag
>> call as privileged under tcg; but it seems that 0x44 isn't? (Unrelated
>> to your patch; maybe I'm misreading.)
>
> That's also a BUG in kvm then?
>
> int kvm_s390_handle_diag(struct kvm_vcpu *vcpu)
> {
> ...
> if (vcpu->arch.sie_block->gpsw.mask & PSW_MASK_PSTATE)
> return kvm_s390_inject_program_int(vcpu, PGM_PRIVILEGED_OP);
> ...
> }
diag 44 gives a PRIVOP on LPAR, so I think this is fine.
next prev parent reply other threads:[~2020-07-13 11:55 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 18:51 [PATCH RFC 0/5] s390x: initial support for virtio-mem David Hildenbrand
2020-07-08 18:51 ` [PATCH RFC 1/5] s390x: move setting of maximum ram size to machine init David Hildenbrand
2020-07-08 18:51 ` [PATCH RFC 2/5] s390x: implement diag260 David Hildenbrand
2020-07-09 10:37 ` Cornelia Huck
2020-07-09 17:54 ` David Hildenbrand
2020-07-10 8:32 ` David Hildenbrand
2020-07-10 8:41 ` David Hildenbrand
2020-07-10 9:19 ` Cornelia Huck
2020-07-13 11:54 ` Christian Borntraeger [this message]
2020-07-13 12:11 ` Cornelia Huck
2020-07-13 12:13 ` Christian Borntraeger
2020-07-09 10:52 ` Christian Borntraeger
2020-07-09 18:15 ` David Hildenbrand
2020-07-10 9:17 ` David Hildenbrand
2020-07-10 12:12 ` David Hildenbrand
2020-07-10 15:18 ` Heiko Carstens
2020-07-10 15:24 ` David Hildenbrand
2020-07-10 15:43 ` Heiko Carstens
2020-07-10 15:45 ` David Hildenbrand
2020-07-13 9:12 ` Heiko Carstens
2020-07-13 10:27 ` David Hildenbrand
2020-07-13 11:08 ` Christian Borntraeger
2020-07-15 9:42 ` David Hildenbrand
2020-07-15 10:43 ` Heiko Carstens
2020-07-15 11:21 ` David Hildenbrand
2020-07-15 11:34 ` Heiko Carstens
2020-07-15 11:42 ` David Hildenbrand
2020-07-15 16:14 ` Heiko Carstens
2020-07-15 17:38 ` David Hildenbrand
2020-07-15 17:51 ` David Hildenbrand
2020-07-20 14:43 ` Heiko Carstens
2020-07-20 15:43 ` David Hildenbrand
2020-07-08 18:51 ` [PATCH RFC 3/5] s390x: prepare device memory address space David Hildenbrand
2020-07-09 10:59 ` Cornelia Huck
2020-07-10 7:46 ` David Hildenbrand
2020-07-08 18:51 ` [PATCH RFC 4/5] s390x: implement virtio-mem-ccw David Hildenbrand
2020-07-09 9:24 ` Cornelia Huck
2020-07-09 9:26 ` David Hildenbrand
2020-07-08 18:51 ` [PATCH RFC 5/5] s390x: initial support for virtio-mem David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68e4c043-2d4a-f538-1f86-a7171098b0db@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).