From: "Cédric Le Goater" <clg@kaod.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Andrew Jeffery <andrew@aj.id.au>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, Joel Stanley <joel@jms.id.au>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/arm: ast2400/ast2500: Wire up EHCI controllers
Date: Fri, 7 Feb 2020 14:05:31 +0100 [thread overview]
Message-ID: <78e3367c-765b-cfa8-b730-b8b237dd0c81@kaod.org> (raw)
In-Reply-To: <1605922b-2aa0-dd8e-720a-031e74bc9872@roeck-us.net>
On 2/7/20 1:58 PM, Guenter Roeck wrote:
> On 2/7/20 12:16 AM, Cédric Le Goater wrote:
>> On 2/6/20 7:34 PM, Guenter Roeck wrote:
>>> Initialize EHCI controllers on AST2400 and AST2500 using the existing
>>> TYPE_PLATFORM_EHCI. After this change, booting ast2500-evb into Linux
>>> successfully instantiates a USB interface.
>>>
>>> ehci-platform 1e6a3000.usb: EHCI Host Controller
>>> ehci-platform 1e6a3000.usb: new USB bus registered, assigned bus number 1
>>> ehci-platform 1e6a3000.usb: irq 21, io mem 0x1e6a3000
>>> ehci-platform 1e6a3000.usb: USB 2.0 started, EHCI 1.00
>>> usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 5.05
>>> usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1
>>> usb usb1: Product: EHCI Host Controller
>>
>> Cool. Have you tried to plug any devices ?
>>
>
> Yes, booting from USB drive works just fine. I already added it to my
> test suite at kerneltests.org.
>
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>
>>
>> This looks good. Could you add the AST2600 also ?
>>
>
> I thought about that, but how would I test it ? None of the ast2600
> systems in the Linux kernel enables it. The devicetree include file for
> ast2600 doesn't even have an entry for it. I could cook something up,
> but that would not reflect real hardware.
This is true. I suppose we could activate EHCI on the ast2600 evb.
Anyhow, let's move on.
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
next prev parent reply other threads:[~2020-02-07 13:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 18:34 [PATCH] hw/arm: ast2400/ast2500: Wire up EHCI controllers Guenter Roeck
2020-02-07 8:16 ` Cédric Le Goater
2020-02-07 12:58 ` Guenter Roeck
2020-02-07 13:05 ` Cédric Le Goater [this message]
2020-02-07 13:09 ` Joel Stanley
2020-02-07 14:21 ` Guenter Roeck
2020-02-07 14:30 ` Cédric Le Goater
2020-02-07 13:40 ` Philippe Mathieu-Daudé
2020-02-13 11:58 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78e3367c-765b-cfa8-b730-b8b237dd0c81@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=linux@roeck-us.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).