From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, laurent@vivier.eu
Subject: Re: [PATCH 11/20] nubus-device: add romfile property for loading declaration ROMs
Date: Wed, 15 Sep 2021 09:16:00 +0100 [thread overview]
Message-ID: <7965292b-75d9-35b1-2518-04a3b10b0412@ilande.co.uk> (raw)
In-Reply-To: <72dd46cf-2d9c-228c-05c7-e4f5d03df191@ilande.co.uk>
On 14/09/2021 21:23, Mark Cave-Ayland wrote:
> On 12/09/2021 18:39, Philippe Mathieu-Daudé wrote:
>
>> On 9/12/21 9:49 AM, Mark Cave-Ayland wrote:
>>> The declaration ROM is located at the top-most address of the standard slot
>>> space.
>>>
>>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>> ---
>>> hw/nubus/nubus-device.c | 43 +++++++++++++++++++++++++++++++++++++++-
>>> include/hw/nubus/nubus.h | 5 +++++
>>> 2 files changed, 47 insertions(+), 1 deletion(-)
>>
>>> + /* Declaration ROM */
>>
>>> + } else if (size > NUBUS_DECL_ROM_MAX_SIZE) {
>>
>> I'd check for >= and define as (64 * KiB).
>
> That's a good idea - I'll update this for the v2.
And in fact it looks like it is possible to embed multi-function MacOS drivers in the
declaration ROM so I'll keep the > and increase the maximum size to 128K which should
give plenty of breathing space for binary drivers.
>>> + error_setg(errp, "romfile \"%s\" too large (maximum size 64K)",
>>> + nd->romfile);
>>> + g_free(path);
>>> + return;
>>> + }
>>
>>> diff --git a/include/hw/nubus/nubus.h b/include/hw/nubus/nubus.h
>>> index 87a97516c7..42f4c9dbb8 100644
>>> --- a/include/hw/nubus/nubus.h
>>> +++ b/include/hw/nubus/nubus.h
>>> @@ -39,12 +39,17 @@ struct NubusBus {
>>> uint32_t slot_available_mask;
>>> };
>>> +#define NUBUS_DECL_ROM_MAX_SIZE 0xffff
ATB,
Mark.
next prev parent reply other threads:[~2021-09-15 8:17 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 7:48 [PATCH 00/20] nubus: bus, device, bridge, IRQ and address space improvements Mark Cave-Ayland
2021-09-12 7:48 ` [PATCH 01/20] nubus-device: rename slot_nb variable to slot Mark Cave-Ayland
2021-09-12 15:09 ` Philippe Mathieu-Daudé
2021-09-12 7:48 ` [PATCH 02/20] nubus-device: expose separate super slot memory region Mark Cave-Ayland
2021-09-12 15:50 ` Philippe Mathieu-Daudé
2021-09-12 17:20 ` Mark Cave-Ayland
2021-09-12 17:31 ` Philippe Mathieu-Daudé
2021-09-12 7:48 ` [PATCH 03/20] nubus-device: add device slot parameter Mark Cave-Ayland
2021-09-12 15:15 ` Philippe Mathieu-Daudé
2021-09-12 16:43 ` Mark Cave-Ayland
2021-09-12 7:48 ` [PATCH 04/20] nubus: use bitmap to manage available slots Mark Cave-Ayland
2021-09-12 17:48 ` Philippe Mathieu-Daudé
2021-09-14 20:27 ` Mark Cave-Ayland
2021-09-12 7:48 ` [PATCH 05/20] nubus: move slot bitmap checks from NubusDevice realize() to BusClass check_address() Mark Cave-Ayland
2021-09-12 7:49 ` [PATCH 06/20] nubus: implement BusClass get_dev_path() Mark Cave-Ayland
2021-09-12 15:16 ` Philippe Mathieu-Daudé
2021-09-12 7:49 ` [PATCH 07/20] nubus: add trace-events for unassigned slot accesses Mark Cave-Ayland
2021-09-12 15:18 ` Philippe Mathieu-Daudé
2021-09-12 16:45 ` Mark Cave-Ayland
2021-09-12 7:49 ` [PATCH 08/20] nubus: generate bus error when attempting to access empty slots Mark Cave-Ayland
2021-09-12 15:19 ` Philippe Mathieu-Daudé
2021-09-12 7:49 ` [PATCH 09/20] macfb: don't register declaration ROM Mark Cave-Ayland
2021-09-12 7:49 ` [PATCH 10/20] nubus-device: remove nubus_register_rom() and nubus_register_format_block() Mark Cave-Ayland
2021-09-12 7:49 ` [PATCH 11/20] nubus-device: add romfile property for loading declaration ROMs Mark Cave-Ayland
2021-09-12 17:39 ` Philippe Mathieu-Daudé
2021-09-14 20:23 ` Mark Cave-Ayland
2021-09-15 8:16 ` Mark Cave-Ayland [this message]
2021-09-12 7:49 ` [PATCH 12/20] nubus: move nubus to its own 32-bit address space Mark Cave-Ayland
2021-09-12 15:22 ` Philippe Mathieu-Daudé
2021-09-12 7:49 ` [PATCH 13/20] nubus-bridge: introduce separate NubusBridge structure Mark Cave-Ayland
2021-09-12 15:23 ` Philippe Mathieu-Daudé
2021-09-12 7:49 ` [PATCH 14/20] mac-nubus-bridge: rename MacNubusState to MacNubusBridge Mark Cave-Ayland
2021-09-12 15:23 ` Philippe Mathieu-Daudé
2021-09-12 7:49 ` [PATCH 15/20] nubus: move NubusBus from mac-nubus-bridge to nubus-bridge Mark Cave-Ayland
2021-09-12 15:25 ` Philippe Mathieu-Daudé
2021-09-12 7:49 ` [PATCH 16/20] nubus-bridge: embed the NubusBus object directly within nubus-bridge Mark Cave-Ayland
2021-09-12 15:26 ` Philippe Mathieu-Daudé
2021-09-12 17:43 ` Philippe Mathieu-Daudé
2021-09-14 20:26 ` Mark Cave-Ayland
2021-09-12 7:49 ` [PATCH 17/20] nubus-bridge: make slot_available_mask a qdev property Mark Cave-Ayland
2021-09-12 7:49 ` [PATCH 18/20] nubus: add support for slot IRQs Mark Cave-Ayland
2021-09-12 16:00 ` Philippe Mathieu-Daudé
2021-09-12 17:05 ` Mark Cave-Ayland
2021-09-12 7:49 ` [PATCH 19/20] q800: wire up nubus IRQs Mark Cave-Ayland
2021-09-12 7:49 ` [PATCH 20/20] q800: configure nubus available slots for Quadra 800 Mark Cave-Ayland
2021-09-12 15:47 ` [PATCH 00/20] nubus: bus, device, bridge, IRQ and address space improvements Philippe Mathieu-Daudé
2021-09-12 16:56 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7965292b-75d9-35b1-2518-04a3b10b0412@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).