From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Klaus Jensen <its@irrelevant.dk>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Klaus Jensen <k.jensen@samsung.com>,
Max Reitz <mreitz@redhat.com>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH v2 01/17] hw/block/nvme: fix typo in trace event
Date: Mon, 21 Sep 2020 17:49:13 +0200 [thread overview]
Message-ID: <7c4f5fd7-951d-45d7-b98c-e964eb67f0be@redhat.com> (raw)
In-Reply-To: <20200918203621.602915-2-its@irrelevant.dk>
On 9/18/20 10:36 PM, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Fix a typo in the sq doorbell trace event.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
> hw/block/trace-events | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/block/trace-events b/hw/block/trace-events
> index ec94c56a4165..8ff4cbc4932c 100644
> --- a/hw/block/trace-events
> +++ b/hw/block/trace-events
> @@ -70,7 +70,7 @@ pci_nvme_enqueue_req_completion(uint16_t cid, uint16_t cqid, uint16_t status) "c
> pci_nvme_mmio_read(uint64_t addr) "addr 0x%"PRIx64""
> pci_nvme_mmio_write(uint64_t addr, uint64_t data) "addr 0x%"PRIx64" data 0x%"PRIx64""
> pci_nvme_mmio_doorbell_cq(uint16_t cqid, uint16_t new_head) "cqid %"PRIu16" new_head %"PRIu16""
> -pci_nvme_mmio_doorbell_sq(uint16_t sqid, uint16_t new_tail) "cqid %"PRIu16" new_tail %"PRIu16""
> +pci_nvme_mmio_doorbell_sq(uint16_t sqid, uint16_t new_tail) "sqid %"PRIu16" new_tail %"PRIu16""
Oops.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> pci_nvme_mmio_intm_set(uint64_t data, uint64_t new_mask) "wrote MMIO, interrupt mask set, data=0x%"PRIx64", new_mask=0x%"PRIx64""
> pci_nvme_mmio_intm_clr(uint64_t data, uint64_t new_mask) "wrote MMIO, interrupt mask clr, data=0x%"PRIx64", new_mask=0x%"PRIx64""
> pci_nvme_mmio_cfg(uint64_t data) "wrote MMIO, config controller config=0x%"PRIx64""
>
next prev parent reply other threads:[~2020-09-21 15:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 20:36 [PATCH v2 00/17] hw/block/nvme: multiple namespaces support Klaus Jensen
2020-09-18 20:36 ` [PATCH v2 01/17] hw/block/nvme: fix typo in trace event Klaus Jensen
2020-09-21 15:49 ` Philippe Mathieu-Daudé [this message]
2020-09-18 20:36 ` [PATCH v2 02/17] pci: pass along the return value of dma_memory_rw Klaus Jensen
2020-09-18 20:36 ` [PATCH v2 03/17] hw/block/nvme: handle dma errors Klaus Jensen
2020-09-21 16:50 ` Keith Busch
2020-09-21 19:47 ` Klaus Jensen
2020-09-18 20:36 ` [PATCH v2 04/17] hw/block/nvme: commonize nvme_rw error handling Klaus Jensen
2020-09-18 20:36 ` [PATCH v2 05/17] hw/block/nvme: alignment style fixes Klaus Jensen
2020-09-18 20:36 ` [PATCH v2 06/17] hw/block/nvme: add a lba to bytes helper Klaus Jensen
2020-09-18 20:36 ` [PATCH v2 07/17] hw/block/nvme: fix endian conversion Klaus Jensen
2020-09-21 15:51 ` Philippe Mathieu-Daudé
2020-09-18 20:36 ` [PATCH v2 08/17] hw/block/nvme: add symbolic command name to trace events Klaus Jensen
2020-09-18 20:36 ` [PATCH v2 09/17] hw/block/nvme: refactor aio submission Klaus Jensen
2020-09-21 15:20 ` Keith Busch
2020-09-21 17:56 ` Klaus Jensen
2020-09-18 20:36 ` [PATCH v2 10/17] hw/block/nvme: default request status to success Klaus Jensen
2020-09-18 20:36 ` [PATCH v2 11/17] hw/block/nvme: harden cmb access Klaus Jensen
2020-09-18 20:36 ` [PATCH v2 12/17] hw/block/nvme: add support for scatter gather lists Klaus Jensen
2020-09-18 20:36 ` [PATCH v2 13/17] hw/block/nvme: add support for sgl bit bucket descriptor Klaus Jensen
2020-09-18 20:36 ` [PATCH v2 14/17] hw/block/nvme: refactor identify active namespace id list Klaus Jensen
2020-09-18 20:36 ` [PATCH v2 15/17] hw/block/nvme: support multiple namespaces Klaus Jensen
2020-09-18 20:36 ` [PATCH v2 16/17] pci: allocate pci id for nvme Klaus Jensen
2020-09-18 20:36 ` [PATCH v2 17/17] hw/block/nvme: change controller pci id Klaus Jensen
2020-09-21 19:26 ` [PATCH v2 00/17] hw/block/nvme: multiple namespaces support Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c4f5fd7-951d-45d7-b98c-e964eb67f0be@redhat.com \
--to=philmd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).