* [PATCH] configure: Do not use default_feature for EXESUF
@ 2021-03-31 8:18 mrezanin
2021-03-31 15:06 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: mrezanin @ 2021-03-31 8:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée
From: Miroslav Rezanina <mrezanin@redhat.com>
Commit "c87ea11631 configure: add --without-default-features" use
default_feature to set default values for configure option. This value
is used for EXESUF too.
However, EXESUF is not option to be tested, it is just append to any
binary name so using --without-default-features set EXESUF to "n"o and
all binaries using it has form <name>no (e.g. qemu-imgno).
This is not expected behavior as disabling features should not cause
generating different binary names.
Reverting back to setting EXESUF to empty value unless needed otherwise.
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 535e6a9269..8275df1506 100755
--- a/configure
+++ b/configure
@@ -365,7 +365,7 @@ tcg_interpreter="false"
bigendian="no"
mingw32="no"
gcov="no"
-EXESUF="$default_feature"
+EXESUF=""
HOST_DSOSUF=".so"
modules="no"
module_upgrades="no"
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] configure: Do not use default_feature for EXESUF
2021-03-31 8:18 [PATCH] configure: Do not use default_feature for EXESUF mrezanin
@ 2021-03-31 15:06 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2021-03-31 15:06 UTC (permalink / raw)
To: mrezanin, qemu-devel; +Cc: Alex Bennée
On 31/03/21 10:18, mrezanin@redhat.com wrote:
> From: Miroslav Rezanina <mrezanin@redhat.com>
>
> Commit "c87ea11631 configure: add --without-default-features" use
> default_feature to set default values for configure option. This value
> is used for EXESUF too.
>
> However, EXESUF is not option to be tested, it is just append to any
> binary name so using --without-default-features set EXESUF to "n"o and
> all binaries using it has form <name>no (e.g. qemu-imgno).
>
> This is not expected behavior as disabling features should not cause
> generating different binary names.
>
> Reverting back to setting EXESUF to empty value unless needed otherwise.
>
> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 535e6a9269..8275df1506 100755
> --- a/configure
> +++ b/configure
> @@ -365,7 +365,7 @@ tcg_interpreter="false"
> bigendian="no"
> mingw32="no"
> gcov="no"
> -EXESUF="$default_feature"
> +EXESUF=""
> HOST_DSOSUF=".so"
> modules="no"
> module_upgrades="no"
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-31 15:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 8:18 [PATCH] configure: Do not use default_feature for EXESUF mrezanin
2021-03-31 15:06 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).