* [PATCH] do not use colons in test names
@ 2020-10-19 11:41 Paolo Bonzini
2020-10-19 11:51 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2020-10-19 11:41 UTC (permalink / raw)
To: qemu-devel
Starting with meson 0.56, colons are used to separate the subproject name
from the test name. Use dash or slash depending on what looks nicer.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/fp/meson.build | 4 ++--
tests/qtest/meson.build | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/fp/meson.build b/tests/fp/meson.build
index 24739ad421..514e345bf5 100644
--- a/tests/fp/meson.build
+++ b/tests/fp/meson.build
@@ -603,7 +603,7 @@ fptest_rounding_args = ['-r', 'all']
# FIXME: i32_to_extF80 (broken), i64_to_extF80 (broken)
# extF80_roundToInt (broken)
foreach k, v : softfloat_conv_tests
- test('fp-test:' + k, fptest,
+ test('fp-test-' + k, fptest,
args: fptest_args + fptest_rounding_args + v.split(),
suite: ['softfloat', 'softfloat-conv'])
endforeach
@@ -612,7 +612,7 @@ endforeach
# extF80_{mulAdd} (missing)
foreach k, v : softfloat_tests
extF80_broken = ['lt_quiet', 'rem'].contains(k)
- test('fp-test:' + k, fptest,
+ test('fp-test-' + k, fptest,
args: fptest_args + fptest_rounding_args +
['f16_' + k, 'f32_' + k, 'f64_' + k, 'f128_' + k] +
(extF80_broken ? [] : ['extF80_' + k]),
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index 3987f96086..c2822d9de7 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -250,7 +250,7 @@ foreach dir : target_dirs
}
endif
# FIXME: missing dependency on the emulator binary and qemu-img
- test('qtest-@0@: @1@'.format(target_base, test),
+ test('qtest-@0@/@1@'.format(target_base, test),
qtest_executables[test],
depends: [test_deps, qtest_emulator],
env: qtest_env,
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] do not use colons in test names
2020-10-19 11:41 [PATCH] do not use colons in test names Paolo Bonzini
@ 2020-10-19 11:51 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-19 11:51 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
On 10/19/20 1:41 PM, Paolo Bonzini wrote:
> Starting with meson 0.56, colons are used to separate the subproject name
> from the test name. Use dash or slash depending on what looks nicer.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tests/fp/meson.build | 4 ++--
> tests/qtest/meson.build | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/fp/meson.build b/tests/fp/meson.build
> index 24739ad421..514e345bf5 100644
> --- a/tests/fp/meson.build
> +++ b/tests/fp/meson.build
> @@ -603,7 +603,7 @@ fptest_rounding_args = ['-r', 'all']
> # FIXME: i32_to_extF80 (broken), i64_to_extF80 (broken)
> # extF80_roundToInt (broken)
> foreach k, v : softfloat_conv_tests
> - test('fp-test:' + k, fptest,
> + test('fp-test-' + k, fptest,
> args: fptest_args + fptest_rounding_args + v.split(),
> suite: ['softfloat', 'softfloat-conv'])
> endforeach
> @@ -612,7 +612,7 @@ endforeach
> # extF80_{mulAdd} (missing)
> foreach k, v : softfloat_tests
> extF80_broken = ['lt_quiet', 'rem'].contains(k)
> - test('fp-test:' + k, fptest,
> + test('fp-test-' + k, fptest,
> args: fptest_args + fptest_rounding_args +
> ['f16_' + k, 'f32_' + k, 'f64_' + k, 'f128_' + k] +
> (extF80_broken ? [] : ['extF80_' + k]),
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 3987f96086..c2822d9de7 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -250,7 +250,7 @@ foreach dir : target_dirs
> }
> endif
> # FIXME: missing dependency on the emulator binary and qemu-img
> - test('qtest-@0@: @1@'.format(target_base, test),
> + test('qtest-@0@/@1@'.format(target_base, test),
> qtest_executables[test],
> depends: [test_deps, qtest_emulator],
> env: qtest_env,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-19 11:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 11:41 [PATCH] do not use colons in test names Paolo Bonzini
2020-10-19 11:51 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).