From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Lukas Straub <lukasstraub2@web.de>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 10/12] Fix build with new yank feature by adding stubs
Date: Thu, 14 Jan 2021 18:50:20 +0000 [thread overview]
Message-ID: <87a6tbl5dp.fsf@linaro.org> (raw)
In-Reply-To: <88ed23a1-06b2-ce13-842d-9aa1acb381a3@redhat.com>
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 1/14/21 5:57 PM, Alex Bennée wrote:
>> From: Lukas Straub <lukasstraub2@web.de>
>>
>
> Again:
>
> Fixes: 50186051f42 ("Introduce yank feature")
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Hmm I need to improve my tooling to pick up the Fixes and add a TODO.
>
>> Signed-off-by: Lukas Straub <lukasstraub2@web.de>
>> [AJB: tweak MAINTAINERS]
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Message-Id: <20210114141918.5201cc9c@gecko.fritz.box>
>> ---
>> stubs/yank.c | 29 +++++++++++++++++++++++++++++
>> MAINTAINERS | 1 +
>> stubs/meson.build | 1 +
>> 3 files changed, 31 insertions(+)
>> create mode 100644 stubs/yank.c
>>
>> diff --git a/stubs/yank.c b/stubs/yank.c
>> new file mode 100644
>> index 0000000000..6090416065
>> --- /dev/null
>> +++ b/stubs/yank.c
>> @@ -0,0 +1,29 @@
>> +#include "qemu/osdep.h"
>> +#include "qemu/yank.h"
>> +
>> +bool yank_register_instance(const YankInstance *instance, Error **errp)
>> +{
>> + return true;
>> +}
>> +
>> +void yank_unregister_instance(const YankInstance *instance)
>> +{
>> +}
>> +
>> +void yank_register_function(const YankInstance *instance,
>> + YankFn *func,
>> + void *opaque)
>> +{
>> +}
>> +
>> +void yank_unregister_function(const YankInstance *instance,
>> + YankFn *func,
>> + void *opaque)
>> +{
>> +}
>> +
>> +void yank_generic_iochannel(void *opaque)
>> +{
>> +}
>> +
>> +
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index cb0656aec3..07e4851aa4 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2736,6 +2736,7 @@ Yank feature
>> M: Lukas Straub <lukasstraub2@web.de>
>> S: Odd fixes
>> F: util/yank.c
>> +F: stubs/yank.c
>> F: include/qemu/yank.h
>> F: qapi/yank.json
>>
>> diff --git a/stubs/meson.build b/stubs/meson.build
>> index 80b1d81a31..1a656cd070 100644
>> --- a/stubs/meson.build
>> +++ b/stubs/meson.build
>> @@ -47,6 +47,7 @@ stub_ss.add(files('vm-stop.c'))
>> stub_ss.add(files('win32-kbd-hook.c'))
>> stub_ss.add(files('cpu-synchronize-state.c'))
>> if have_block
>> + stub_ss.add(files('yank.c'))
>> stub_ss.add(files('replay-tools.c'))
>> endif
>> if have_system
>>
--
Alex Bennée
next prev parent reply other threads:[~2021-01-14 18:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 16:57 [PATCH v2 00/12] testing/next (tags!, shippable/travis deprecation, regression fixes, checkpatch) Alex Bennée
2021-01-14 16:57 ` [PATCH v2 01/12] tests/docker: Remove Debian 9 remnant lines Alex Bennée
2021-01-14 20:03 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 02/12] Makefile: add GNU global tags support Alex Bennée
2021-01-14 18:09 ` Philippe Mathieu-Daudé
2021-01-14 16:57 ` [PATCH v2 03/12] shippable.yml: Remove jobs duplicated on Gitlab-CI Alex Bennée
2021-01-14 16:57 ` [PATCH v2 04/12] Add newline when generating Dockerfile Alex Bennée
2021-01-14 17:51 ` Philippe Mathieu-Daudé
2021-01-14 19:42 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 05/12] Makefile: wrap ctags in quiet-command calls Alex Bennée
2021-01-14 18:07 ` Philippe Mathieu-Daudé
2021-01-14 19:46 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 06/12] Makefile: wrap etags " Alex Bennée
2021-01-14 18:08 ` Philippe Mathieu-Daudé
2021-01-14 19:48 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 07/12] Makefile: wrap cscope " Alex Bennée
2021-01-14 18:08 ` Philippe Mathieu-Daudé
2021-01-14 19:45 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 08/12] docker: expand debian-amd64 image to include tag tools Alex Bennée
2021-01-14 17:50 ` Philippe Mathieu-Daudé
2021-01-14 17:52 ` Daniel P. Berrangé
2021-01-14 17:53 ` Philippe Mathieu-Daudé
2021-01-14 17:55 ` Daniel P. Berrangé
2021-01-14 19:41 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 09/12] gitlab: move docs and tools build across from Travis Alex Bennée
2021-01-14 19:54 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 10/12] Fix build with new yank feature by adding stubs Alex Bennée
2021-01-14 17:47 ` Philippe Mathieu-Daudé
2021-01-14 18:50 ` Alex Bennée [this message]
2021-01-14 16:57 ` [PATCH v2 11/12] gitlab: migrate the minimal tools and unit tests from Travis Alex Bennée
2021-01-14 17:57 ` Philippe Mathieu-Daudé
2021-01-14 19:00 ` Thomas Huth
2021-01-14 19:36 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 12/12] scripts/checkpatch.pl: fix git-show invocation to include diffstat Alex Bennée
2021-01-14 18:05 ` Philippe Mathieu-Daudé
2021-01-14 19:51 ` Willian Rampazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6tbl5dp.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=lukasstraub2@web.de \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).