From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Thomas Huth <thuth@redhat.com>,
Wainer dos Santos Moschetta <wainersm@redhat.com>
Subject: Re: [PATCH v2 11/12] gitlab: migrate the minimal tools and unit tests from Travis
Date: Thu, 14 Jan 2021 18:57:46 +0100 [thread overview]
Message-ID: <a7b5cd2d-392d-4b83-f68a-4af60b694a0f@redhat.com> (raw)
In-Reply-To: <20210114165730.31607-12-alex.bennee@linaro.org>
On 1/14/21 5:57 PM, Alex Bennée wrote:
> These tests are good at shaking out missing stubs which otherwise work
> if we have built targets. Rather than create a new job just add the
> checks to the existing tools-and-docs build.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> .gitlab-ci.yml | 4 +++-
> .travis.yml | 9 ---------
> 2 files changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index bd60f3e741..a686bc40cf 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -124,11 +124,13 @@ check-system-debian:
> IMAGE: debian-amd64
> MAKE_CHECK_ARGS: check
>
> +# No targets are built here, just tools and docs. This also feeds into
> +# the eventual documentation deployment steps later
Correcting with "just tools, docs [and softfloat checks]":
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> build-tools-and-docs-debian:
> <<: *native_build_job_definition
> variables:
> IMAGE: debian-amd64
> - MAKE_CHECK_ARGS: ctags TAGS cscope
> + MAKE_CHECK_ARGS: check-unit check-softfloat ctags TAGS cscope
> CONFIGURE_ARGS: --disable-system --disable-user --enable-docs --enable-tools
> artifacts:
> expire_in: 2 days
> diff --git a/.travis.yml b/.travis.yml
> index 3b574a5968..5f1dea873e 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -119,15 +119,6 @@ after_script:
>
> jobs:
> include:
> - # Just build tools and run minimal unit and softfloat checks
> - - name: "GCC check-unit and check-softfloat"
> - env:
> - - BASE_CONFIG="--enable-tools"
> - - CONFIG="--disable-user --disable-system"
> - - TEST_CMD="make check-unit check-softfloat -j${JOBS}"
> - - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
> -
> -
> # --enable-debug implies --enable-debug-tcg, also runs quite a bit slower
> - name: "GCC debug (main-softmmu)"
> env:
>
next prev parent reply other threads:[~2021-01-14 18:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 16:57 [PATCH v2 00/12] testing/next (tags!, shippable/travis deprecation, regression fixes, checkpatch) Alex Bennée
2021-01-14 16:57 ` [PATCH v2 01/12] tests/docker: Remove Debian 9 remnant lines Alex Bennée
2021-01-14 20:03 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 02/12] Makefile: add GNU global tags support Alex Bennée
2021-01-14 18:09 ` Philippe Mathieu-Daudé
2021-01-14 16:57 ` [PATCH v2 03/12] shippable.yml: Remove jobs duplicated on Gitlab-CI Alex Bennée
2021-01-14 16:57 ` [PATCH v2 04/12] Add newline when generating Dockerfile Alex Bennée
2021-01-14 17:51 ` Philippe Mathieu-Daudé
2021-01-14 19:42 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 05/12] Makefile: wrap ctags in quiet-command calls Alex Bennée
2021-01-14 18:07 ` Philippe Mathieu-Daudé
2021-01-14 19:46 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 06/12] Makefile: wrap etags " Alex Bennée
2021-01-14 18:08 ` Philippe Mathieu-Daudé
2021-01-14 19:48 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 07/12] Makefile: wrap cscope " Alex Bennée
2021-01-14 18:08 ` Philippe Mathieu-Daudé
2021-01-14 19:45 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 08/12] docker: expand debian-amd64 image to include tag tools Alex Bennée
2021-01-14 17:50 ` Philippe Mathieu-Daudé
2021-01-14 17:52 ` Daniel P. Berrangé
2021-01-14 17:53 ` Philippe Mathieu-Daudé
2021-01-14 17:55 ` Daniel P. Berrangé
2021-01-14 19:41 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 09/12] gitlab: move docs and tools build across from Travis Alex Bennée
2021-01-14 19:54 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 10/12] Fix build with new yank feature by adding stubs Alex Bennée
2021-01-14 17:47 ` Philippe Mathieu-Daudé
2021-01-14 18:50 ` Alex Bennée
2021-01-14 16:57 ` [PATCH v2 11/12] gitlab: migrate the minimal tools and unit tests from Travis Alex Bennée
2021-01-14 17:57 ` Philippe Mathieu-Daudé [this message]
2021-01-14 19:00 ` Thomas Huth
2021-01-14 19:36 ` Willian Rampazzo
2021-01-14 16:57 ` [PATCH v2 12/12] scripts/checkpatch.pl: fix git-show invocation to include diffstat Alex Bennée
2021-01-14 18:05 ` Philippe Mathieu-Daudé
2021-01-14 19:51 ` Willian Rampazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7b5cd2d-392d-4b83-f68a-4af60b694a0f@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).