QEMU-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] docker: remove libcap development packages
@ 2019-11-29 15:08 Paolo Bonzini
  2019-12-02 10:49 ` Greg Kurz
  0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2019-11-29 15:08 UTC (permalink / raw)
  To: qemu-devel; +Cc: berrange, groug, dgilbert

Libcap was dropped from virtio-9p, so remove it from the dockerfiles as well.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/docker/dockerfiles/fedora.docker     | 1 -
 tests/docker/dockerfiles/ubuntu.docker     | 1 -
 tests/docker/dockerfiles/ubuntu1804.docker | 1 -
 3 files changed, 3 deletions(-)

diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
index 4ddc7dd112..47732fc5d5 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -25,7 +25,6 @@ ENV PACKAGES \
     libasan \
     libattr-devel \
     libblockdev-mpath-devel \
-    libcap-devel \
     libcap-ng-devel \
     libcurl-devel \
     libfdt-devel \
diff --git a/tests/docker/dockerfiles/ubuntu.docker b/tests/docker/dockerfiles/ubuntu.docker
index f486492224..ecea155646 100644
--- a/tests/docker/dockerfiles/ubuntu.docker
+++ b/tests/docker/dockerfiles/ubuntu.docker
@@ -23,7 +23,6 @@ ENV PACKAGES flex bison \
     libbrlapi-dev \
     libbz2-dev \
     libcacard-dev \
-    libcap-dev \
     libcap-ng-dev \
     libcurl4-gnutls-dev \
     libdrm-dev \
diff --git a/tests/docker/dockerfiles/ubuntu1804.docker b/tests/docker/dockerfiles/ubuntu1804.docker
index 3cc4f492c4..32a607471a 100644
--- a/tests/docker/dockerfiles/ubuntu1804.docker
+++ b/tests/docker/dockerfiles/ubuntu1804.docker
@@ -12,7 +12,6 @@ ENV PACKAGES flex bison \
     libbrlapi-dev \
     libbz2-dev \
     libcacard-dev \
-    libcap-dev \
     libcap-ng-dev \
     libcurl4-gnutls-dev \
     libdrm-dev \
-- 
2.21.0



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] docker: remove libcap development packages
  2019-11-29 15:08 [PATCH] docker: remove libcap development packages Paolo Bonzini
@ 2019-12-02 10:49 ` Greg Kurz
  2019-12-02 13:07   ` Greg Kurz
  2019-12-03  7:20   ` Alex Bennée
  0 siblings, 2 replies; 4+ messages in thread
From: Greg Kurz @ 2019-12-02 10:49 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: Fam Zheng, Alex Bennée, berrange, qemu-devel, dgilbert

On Fri, 29 Nov 2019 16:08:01 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Libcap was dropped from virtio-9p, so remove it from the dockerfiles as well.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---

Similarly to what was discussed in these threads:

20191129111632.22840-2-pbonzini@redhat.com

20191129142126.32967-1-dgilbert@redhat.com

I'm ok to take this one in my tree as well if I get an ack from Alex
or Fam.

>  tests/docker/dockerfiles/fedora.docker     | 1 -
>  tests/docker/dockerfiles/ubuntu.docker     | 1 -
>  tests/docker/dockerfiles/ubuntu1804.docker | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 4ddc7dd112..47732fc5d5 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -25,7 +25,6 @@ ENV PACKAGES \
>      libasan \
>      libattr-devel \
>      libblockdev-mpath-devel \
> -    libcap-devel \
>      libcap-ng-devel \
>      libcurl-devel \
>      libfdt-devel \
> diff --git a/tests/docker/dockerfiles/ubuntu.docker b/tests/docker/dockerfiles/ubuntu.docker
> index f486492224..ecea155646 100644
> --- a/tests/docker/dockerfiles/ubuntu.docker
> +++ b/tests/docker/dockerfiles/ubuntu.docker
> @@ -23,7 +23,6 @@ ENV PACKAGES flex bison \
>      libbrlapi-dev \
>      libbz2-dev \
>      libcacard-dev \
> -    libcap-dev \
>      libcap-ng-dev \
>      libcurl4-gnutls-dev \
>      libdrm-dev \
> diff --git a/tests/docker/dockerfiles/ubuntu1804.docker b/tests/docker/dockerfiles/ubuntu1804.docker
> index 3cc4f492c4..32a607471a 100644
> --- a/tests/docker/dockerfiles/ubuntu1804.docker
> +++ b/tests/docker/dockerfiles/ubuntu1804.docker
> @@ -12,7 +12,6 @@ ENV PACKAGES flex bison \
>      libbrlapi-dev \
>      libbz2-dev \
>      libcacard-dev \
> -    libcap-dev \
>      libcap-ng-dev \
>      libcurl4-gnutls-dev \
>      libdrm-dev \



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] docker: remove libcap development packages
  2019-12-02 10:49 ` Greg Kurz
@ 2019-12-02 13:07   ` Greg Kurz
  2019-12-03  7:20   ` Alex Bennée
  1 sibling, 0 replies; 4+ messages in thread
From: Greg Kurz @ 2019-12-02 13:07 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: Fam Zheng, berrange, Alex Bennée, qemu-devel, dgilbert

On Mon, 2 Dec 2019 11:49:58 +0100
Greg Kurz <groug@kaod.org> wrote:

> On Fri, 29 Nov 2019 16:08:01 +0100
> Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
> > Libcap was dropped from virtio-9p, so remove it from the dockerfiles as well.
> > 
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> 
> Similarly to what was discussed in these threads:
> 
> 20191129111632.22840-2-pbonzini@redhat.com
> 
> 20191129142126.32967-1-dgilbert@redhat.com
> 
> I'm ok to take this one in my tree as well if I get an ack from Alex
> or Fam.
> 

Oops, I didn't realize my mail client still had Fam's previous address...

> >  tests/docker/dockerfiles/fedora.docker     | 1 -
> >  tests/docker/dockerfiles/ubuntu.docker     | 1 -
> >  tests/docker/dockerfiles/ubuntu1804.docker | 1 -
> >  3 files changed, 3 deletions(-)
> > 
> > diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> > index 4ddc7dd112..47732fc5d5 100644
> > --- a/tests/docker/dockerfiles/fedora.docker
> > +++ b/tests/docker/dockerfiles/fedora.docker
> > @@ -25,7 +25,6 @@ ENV PACKAGES \
> >      libasan \
> >      libattr-devel \
> >      libblockdev-mpath-devel \
> > -    libcap-devel \
> >      libcap-ng-devel \
> >      libcurl-devel \
> >      libfdt-devel \
> > diff --git a/tests/docker/dockerfiles/ubuntu.docker b/tests/docker/dockerfiles/ubuntu.docker
> > index f486492224..ecea155646 100644
> > --- a/tests/docker/dockerfiles/ubuntu.docker
> > +++ b/tests/docker/dockerfiles/ubuntu.docker
> > @@ -23,7 +23,6 @@ ENV PACKAGES flex bison \
> >      libbrlapi-dev \
> >      libbz2-dev \
> >      libcacard-dev \
> > -    libcap-dev \
> >      libcap-ng-dev \
> >      libcurl4-gnutls-dev \
> >      libdrm-dev \
> > diff --git a/tests/docker/dockerfiles/ubuntu1804.docker b/tests/docker/dockerfiles/ubuntu1804.docker
> > index 3cc4f492c4..32a607471a 100644
> > --- a/tests/docker/dockerfiles/ubuntu1804.docker
> > +++ b/tests/docker/dockerfiles/ubuntu1804.docker
> > @@ -12,7 +12,6 @@ ENV PACKAGES flex bison \
> >      libbrlapi-dev \
> >      libbz2-dev \
> >      libcacard-dev \
> > -    libcap-dev \
> >      libcap-ng-dev \
> >      libcurl4-gnutls-dev \
> >      libdrm-dev \
> 
> 



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] docker: remove libcap development packages
  2019-12-02 10:49 ` Greg Kurz
  2019-12-02 13:07   ` Greg Kurz
@ 2019-12-03  7:20   ` Alex Bennée
  1 sibling, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2019-12-03  7:20 UTC (permalink / raw)
  To: Greg Kurz; +Cc: Fam Zheng, Paolo Bonzini, berrange, qemu-devel, dgilbert


Greg Kurz <groug@kaod.org> writes:

> On Fri, 29 Nov 2019 16:08:01 +0100
> Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>> Libcap was dropped from virtio-9p, so remove it from the dockerfiles as well.
>> 
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>
> Similarly to what was discussed in these threads:
>
> 20191129111632.22840-2-pbonzini@redhat.com
>
> 20191129142126.32967-1-dgilbert@redhat.com
>
> I'm ok to take this one in my tree as well if I get an ack from Alex
> or Fam.

Acked-by: Alex Bennée <alex.bennee@linaro.org>

>
>>  tests/docker/dockerfiles/fedora.docker     | 1 -
>>  tests/docker/dockerfiles/ubuntu.docker     | 1 -
>>  tests/docker/dockerfiles/ubuntu1804.docker | 1 -
>>  3 files changed, 3 deletions(-)
>> 
>> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
>> index 4ddc7dd112..47732fc5d5 100644
>> --- a/tests/docker/dockerfiles/fedora.docker
>> +++ b/tests/docker/dockerfiles/fedora.docker
>> @@ -25,7 +25,6 @@ ENV PACKAGES \
>>      libasan \
>>      libattr-devel \
>>      libblockdev-mpath-devel \
>> -    libcap-devel \
>>      libcap-ng-devel \
>>      libcurl-devel \
>>      libfdt-devel \
>> diff --git a/tests/docker/dockerfiles/ubuntu.docker b/tests/docker/dockerfiles/ubuntu.docker
>> index f486492224..ecea155646 100644
>> --- a/tests/docker/dockerfiles/ubuntu.docker
>> +++ b/tests/docker/dockerfiles/ubuntu.docker
>> @@ -23,7 +23,6 @@ ENV PACKAGES flex bison \
>>      libbrlapi-dev \
>>      libbz2-dev \
>>      libcacard-dev \
>> -    libcap-dev \
>>      libcap-ng-dev \
>>      libcurl4-gnutls-dev \
>>      libdrm-dev \
>> diff --git a/tests/docker/dockerfiles/ubuntu1804.docker b/tests/docker/dockerfiles/ubuntu1804.docker
>> index 3cc4f492c4..32a607471a 100644
>> --- a/tests/docker/dockerfiles/ubuntu1804.docker
>> +++ b/tests/docker/dockerfiles/ubuntu1804.docker
>> @@ -12,7 +12,6 @@ ENV PACKAGES flex bison \
>>      libbrlapi-dev \
>>      libbz2-dev \
>>      libcacard-dev \
>> -    libcap-dev \
>>      libcap-ng-dev \
>>      libcurl4-gnutls-dev \
>>      libdrm-dev \


-- 
Alex Bennée


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-29 15:08 [PATCH] docker: remove libcap development packages Paolo Bonzini
2019-12-02 10:49 ` Greg Kurz
2019-12-02 13:07   ` Greg Kurz
2019-12-03  7:20   ` Alex Bennée

QEMU-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
	git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
		qemu-devel@nongnu.org
	public-inbox-index qemu-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git