* [PATCH] docs/devel/writing-qmp-commands.txt: Fix docs
@ 2020-12-01 14:33 Zihao Chang
2020-12-01 20:18 ` Eric Blake
2020-12-02 9:57 ` Markus Armbruster
0 siblings, 2 replies; 3+ messages in thread
From: Zihao Chang @ 2020-12-01 14:33 UTC (permalink / raw)
To: qemu-devel; +Cc: changzihao1, armbru, xiexiangyou
Fix the example of add qmp hello-world example.
Without ":", make will report error:
../qapi/misc.json:573:2: line should end with ':'
Signed-off-by: Zihao Chang <changzihao1@huawei.com>
---
docs/devel/writing-qmp-commands.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/devel/writing-qmp-commands.txt b/docs/devel/writing-qmp-commands.txt
index 46a6c48683..28984686c9 100644
--- a/docs/devel/writing-qmp-commands.txt
+++ b/docs/devel/writing-qmp-commands.txt
@@ -243,7 +243,7 @@ There are many examples of such documentation in the schema file already, but
here goes "hello-world"'s new entry for qapi/misc.json:
##
-# @hello-world
+# @hello-world:
#
# Print a client provided string to the standard output stream.
#
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] docs/devel/writing-qmp-commands.txt: Fix docs
2020-12-01 14:33 [PATCH] docs/devel/writing-qmp-commands.txt: Fix docs Zihao Chang
@ 2020-12-01 20:18 ` Eric Blake
2020-12-02 9:57 ` Markus Armbruster
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2020-12-01 20:18 UTC (permalink / raw)
To: Zihao Chang, qemu-devel; +Cc: armbru, xiexiangyou
On 12/1/20 8:33 AM, Zihao Chang wrote:
> Fix the example of add qmp hello-world example.
> Without ":", make will report error:
> ../qapi/misc.json:573:2: line should end with ':'
>
> Signed-off-by: Zihao Chang <changzihao1@huawei.com>
> ---
> docs/devel/writing-qmp-commands.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/docs/devel/writing-qmp-commands.txt b/docs/devel/writing-qmp-commands.txt
> index 46a6c48683..28984686c9 100644
> --- a/docs/devel/writing-qmp-commands.txt
> +++ b/docs/devel/writing-qmp-commands.txt
> @@ -243,7 +243,7 @@ There are many examples of such documentation in the schema file already, but
> here goes "hello-world"'s new entry for qapi/misc.json:
>
> ##
> -# @hello-world
> +# @hello-world:
> #
> # Print a client provided string to the standard output stream.
> #
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs/devel/writing-qmp-commands.txt: Fix docs
2020-12-01 14:33 [PATCH] docs/devel/writing-qmp-commands.txt: Fix docs Zihao Chang
2020-12-01 20:18 ` Eric Blake
@ 2020-12-02 9:57 ` Markus Armbruster
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2020-12-02 9:57 UTC (permalink / raw)
To: Zihao Chang; +Cc: qemu-devel, xiexiangyou
Zihao Chang <changzihao1@huawei.com> writes:
> Fix the example of add qmp hello-world example.
> Without ":", make will report error:
> ../qapi/misc.json:573:2: line should end with ':'
>
> Signed-off-by: Zihao Chang <changzihao1@huawei.com>
> ---
> docs/devel/writing-qmp-commands.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/devel/writing-qmp-commands.txt b/docs/devel/writing-qmp-commands.txt
> index 46a6c48683..28984686c9 100644
> --- a/docs/devel/writing-qmp-commands.txt
> +++ b/docs/devel/writing-qmp-commands.txt
> @@ -243,7 +243,7 @@ There are many examples of such documentation in the schema file already, but
> here goes "hello-world"'s new entry for qapi/misc.json:
>
> ##
> -# @hello-world
> +# @hello-world:
> #
> # Print a client provided string to the standard output stream.
> #
Queued, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-02 10:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-01 14:33 [PATCH] docs/devel/writing-qmp-commands.txt: Fix docs Zihao Chang
2020-12-01 20:18 ` Eric Blake
2020-12-02 9:57 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).