From: Markus Armbruster <armbru@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: "philmd@redhat.com" <philmd@redhat.com>,
"arei.gonglei@huawei.com" <arei.gonglei@huawei.com>,
"marcandre.lureau@gmail.com" <marcandre.lureau@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete()
Date: Fri, 29 Nov 2019 13:09:10 +0100 [thread overview]
Message-ID: <87eexqubo9.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1b532161-7de9-8ea5-0771-69fdeb5b70bc@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Fri, 29 Nov 2019 08:31:34 +0000")
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
> 29.11.2019 9:10, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
>>
>>> No reason for local_err here, use errp directly instead.
>>
>> Related: "[PATCH v6] hw/vfio/ap: drop local_err from vfio_ap_realize".
>> I'm surprised it's just two. Did you search for the anti-pattern
>> systematically?
>
> As I remember - no, only where it breaks automation. Here empty "out: }"
> label will break compilation, if not fixed before or after coccinelle
> run. So, here I fixed it before.
Got it.
A through sweep would be nice, but the goal you're pursuing here
involves more than enough churn already. Don't worry about it now.
[...]
prev parent reply other threads:[~2019-11-29 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 19:45 [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete() Vladimir Sementsov-Ogievskiy
2019-11-28 7:13 ` Gonglei (Arei)
2019-11-29 6:10 ` Markus Armbruster
2019-11-29 8:31 ` Vladimir Sementsov-Ogievskiy
2019-11-29 12:09 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eexqubo9.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=marcandre.lureau@gmail.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).