* [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete()
@ 2019-11-27 19:45 Vladimir Sementsov-Ogievskiy
2019-11-28 7:13 ` Gonglei (Arei)
2019-11-29 6:10 ` Markus Armbruster
0 siblings, 2 replies; 5+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2019-11-27 19:45 UTC (permalink / raw)
To: qemu-devel; +Cc: philmd, arei.gonglei, marcandre.lureau, vsementsov
No reason for local_err here, use errp directly instead.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
v6: add r-b by Philippe and Marc-André
backends/cryptodev.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/backends/cryptodev.c b/backends/cryptodev.c
index 3c071eab95..5a9735684e 100644
--- a/backends/cryptodev.c
+++ b/backends/cryptodev.c
@@ -176,19 +176,10 @@ cryptodev_backend_complete(UserCreatable *uc, Error **errp)
{
CryptoDevBackend *backend = CRYPTODEV_BACKEND(uc);
CryptoDevBackendClass *bc = CRYPTODEV_BACKEND_GET_CLASS(uc);
- Error *local_err = NULL;
if (bc->init) {
- bc->init(backend, &local_err);
- if (local_err) {
- goto out;
- }
+ bc->init(backend, errp);
}
-
- return;
-
-out:
- error_propagate(errp, local_err);
}
void cryptodev_backend_set_used(CryptoDevBackend *backend, bool used)
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete()
2019-11-27 19:45 [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete() Vladimir Sementsov-Ogievskiy
@ 2019-11-28 7:13 ` Gonglei (Arei)
2019-11-29 6:10 ` Markus Armbruster
1 sibling, 0 replies; 5+ messages in thread
From: Gonglei (Arei) @ 2019-11-28 7:13 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy, qemu-devel
Cc: qemu-trivial, philmd, marcandre.lureau
CCing qemu-trivial@nongnu.org
Reviewed-by: Gonglei <arei.gonglei@huawei.com>
Regards,
-Gonglei
> -----Original Message-----
> From: Vladimir Sementsov-Ogievskiy [mailto:vsementsov@virtuozzo.com]
> Sent: Thursday, November 28, 2019 3:46 AM
> To: qemu-devel@nongnu.org
> Cc: Gonglei (Arei) <arei.gonglei@huawei.com>; marcandre.lureau@gmail.com;
> philmd@redhat.com; vsementsov@virtuozzo.com
> Subject: [PATCH v6] backends/cryptodev: drop local_err from
> cryptodev_backend_complete()
>
> No reason for local_err here, use errp directly instead.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>
> v6: add r-b by Philippe and Marc-André
>
> backends/cryptodev.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/backends/cryptodev.c b/backends/cryptodev.c index
> 3c071eab95..5a9735684e 100644
> --- a/backends/cryptodev.c
> +++ b/backends/cryptodev.c
> @@ -176,19 +176,10 @@ cryptodev_backend_complete(UserCreatable *uc,
> Error **errp) {
> CryptoDevBackend *backend = CRYPTODEV_BACKEND(uc);
> CryptoDevBackendClass *bc = CRYPTODEV_BACKEND_GET_CLASS(uc);
> - Error *local_err = NULL;
>
> if (bc->init) {
> - bc->init(backend, &local_err);
> - if (local_err) {
> - goto out;
> - }
> + bc->init(backend, errp);
> }
> -
> - return;
> -
> -out:
> - error_propagate(errp, local_err);
> }
>
> void cryptodev_backend_set_used(CryptoDevBackend *backend, bool used)
> --
> 2.21.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete()
2019-11-27 19:45 [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete() Vladimir Sementsov-Ogievskiy
2019-11-28 7:13 ` Gonglei (Arei)
@ 2019-11-29 6:10 ` Markus Armbruster
2019-11-29 8:31 ` Vladimir Sementsov-Ogievskiy
1 sibling, 1 reply; 5+ messages in thread
From: Markus Armbruster @ 2019-11-29 6:10 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy
Cc: marcandre.lureau, arei.gonglei, philmd, qemu-devel
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
> No reason for local_err here, use errp directly instead.
Related: "[PATCH v6] hw/vfio/ap: drop local_err from vfio_ap_realize".
I'm surprised it's just two. Did you search for the anti-pattern
systematically?
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>
> v6: add r-b by Philippe and Marc-André
>
> backends/cryptodev.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/backends/cryptodev.c b/backends/cryptodev.c
> index 3c071eab95..5a9735684e 100644
> --- a/backends/cryptodev.c
> +++ b/backends/cryptodev.c
> @@ -176,19 +176,10 @@ cryptodev_backend_complete(UserCreatable *uc, Error **errp)
> {
> CryptoDevBackend *backend = CRYPTODEV_BACKEND(uc);
> CryptoDevBackendClass *bc = CRYPTODEV_BACKEND_GET_CLASS(uc);
> - Error *local_err = NULL;
>
> if (bc->init) {
> - bc->init(backend, &local_err);
> - if (local_err) {
> - goto out;
> - }
> + bc->init(backend, errp);
> }
> -
> - return;
> -
> -out:
> - error_propagate(errp, local_err);
> }
>
> void cryptodev_backend_set_used(CryptoDevBackend *backend, bool used)
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete()
2019-11-29 6:10 ` Markus Armbruster
@ 2019-11-29 8:31 ` Vladimir Sementsov-Ogievskiy
2019-11-29 12:09 ` Markus Armbruster
0 siblings, 1 reply; 5+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2019-11-29 8:31 UTC (permalink / raw)
To: Markus Armbruster; +Cc: marcandre.lureau, arei.gonglei, philmd, qemu-devel
29.11.2019 9:10, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
>
>> No reason for local_err here, use errp directly instead.
>
> Related: "[PATCH v6] hw/vfio/ap: drop local_err from vfio_ap_realize".
> I'm surprised it's just two. Did you search for the anti-pattern
> systematically?
As I remember - no, only where it breaks automation. Here empty "out: }"
label will break compilation, if not fixed before or after coccinelle
run. So, here I fixed it before.
>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
>>
>> v6: add r-b by Philippe and Marc-André
>>
>> backends/cryptodev.c | 11 +----------
>> 1 file changed, 1 insertion(+), 10 deletions(-)
>>
>> diff --git a/backends/cryptodev.c b/backends/cryptodev.c
>> index 3c071eab95..5a9735684e 100644
>> --- a/backends/cryptodev.c
>> +++ b/backends/cryptodev.c
>> @@ -176,19 +176,10 @@ cryptodev_backend_complete(UserCreatable *uc, Error **errp)
>> {
>> CryptoDevBackend *backend = CRYPTODEV_BACKEND(uc);
>> CryptoDevBackendClass *bc = CRYPTODEV_BACKEND_GET_CLASS(uc);
>> - Error *local_err = NULL;
>>
>> if (bc->init) {
>> - bc->init(backend, &local_err);
>> - if (local_err) {
>> - goto out;
>> - }
>> + bc->init(backend, errp);
>> }
>> -
>> - return;
>> -
>> -out:
>> - error_propagate(errp, local_err);
>> }
>>
>> void cryptodev_backend_set_used(CryptoDevBackend *backend, bool used)
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
--
Best regards,
Vladimir
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete()
2019-11-29 8:31 ` Vladimir Sementsov-Ogievskiy
@ 2019-11-29 12:09 ` Markus Armbruster
0 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2019-11-29 12:09 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy
Cc: philmd, arei.gonglei, marcandre.lureau, qemu-devel
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
> 29.11.2019 9:10, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
>>
>>> No reason for local_err here, use errp directly instead.
>>
>> Related: "[PATCH v6] hw/vfio/ap: drop local_err from vfio_ap_realize".
>> I'm surprised it's just two. Did you search for the anti-pattern
>> systematically?
>
> As I remember - no, only where it breaks automation. Here empty "out: }"
> label will break compilation, if not fixed before or after coccinelle
> run. So, here I fixed it before.
Got it.
A through sweep would be nice, but the goal you're pursuing here
involves more than enough churn already. Don't worry about it now.
[...]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-29 12:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27 19:45 [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete() Vladimir Sementsov-Ogievskiy
2019-11-28 7:13 ` Gonglei (Arei)
2019-11-29 6:10 ` Markus Armbruster
2019-11-29 8:31 ` Vladimir Sementsov-Ogievskiy
2019-11-29 12:09 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).