qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header
@ 2020-05-24 21:56 Philippe Mathieu-Daudé
  2020-05-25  3:05 ` Emilio G. Cota
  2020-05-26 11:24 ` Alex Bennée
  0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-24 21:56 UTC (permalink / raw)
  To: qemu-devel
  Cc: qemu-trivial, Richard Henderson, Emilio G . Cota,
	Alex Bennée, Philippe Mathieu-Daudé

"qemu/qemu-plugin.h" isn't meant to be include by QEMU codebase,
but by 3rd party plugins that QEMU can use. These plugins can be
built out of QEMU and don't include "qemu/osdep.h".
Mark "qemu/qemu-plugin.h" as a special header that doesn't need
to be cleaned for "qemu/osdep.h".

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 scripts/clean-includes | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/clean-includes b/scripts/clean-includes
index dd938daa3e..795b3bea31 100755
--- a/scripts/clean-includes
+++ b/scripts/clean-includes
@@ -123,6 +123,7 @@ for f in "$@"; do
       ;;
     *include/qemu/osdep.h | \
     *include/qemu/compiler.h | \
+    *include/qemu/qemu-plugin.h | \
     *include/glib-compat.h | \
     *include/sysemu/os-posix.h | \
     *include/sysemu/os-win32.h | \
-- 
2.21.3



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header
  2020-05-24 21:56 [PATCH] scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header Philippe Mathieu-Daudé
@ 2020-05-25  3:05 ` Emilio G. Cota
  2020-05-26 11:24 ` Alex Bennée
  1 sibling, 0 replies; 3+ messages in thread
From: Emilio G. Cota @ 2020-05-25  3:05 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: qemu-trivial, Richard Henderson, Alex Bennée, qemu-devel

On Sun, May 24, 2020 at 23:56:54 +0200, Philippe Mathieu-Daudé wrote:
> "qemu/qemu-plugin.h" isn't meant to be include by QEMU codebase,
> but by 3rd party plugins that QEMU can use. These plugins can be
> built out of QEMU and don't include "qemu/osdep.h".
> Mark "qemu/qemu-plugin.h" as a special header that doesn't need
> to be cleaned for "qemu/osdep.h".
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Emilio G. Cota <cota@braap.org>

Thanks,
		Emilio


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header
  2020-05-24 21:56 [PATCH] scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header Philippe Mathieu-Daudé
  2020-05-25  3:05 ` Emilio G. Cota
@ 2020-05-26 11:24 ` Alex Bennée
  1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2020-05-26 11:24 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: qemu-trivial, Emilio G . Cota, Richard Henderson, qemu-devel


Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> "qemu/qemu-plugin.h" isn't meant to be include by QEMU codebase,
> but by 3rd party plugins that QEMU can use. These plugins can be
> built out of QEMU and don't include "qemu/osdep.h".
> Mark "qemu/qemu-plugin.h" as a special header that doesn't need
> to be cleaned for "qemu/osdep.h".
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  scripts/clean-includes | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/clean-includes b/scripts/clean-includes
> index dd938daa3e..795b3bea31 100755
> --- a/scripts/clean-includes
> +++ b/scripts/clean-includes
> @@ -123,6 +123,7 @@ for f in "$@"; do
>        ;;
>      *include/qemu/osdep.h | \
>      *include/qemu/compiler.h | \
> +    *include/qemu/qemu-plugin.h | \
>      *include/glib-compat.h | \
>      *include/sysemu/os-posix.h | \
>      *include/sysemu/os-win32.h | \


Queued to plugins/next, thanks.

-- 
Alex Bennée


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-26 11:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-24 21:56 [PATCH] scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header Philippe Mathieu-Daudé
2020-05-25  3:05 ` Emilio G. Cota
2020-05-26 11:24 ` Alex Bennée

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).