qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] docs: adjust for demise of scripts/create_config
@ 2021-11-05 12:46 Paolo Bonzini
  2021-11-05 13:43 ` Markus Armbruster
  0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2021-11-05 12:46 UTC (permalink / raw)
  To: qemu-devel; +Cc: Markus Armbruster

The config-host.h, $TARGET-NAME/config-target.h, $TARGET-NAME/config-devices.h files
are now generated by configure_file() rather than scripts/create_config.  Adjust
the relevant paragraph in docs/devel/build-system.rst, and take the occasion to
fix a preexisting confusion of *.h vs *.mak.

Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 docs/devel/build-system.rst | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst
index 08f49c845d..1a82ce0b9a 100644
--- a/docs/devel/build-system.rst
+++ b/docs/devel/build-system.rst
@@ -463,11 +463,10 @@ Built by Meson:
   scripts/make_device_config.sh program, feeding it the
   default-configs/$TARGET-NAME file as input.
 
-``config-host.h``, ``$TARGET-NAME/config-target.h``, ``$TARGET-NAME/config-devices.h``
-  These files are used by source code to determine what features
-  are enabled.  They are generated from the contents of the corresponding
-  ``*.h`` files using the scripts/create_config program. This extracts
-  relevant variables and formats them as C preprocessor macros.
+``config-host.h``, ``$TARGET_NAME-config-target.h``, ``$TARGET_NAME-config-devices.h``
+  These files are used by source code to determine what features are
+  enabled.  They are generated from the contents of the corresponding
+  ``*.mak`` files using Meson's ``configure_file()`` function.
 
 ``build.ninja``
   The build rules.
-- 
2.33.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] docs: adjust for demise of scripts/create_config
  2021-11-05 12:46 [PATCH] docs: adjust for demise of scripts/create_config Paolo Bonzini
@ 2021-11-05 13:43 ` Markus Armbruster
  0 siblings, 0 replies; 2+ messages in thread
From: Markus Armbruster @ 2021-11-05 13:43 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: qemu-devel

Paolo Bonzini <pbonzini@redhat.com> writes:

> The config-host.h, $TARGET-NAME/config-target.h, $TARGET-NAME/config-devices.h files
> are now generated by configure_file() rather than scripts/create_config.  Adjust
> the relevant paragraph in docs/devel/build-system.rst, and take the occasion to
> fix a preexisting confusion of *.h vs *.mak.

Please wrap commit messages around column 70.

>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks!

Reviewed-by: Markus Armbruster <armbru@redhat.com>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-05 13:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-05 12:46 [PATCH] docs: adjust for demise of scripts/create_config Paolo Bonzini
2021-11-05 13:43 ` Markus Armbruster

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).