qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds
@ 2020-11-18 14:07 Alex Bennée
  2020-11-18 15:11 ` Thomas Huth
  0 siblings, 1 reply; 7+ messages in thread
From: Alex Bennée @ 2020-11-18 14:07 UTC (permalink / raw)
  To: qemu-devel; +Cc: pbonzini, Ed Maste, Alex Bennée, Li-Wen Hsu

These seem to trigger timeouts with some regularity.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .cirrus.yml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.cirrus.yml b/.cirrus.yml
index f0209b7a3e..08db7c419f 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -18,6 +18,7 @@ freebsd_12_task:
     - gmake -j$(sysctl -n hw.ncpu) check V=1
 
 macos_task:
+  timeout_in: 90m
   osx_instance:
     image: catalina-base
   install_script:
@@ -32,6 +33,7 @@ macos_task:
     - gmake check V=1
 
 macos_xcode_task:
+  timeout_in: 90m
   osx_instance:
     # this is an alias for the latest Xcode
     image: catalina-xcode
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds
  2020-11-18 14:07 [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds Alex Bennée
@ 2020-11-18 15:11 ` Thomas Huth
  2020-12-13 18:35   ` Philippe Mathieu-Daudé
  0 siblings, 1 reply; 7+ messages in thread
From: Thomas Huth @ 2020-11-18 15:11 UTC (permalink / raw)
  To: Alex Bennée, qemu-devel; +Cc: pbonzini, Ed Maste, Li-Wen Hsu

On 18/11/2020 15.07, Alex Bennée wrote:
> These seem to trigger timeouts with some regularity.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  .cirrus.yml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/.cirrus.yml b/.cirrus.yml
> index f0209b7a3e..08db7c419f 100644
> --- a/.cirrus.yml
> +++ b/.cirrus.yml
> @@ -18,6 +18,7 @@ freebsd_12_task:
>      - gmake -j$(sysctl -n hw.ncpu) check V=1
>  
>  macos_task:
> +  timeout_in: 90m
>    osx_instance:
>      image: catalina-base
>    install_script:
> @@ -32,6 +33,7 @@ macos_task:
>      - gmake check V=1
>  
>  macos_xcode_task:
> +  timeout_in: 90m
>    osx_instance:
>      # this is an alias for the latest Xcode
>      image: catalina-xcode
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

... we could maybe also split the --target-list between the two jobs if they
take too long...



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds
  2020-11-18 15:11 ` Thomas Huth
@ 2020-12-13 18:35   ` Philippe Mathieu-Daudé
  2020-12-13 19:18     ` 罗勇刚(Yonggang Luo)
  0 siblings, 1 reply; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-12-13 18:35 UTC (permalink / raw)
  To: Thomas Huth
  Cc: Paolo Bonzini, Ed Maste, Alex Bennée,
	qemu-devel@nongnu.org Developers, Li-Wen Hsu

On Wed, Nov 18, 2020 at 4:11 PM Thomas Huth <thuth@redhat.com> wrote:
> On 18/11/2020 15.07, Alex Bennée wrote:
> > These seem to trigger timeouts with some regularity.
> >
> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > ---
> >  .cirrus.yml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/.cirrus.yml b/.cirrus.yml
> > index f0209b7a3e..08db7c419f 100644
> > --- a/.cirrus.yml
> > +++ b/.cirrus.yml
> > @@ -18,6 +18,7 @@ freebsd_12_task:
> >      - gmake -j$(sysctl -n hw.ncpu) check V=1
> >
> >  macos_task:
> > +  timeout_in: 90m
> >    osx_instance:
> >      image: catalina-base
> >    install_script:
> > @@ -32,6 +33,7 @@ macos_task:
> >      - gmake check V=1
> >
> >  macos_xcode_task:
> > +  timeout_in: 90m
> >    osx_instance:
> >      # this is an alias for the latest Xcode
> >      image: catalina-xcode
> >
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
> ... we could maybe also split the --target-list between the two jobs if they
> take too long...

Maybe it's time, 90min reached:
https://cirrus-ci.com/task/5774549872541696


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds
  2020-12-13 18:35   ` Philippe Mathieu-Daudé
@ 2020-12-13 19:18     ` 罗勇刚(Yonggang Luo)
  2020-12-14  9:24       ` Alex Bennée
  0 siblings, 1 reply; 7+ messages in thread
From: 罗勇刚(Yonggang Luo) @ 2020-12-13 19:18 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: Thomas Huth, Ed Maste, qemu-devel@nongnu.org Developers,
	Paolo Bonzini, Alex Bennée, Li-Wen Hsu

[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]

On Mon, Dec 14, 2020 at 2:36 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:
>
> On Wed, Nov 18, 2020 at 4:11 PM Thomas Huth <thuth@redhat.com> wrote:
> > On 18/11/2020 15.07, Alex Bennée wrote:
> > > These seem to trigger timeouts with some regularity.
> > >
> > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > > ---
> > >  .cirrus.yml | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/.cirrus.yml b/.cirrus.yml
> > > index f0209b7a3e..08db7c419f 100644
> > > --- a/.cirrus.yml
> > > +++ b/.cirrus.yml
> > > @@ -18,6 +18,7 @@ freebsd_12_task:
> > >      - gmake -j$(sysctl -n hw.ncpu) check V=1
> > >
> > >  macos_task:
> > > +  timeout_in: 90m
> > >    osx_instance:
> > >      image: catalina-base
> > >    install_script:
> > > @@ -32,6 +33,7 @@ macos_task:
> > >      - gmake check V=1
> > >
> > >  macos_xcode_task:
> > > +  timeout_in: 90m
> > >    osx_instance:
> > >      # this is an alias for the latest Xcode
> > >      image: catalina-xcode
> > >
> >
> > Reviewed-by: Thomas Huth <thuth@redhat.com>
> >
> > ... we could maybe also split the --target-list between the two jobs if
they
> > take too long...
>
> Maybe it's time, 90min reached:
> https://cirrus-ci.com/task/5774549872541696
>
Even two hour doesn't working, don't know why

--
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo

[-- Attachment #2: Type: text/html, Size: 2121 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds
  2020-12-13 19:18     ` 罗勇刚(Yonggang Luo)
@ 2020-12-14  9:24       ` Alex Bennée
  2020-12-14  9:33         ` Thomas Huth
  0 siblings, 1 reply; 7+ messages in thread
From: Alex Bennée @ 2020-12-14  9:24 UTC (permalink / raw)
  To: luoyonggang
  Cc: Thomas Huth, Ed Maste, Philippe Mathieu-Daudé,
	qemu-devel@nongnu.org Developers, Paolo Bonzini, Li-Wen Hsu


罗勇刚(Yonggang Luo) <luoyonggang@gmail.com> writes:

> On Mon, Dec 14, 2020 at 2:36 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
> wrote:
>>
>> On Wed, Nov 18, 2020 at 4:11 PM Thomas Huth <thuth@redhat.com> wrote:
>> > On 18/11/2020 15.07, Alex Bennée wrote:
>> > > These seem to trigger timeouts with some regularity.
>> > >
>> > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> > > ---
>> > >  .cirrus.yml | 2 ++
>> > >  1 file changed, 2 insertions(+)
>> > >
>> > > diff --git a/.cirrus.yml b/.cirrus.yml
>> > > index f0209b7a3e..08db7c419f 100644
>> > > --- a/.cirrus.yml
>> > > +++ b/.cirrus.yml
>> > > @@ -18,6 +18,7 @@ freebsd_12_task:
>> > >      - gmake -j$(sysctl -n hw.ncpu) check V=1
>> > >
>> > >  macos_task:
>> > > +  timeout_in: 90m
>> > >    osx_instance:
>> > >      image: catalina-base
>> > >    install_script:
>> > > @@ -32,6 +33,7 @@ macos_task:
>> > >      - gmake check V=1
>> > >
>> > >  macos_xcode_task:
>> > > +  timeout_in: 90m
>> > >    osx_instance:
>> > >      # this is an alias for the latest Xcode
>> > >      image: catalina-xcode
>> > >
>> >
>> > Reviewed-by: Thomas Huth <thuth@redhat.com>
>> >
>> > ... we could maybe also split the --target-list between the two jobs if
> they
>> > take too long...
>>
>> Maybe it's time, 90min reached:
>> https://cirrus-ci.com/task/5774549872541696
>>
> Even two hour doesn't working, don't know why

It seems to have jumped up quite considerably over a short period which
makes me think the underlying cause is something is getting stuck on
MacOS. Unfortunately it's hard to debug with just the logs because
whatever is taking the time might not be the last thing in the logs.

Having a time-per-test metric would be useful here.

-- 
Alex Bennée


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds
  2020-12-14  9:24       ` Alex Bennée
@ 2020-12-14  9:33         ` Thomas Huth
  2020-12-15  9:56           ` Daniel P. Berrangé
  0 siblings, 1 reply; 7+ messages in thread
From: Thomas Huth @ 2020-12-14  9:33 UTC (permalink / raw)
  To: Alex Bennée, luoyonggang, Daniel P. Berrange
  Cc: Paolo Bonzini, Li-Wen Hsu, Ed Maste, Philippe Mathieu-Daudé,
	qemu-devel@nongnu.org Developers

On 14/12/2020 10.24, Alex Bennée wrote:
> 
> 罗勇刚(Yonggang Luo) <luoyonggang@gmail.com> writes:
> 
>> On Mon, Dec 14, 2020 at 2:36 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
>> wrote:
>>>
>>> On Wed, Nov 18, 2020 at 4:11 PM Thomas Huth <thuth@redhat.com> wrote:
>>>> On 18/11/2020 15.07, Alex Bennée wrote:
>>>>> These seem to trigger timeouts with some regularity.
>>>>>
>>>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>>>> ---
>>>>>  .cirrus.yml | 2 ++
>>>>>  1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/.cirrus.yml b/.cirrus.yml
>>>>> index f0209b7a3e..08db7c419f 100644
>>>>> --- a/.cirrus.yml
>>>>> +++ b/.cirrus.yml
>>>>> @@ -18,6 +18,7 @@ freebsd_12_task:
>>>>>      - gmake -j$(sysctl -n hw.ncpu) check V=1
>>>>>
>>>>>  macos_task:
>>>>> +  timeout_in: 90m
>>>>>    osx_instance:
>>>>>      image: catalina-base
>>>>>    install_script:
>>>>> @@ -32,6 +33,7 @@ macos_task:
>>>>>      - gmake check V=1
>>>>>
>>>>>  macos_xcode_task:
>>>>> +  timeout_in: 90m
>>>>>    osx_instance:
>>>>>      # this is an alias for the latest Xcode
>>>>>      image: catalina-xcode
>>>>>
>>>>
>>>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>>>
>>>> ... we could maybe also split the --target-list between the two jobs if
>> they
>>>> take too long...
>>>
>>> Maybe it's time, 90min reached:
>>> https://cirrus-ci.com/task/5774549872541696
>>>
>> Even two hour doesn't working, don't know why
> 
> It seems to have jumped up quite considerably over a short period which
> makes me think the underlying cause is something is getting stuck on
> MacOS. Unfortunately it's hard to debug with just the logs because
> whatever is taking the time might not be the last thing in the logs.
> 
> Having a time-per-test metric would be useful here.

Didn't Daniel post such a patch some weeks ago?

 Thomas



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds
  2020-12-14  9:33         ` Thomas Huth
@ 2020-12-15  9:56           ` Daniel P. Berrangé
  0 siblings, 0 replies; 7+ messages in thread
From: Daniel P. Berrangé @ 2020-12-15  9:56 UTC (permalink / raw)
  To: Thomas Huth
  Cc: Ed Maste, Philippe Mathieu-Daudé,
	qemu-devel@nongnu.org Developers, luoyonggang, Paolo Bonzini,
	Alex Bennée, Li-Wen Hsu

On Mon, Dec 14, 2020 at 10:33:09AM +0100, Thomas Huth wrote:
> On 14/12/2020 10.24, Alex Bennée wrote:
> > 
> > 罗勇刚(Yonggang Luo) <luoyonggang@gmail.com> writes:
> > 
> >> On Mon, Dec 14, 2020 at 2:36 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
> >> wrote:
> >>>
> >>> On Wed, Nov 18, 2020 at 4:11 PM Thomas Huth <thuth@redhat.com> wrote:
> >>>> On 18/11/2020 15.07, Alex Bennée wrote:
> >>>>> These seem to trigger timeouts with some regularity.
> >>>>>
> >>>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >>>>> ---
> >>>>>  .cirrus.yml | 2 ++
> >>>>>  1 file changed, 2 insertions(+)
> >>>>>
> >>>>> diff --git a/.cirrus.yml b/.cirrus.yml
> >>>>> index f0209b7a3e..08db7c419f 100644
> >>>>> --- a/.cirrus.yml
> >>>>> +++ b/.cirrus.yml
> >>>>> @@ -18,6 +18,7 @@ freebsd_12_task:
> >>>>>      - gmake -j$(sysctl -n hw.ncpu) check V=1
> >>>>>
> >>>>>  macos_task:
> >>>>> +  timeout_in: 90m
> >>>>>    osx_instance:
> >>>>>      image: catalina-base
> >>>>>    install_script:
> >>>>> @@ -32,6 +33,7 @@ macos_task:
> >>>>>      - gmake check V=1
> >>>>>
> >>>>>  macos_xcode_task:
> >>>>> +  timeout_in: 90m
> >>>>>    osx_instance:
> >>>>>      # this is an alias for the latest Xcode
> >>>>>      image: catalina-xcode
> >>>>>
> >>>>
> >>>> Reviewed-by: Thomas Huth <thuth@redhat.com>
> >>>>
> >>>> ... we could maybe also split the --target-list between the two jobs if
> >> they
> >>>> take too long...
> >>>
> >>> Maybe it's time, 90min reached:
> >>> https://cirrus-ci.com/task/5774549872541696
> >>>
> >> Even two hour doesn't working, don't know why
> > 
> > It seems to have jumped up quite considerably over a short period which
> > makes me think the underlying cause is something is getting stuck on
> > MacOS. Unfortunately it's hard to debug with just the logs because
> > whatever is taking the time might not be the last thing in the logs.
> > 
> > Having a time-per-test metric would be useful here.
> 
> Didn't Daniel post such a patch some weeks ago?

I posted a nasty hack for it, but Paolo has integrated nice support for
it into Meson git master

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-12-15  9:58 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-18 14:07 [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds Alex Bennée
2020-11-18 15:11 ` Thomas Huth
2020-12-13 18:35   ` Philippe Mathieu-Daudé
2020-12-13 19:18     ` 罗勇刚(Yonggang Luo)
2020-12-14  9:24       ` Alex Bennée
2020-12-14  9:33         ` Thomas Huth
2020-12-15  9:56           ` Daniel P. Berrangé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).