qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] plugins/core: add missing break in cb_to_tcg_flags
@ 2020-01-05  7:29 Emilio G. Cota
  2020-01-05 21:08 ` Richard Henderson
  2020-02-05 17:22 ` Alex Bennée
  0 siblings, 2 replies; 3+ messages in thread
From: Emilio G. Cota @ 2020-01-05  7:29 UTC (permalink / raw)
  To: qemu-devel; +Cc: Alex Bennée, Robert Henry

Reported-by: Robert Henry <robhenry@microsoft.com>
Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 plugins/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/plugins/core.c b/plugins/core.c
index 9e1b9e7a91..ed863011ba 100644
--- a/plugins/core.c
+++ b/plugins/core.c
@@ -286,6 +286,7 @@ static inline uint32_t cb_to_tcg_flags(enum qemu_plugin_cb_flags flags)
     switch (flags) {
     case QEMU_PLUGIN_CB_RW_REGS:
         ret = 0;
+        break;
     case QEMU_PLUGIN_CB_R_REGS:
         ret = TCG_CALL_NO_WG;
         break;
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] plugins/core: add missing break in cb_to_tcg_flags
  2020-01-05  7:29 [PATCH] plugins/core: add missing break in cb_to_tcg_flags Emilio G. Cota
@ 2020-01-05 21:08 ` Richard Henderson
  2020-02-05 17:22 ` Alex Bennée
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2020-01-05 21:08 UTC (permalink / raw)
  To: Emilio G. Cota, qemu-devel; +Cc: Alex Bennée, Robert Henry

On 1/5/20 5:29 PM, Emilio G. Cota wrote:
> Reported-by: Robert Henry <robhenry@microsoft.com>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  plugins/core.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] plugins/core: add missing break in cb_to_tcg_flags
  2020-01-05  7:29 [PATCH] plugins/core: add missing break in cb_to_tcg_flags Emilio G. Cota
  2020-01-05 21:08 ` Richard Henderson
@ 2020-02-05 17:22 ` Alex Bennée
  1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2020-02-05 17:22 UTC (permalink / raw)
  To: Emilio G. Cota; +Cc: qemu-devel, Robert Henry


Emilio G. Cota <cota@braap.org> writes:

> Reported-by: Robert Henry <robhenry@microsoft.com>
> Signed-off-by: Emilio G. Cota <cota@braap.org>


Queued to plugins/next, thanks.

> ---
>  plugins/core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/plugins/core.c b/plugins/core.c
> index 9e1b9e7a91..ed863011ba 100644
> --- a/plugins/core.c
> +++ b/plugins/core.c
> @@ -286,6 +286,7 @@ static inline uint32_t cb_to_tcg_flags(enum qemu_plugin_cb_flags flags)
>      switch (flags) {
>      case QEMU_PLUGIN_CB_RW_REGS:
>          ret = 0;
> +        break;
>      case QEMU_PLUGIN_CB_R_REGS:
>          ret = TCG_CALL_NO_WG;
>          break;


-- 
Alex Bennée


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-05 17:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-05  7:29 [PATCH] plugins/core: add missing break in cb_to_tcg_flags Emilio G. Cota
2020-01-05 21:08 ` Richard Henderson
2020-02-05 17:22 ` Alex Bennée

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).