* [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter"
@ 2019-12-04 8:56 Han Han
2019-12-04 11:53 ` no-reply
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Han Han @ 2019-12-04 8:56 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Han Han, laurent, dgilbert
This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8.
In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc
accordingly.
---
qemu-options.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 65c9473b73..e14d88e9b2 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -327,8 +327,8 @@ format(true color). The resolution should be supported by the SVGA mode, so
the recommended is 320x240, 640x480, 800x640.
A timeout could be passed to bios, guest will pause for @var{rb_timeout} ms
-when boot failed, then reboot. If @option{reboot-timeout} is not set,
-guest will not reboot by default. Currently Seabios for X86
+when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will not
+reboot, qemu passes '-1' to bios by default. Currently Seabios for X86
system support it.
Do strict boot via @option{strict=on} as far as firmware/BIOS
--
2.24.0.rc1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter"
2019-12-04 8:56 [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter" Han Han
@ 2019-12-04 11:53 ` no-reply
2019-12-04 12:16 ` Markus Armbruster
2019-12-04 12:21 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 5+ messages in thread
From: no-reply @ 2019-12-04 11:53 UTC (permalink / raw)
To: hhan; +Cc: qemu-trivial, laurent, qemu-devel, dgilbert, hhan
Patchew URL: https://patchew.org/QEMU/20191204085628.2892-1-hhan@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter"
Type: series
Message-id: 20191204085628.2892-1-hhan@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
6803338 Revert "qemu-options.hx: Update for reboot-timeout parameter"
=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 10 lines checked
Commit 680333822026 (Revert "qemu-options.hx: Update for reboot-timeout parameter") has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20191204085628.2892-1-hhan@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter"
2019-12-04 8:56 [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter" Han Han
2019-12-04 11:53 ` no-reply
@ 2019-12-04 12:16 ` Markus Armbruster
2019-12-04 12:21 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2019-12-04 12:16 UTC (permalink / raw)
To: Han Han; +Cc: qemu-trivial, qemu-devel, dgilbert, laurent
Han Han <hhan@redhat.com> writes:
> This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8.
>
> In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc
> accordingly.
> ---
> qemu-options.hx | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 65c9473b73..e14d88e9b2 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -327,8 +327,8 @@ format(true color). The resolution should be supported by the SVGA mode, so
> the recommended is 320x240, 640x480, 800x640.
>
> A timeout could be passed to bios, guest will pause for @var{rb_timeout} ms
> -when boot failed, then reboot. If @option{reboot-timeout} is not set,
> -guest will not reboot by default. Currently Seabios for X86
> +when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will not
> +reboot, qemu passes '-1' to bios by default. Currently Seabios for X86
> system support it.
>
> Do strict boot via @option{strict=on} as far as firmware/BIOS
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter"
2019-12-04 8:56 [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter" Han Han
2019-12-04 11:53 ` no-reply
2019-12-04 12:16 ` Markus Armbruster
@ 2019-12-04 12:21 ` Dr. David Alan Gilbert
2019-12-05 2:49 ` Han Han
2 siblings, 1 reply; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2019-12-04 12:21 UTC (permalink / raw)
To: Han Han; +Cc: qemu-trivial, qemu-devel, laurent
* Han Han (hhan@redhat.com) wrote:
> This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8.
Patchew spotted you're missing the signed-off-by; please send one.
Dave
> In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc
> accordingly.
> ---
> qemu-options.hx | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 65c9473b73..e14d88e9b2 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -327,8 +327,8 @@ format(true color). The resolution should be supported by the SVGA mode, so
> the recommended is 320x240, 640x480, 800x640.
>
> A timeout could be passed to bios, guest will pause for @var{rb_timeout} ms
> -when boot failed, then reboot. If @option{reboot-timeout} is not set,
> -guest will not reboot by default. Currently Seabios for X86
> +when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will not
> +reboot, qemu passes '-1' to bios by default. Currently Seabios for X86
> system support it.
>
> Do strict boot via @option{strict=on} as far as firmware/BIOS
> --
> 2.24.0.rc1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter"
2019-12-04 12:21 ` Dr. David Alan Gilbert
@ 2019-12-05 2:49 ` Han Han
0 siblings, 0 replies; 5+ messages in thread
From: Han Han @ 2019-12-05 2:49 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: qemu-trivial, qemu-devel, laurent
[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]
OK. Updated in version 2.
On Wed, Dec 4, 2019 at 8:21 PM Dr. David Alan Gilbert <dgilbert@redhat.com>
wrote:
> * Han Han (hhan@redhat.com) wrote:
> > This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8.
>
> Patchew spotted you're missing the signed-off-by; please send one.
>
> Dave
>
> > In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc
> > accordingly.
> > ---
> > qemu-options.hx | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index 65c9473b73..e14d88e9b2 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -327,8 +327,8 @@ format(true color). The resolution should be
> supported by the SVGA mode, so
> > the recommended is 320x240, 640x480, 800x640.
> >
> > A timeout could be passed to bios, guest will pause for
> @var{rb_timeout} ms
> > -when boot failed, then reboot. If @option{reboot-timeout} is not set,
> > -guest will not reboot by default. Currently Seabios for X86
> > +when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will
> not
> > +reboot, qemu passes '-1' to bios by default. Currently Seabios for X86
> > system support it.
> >
> > Do strict boot via @option{strict=on} as far as firmware/BIOS
> > --
> > 2.24.0.rc1
> >
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>
>
--
Best regards,
-----------------------------------
Han Han
Quality Engineer
Redhat.
Email: hhan@redhat.com
Phone: +861065339333
[-- Attachment #2: Type: text/html, Size: 2356 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-05 2:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04 8:56 [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter" Han Han
2019-12-04 11:53 ` no-reply
2019-12-04 12:16 ` Markus Armbruster
2019-12-04 12:21 ` Dr. David Alan Gilbert
2019-12-05 2:49 ` Han Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).