* [PATCH] qapi: Belatedly mark unstable QMP parts with feature 'unstable'
@ 2021-11-09 14:55 Markus Armbruster
2021-11-09 15:04 ` Damien Hedde
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Markus Armbruster @ 2021-11-09 14:55 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, ehabkost, philmd
The work in merge commit e86e00a2493 lacks special feature flag
'unstable', because it raced with it. Add it where it's missing.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qapi/machine.json | 54 +++++++++++++++++++++++++++++++++++++++--------
1 file changed, 45 insertions(+), 9 deletions(-)
diff --git a/qapi/machine.json b/qapi/machine.json
index 17794ef681..067e3f5378 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -1417,107 +1417,143 @@
#
# Query interrupt statistics
#
+# Features:
+# @unstable: This command is meant for debugging.
+#
# Returns: interrupt statistics
#
# Since: 6.2
##
{ 'command': 'x-query-irq',
- 'returns': 'HumanReadableText' }
+ 'returns': 'HumanReadableText',
+ 'features': [ 'unstable' ] }
##
# @x-query-jit:
#
# Query TCG compiler statistics
#
+# Features:
+# @unstable: This command is meant for debugging.
+#
# Returns: TCG compiler statistics
#
# Since: 6.2
##
{ 'command': 'x-query-jit',
'returns': 'HumanReadableText',
- 'if': 'CONFIG_TCG' }
+ 'if': 'CONFIG_TCG',
+ 'features': [ 'unstable' ] }
##
# @x-query-numa:
#
# Query NUMA topology information
#
+# Features:
+# @unstable: This command is meant for debugging.
+#
# Returns: topology information
#
# Since: 6.2
##
{ 'command': 'x-query-numa',
- 'returns': 'HumanReadableText' }
+ 'returns': 'HumanReadableText',
+ 'features': [ 'unstable' ] }
##
# @x-query-opcount:
#
# Query TCG opcode counters
#
+# Features:
+# @unstable: This command is meant for debugging.
+#
# Returns: TCG opcode counters
#
# Since: 6.2
##
{ 'command': 'x-query-opcount',
'returns': 'HumanReadableText',
- 'if': 'CONFIG_TCG' }
+ 'if': 'CONFIG_TCG',
+ 'features': [ 'unstable' ] }
##
# @x-query-profile:
#
# Query TCG profiling information
#
+# Features:
+# @unstable: This command is meant for debugging.
+#
# Returns: profile information
#
# Since: 6.2
##
{ 'command': 'x-query-profile',
- 'returns': 'HumanReadableText' }
+ 'returns': 'HumanReadableText',
+ 'features': [ 'unstable' ] }
##
# @x-query-ramblock:
#
# Query system ramblock information
#
+# Features:
+# @unstable: This command is meant for debugging.
+#
# Returns: system ramblock information
#
# Since: 6.2
##
{ 'command': 'x-query-ramblock',
- 'returns': 'HumanReadableText' }
+ 'returns': 'HumanReadableText',
+ 'features': [ 'unstable' ] }
##
# @x-query-rdma:
#
# Query RDMA state
#
+# Features:
+# @unstable: This command is meant for debugging.
+#
# Returns: RDMA state
#
# Since: 6.2
##
{ 'command': 'x-query-rdma',
- 'returns': 'HumanReadableText' }
+ 'returns': 'HumanReadableText',
+ 'features': [ 'unstable' ] }
##
# @x-query-roms:
#
# Query information on the registered ROMS
#
+# Features:
+# @unstable: This command is meant for debugging.
+#
# Returns: registered ROMs
#
# Since: 6.2
##
{ 'command': 'x-query-roms',
- 'returns': 'HumanReadableText' }
+ 'returns': 'HumanReadableText',
+ 'features': [ 'unstable' ] }
##
# @x-query-usb:
#
# Query information on the USB devices
#
+# Features:
+# @unstable: This command is meant for debugging.
+#
# Returns: USB device information
#
# Since: 6.2
##
{ 'command': 'x-query-usb',
- 'returns': 'HumanReadableText' }
+ 'returns': 'HumanReadableText',
+ 'features': [ 'unstable' ] }
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] qapi: Belatedly mark unstable QMP parts with feature 'unstable'
2021-11-09 14:55 [PATCH] qapi: Belatedly mark unstable QMP parts with feature 'unstable' Markus Armbruster
@ 2021-11-09 15:04 ` Damien Hedde
2021-11-09 15:13 ` Daniel P. Berrangé
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Damien Hedde @ 2021-11-09 15:04 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: berrange, eblake, ehabkost, philmd
On 11/9/21 15:55, Markus Armbruster wrote:
> The work in merge commit e86e00a2493 lacks special feature flag
> 'unstable', because it raced with it. Add it where it's missing.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qapi: Belatedly mark unstable QMP parts with feature 'unstable'
2021-11-09 14:55 [PATCH] qapi: Belatedly mark unstable QMP parts with feature 'unstable' Markus Armbruster
2021-11-09 15:04 ` Damien Hedde
@ 2021-11-09 15:13 ` Daniel P. Berrangé
2021-11-09 16:05 ` Philippe Mathieu-Daudé
2021-11-10 5:50 ` Markus Armbruster
3 siblings, 0 replies; 5+ messages in thread
From: Daniel P. Berrangé @ 2021-11-09 15:13 UTC (permalink / raw)
To: Markus Armbruster; +Cc: philmd, eblake, qemu-devel, ehabkost
On Tue, Nov 09, 2021 at 03:55:59PM +0100, Markus Armbruster wrote:
> The work in merge commit e86e00a2493 lacks special feature flag
> 'unstable', because it raced with it. Add it where it's missing.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/machine.json | 54 +++++++++++++++++++++++++++++++++++++++--------
> 1 file changed, 45 insertions(+), 9 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qapi: Belatedly mark unstable QMP parts with feature 'unstable'
2021-11-09 14:55 [PATCH] qapi: Belatedly mark unstable QMP parts with feature 'unstable' Markus Armbruster
2021-11-09 15:04 ` Damien Hedde
2021-11-09 15:13 ` Daniel P. Berrangé
@ 2021-11-09 16:05 ` Philippe Mathieu-Daudé
2021-11-10 5:50 ` Markus Armbruster
3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-11-09 16:05 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: eblake, berrange, ehabkost
On 11/9/21 15:55, Markus Armbruster wrote:
> The work in merge commit e86e00a2493 lacks special feature flag
> 'unstable', because it raced with it. Add it where it's missing.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/machine.json | 54 +++++++++++++++++++++++++++++++++++++++--------
> 1 file changed, 45 insertions(+), 9 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qapi: Belatedly mark unstable QMP parts with feature 'unstable'
2021-11-09 14:55 [PATCH] qapi: Belatedly mark unstable QMP parts with feature 'unstable' Markus Armbruster
` (2 preceding siblings ...)
2021-11-09 16:05 ` Philippe Mathieu-Daudé
@ 2021-11-10 5:50 ` Markus Armbruster
3 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2021-11-10 5:50 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, ehabkost, philmd
Markus Armbruster <armbru@redhat.com> writes:
> The work in merge commit e86e00a2493 lacks special feature flag
> 'unstable', because it raced with it. Add it where it's missing.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Queued for 6.2.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-10 5:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-09 14:55 [PATCH] qapi: Belatedly mark unstable QMP parts with feature 'unstable' Markus Armbruster
2021-11-09 15:04 ` Damien Hedde
2021-11-09 15:13 ` Daniel P. Berrangé
2021-11-09 16:05 ` Philippe Mathieu-Daudé
2021-11-10 5:50 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).