From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
pkrempa@redhat.com, mdroth@linux.vnet.ibm.com,
qemu-block@nongnu.org, quintela@redhat.com,
libvir-list@redhat.com, eblake@redhat.com,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, dgilbert@redhat.com, pbonzini@redhat.com,
marcandre.lureau@redhat.com, jsnow@redhat.com,
libguestfs@redhat.com, ehabkost@redhat.com
Subject: Re: [PATCH 1/9] qapi: New special feature flag "unstable"
Date: Wed, 27 Oct 2021 07:29:37 +0200 [thread overview]
Message-ID: <87r1c7c9xa.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <YXgdQ/y4XVTzB5Ru@redhat.com> ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Tue, 26 Oct 2021 16:22:43 +0100")
Daniel P. Berrangé <berrange@redhat.com> writes:
> On Tue, Oct 26, 2021 at 05:15:10PM +0200, Markus Armbruster wrote:
>> Daniel P. Berrangé <berrange@redhat.com> writes:
>>
>> > On Tue, Oct 26, 2021 at 11:37:19AM +0200, Markus Armbruster wrote:
[...]
>> >> Management applications are better off with a feature flag than with a
>> >> naming convention we sometimes ignore.
>> >
>> > We will sometimes ignore/forget the feature flag too though, so I'm
>> > not convinced there's much difference there.
>>
>> -compat unstable-input=reject,unstable-output=hide should help you stay
>> on the straight & narrow :)
>
> That's from the pov of the mgmt app. I meant from the POV of QEMU
> maintainers forgetting to add "unstable" flag, just as they might
> forget to add a "x-" prefix.
Got it.
My point was that feature flag "unstable" is an unequivocal signal for
"this thing is unstable", while a name starting with "x-" isn't: there
are exceptions.
The converse is a wash: we can forget to mark something unstable no
matter how the mark works.
next prev parent reply other threads:[~2021-10-27 5:31 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 5:25 [PATCH 0/9] Configurable policy for handling unstable interfaces Markus Armbruster
2021-10-25 5:25 ` [PATCH 1/9] qapi: New special feature flag "unstable" Markus Armbruster
2021-10-25 7:15 ` Juan Quintela
2021-10-25 12:05 ` Kashyap Chamarthy
2021-10-25 12:18 ` Philippe Mathieu-Daudé
2021-10-26 7:15 ` Markus Armbruster
2021-10-26 8:14 ` Kashyap Chamarthy
2021-10-25 19:01 ` John Snow
2021-10-26 5:35 ` Markus Armbruster
2021-10-26 7:37 ` Kevin Wolf
2021-10-26 8:36 ` [Libguestfs] " Kashyap Chamarthy
2021-10-26 9:22 ` Dr. David Alan Gilbert
2021-10-26 9:28 ` Daniel P. Berrangé
2021-10-26 9:37 ` Markus Armbruster
2021-10-26 11:34 ` Kevin Wolf
2021-10-28 8:36 ` Markus Armbruster
2021-10-26 14:56 ` Daniel P. Berrangé
2021-10-26 15:15 ` Markus Armbruster
2021-10-26 15:22 ` Daniel P. Berrangé
2021-10-27 5:29 ` Markus Armbruster [this message]
2021-10-25 5:25 ` [PATCH 2/9] qapi: Mark unstable QMP parts with feature 'unstable' Markus Armbruster
2021-10-25 7:16 ` Juan Quintela
2021-10-25 19:05 ` John Snow
2021-10-26 7:56 ` Markus Armbruster
2021-10-26 16:34 ` John Snow
2021-10-27 5:44 ` Markus Armbruster
2021-10-29 13:07 ` Eric Blake
2021-11-02 9:15 ` Kevin Wolf
2021-10-25 5:25 ` [PATCH 3/9] qapi: Eliminate QCO_NO_OPTIONS for a slight simplification Markus Armbruster
2021-10-25 7:17 ` Juan Quintela
2021-10-25 19:08 ` John Snow
2021-10-26 7:58 ` Markus Armbruster
2021-10-25 5:25 ` [PATCH 4/9] qapi: Tools for sets of special feature flags in generated code Markus Armbruster
2021-10-25 19:21 ` John Snow
2021-10-26 8:48 ` Markus Armbruster
2021-10-25 5:25 ` [PATCH 5/9] qapi: Generalize struct member policy checking Markus Armbruster
2021-10-25 19:28 ` John Snow
2021-10-26 9:14 ` Markus Armbruster
2021-10-26 15:43 ` Philippe Mathieu-Daudé
2021-10-27 5:56 ` Markus Armbruster
2021-10-25 5:25 ` [PATCH 6/9] qapi: Generalize command " Markus Armbruster
2021-10-25 12:04 ` Philippe Mathieu-Daudé
2021-10-26 9:40 ` Markus Armbruster
2021-10-25 19:30 ` John Snow
2021-10-25 5:25 ` [PATCH 7/9] qapi: Generalize enum member " Markus Armbruster
2021-10-25 19:36 ` John Snow
2021-10-26 9:43 ` Markus Armbruster
2021-10-26 16:14 ` John Snow
2021-10-25 5:25 ` [PATCH 8/9] qapi: Factor out compat_policy_input_ok() Markus Armbruster
2021-10-25 12:13 ` Philippe Mathieu-Daudé
2021-10-26 9:46 ` Markus Armbruster
2021-10-26 10:39 ` Philippe Mathieu-Daudé
2021-10-29 14:08 ` Markus Armbruster
2021-10-25 19:38 ` John Snow
2021-10-25 5:25 ` [PATCH 9/9] qapi: Extend -compat to set policy for unstable interfaces Markus Armbruster
2021-10-25 19:40 ` John Snow
2021-10-26 18:45 ` Dr. David Alan Gilbert
2021-10-27 5:59 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1c7c9xa.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=libguestfs@redhat.com \
--cc=libvir-list@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).