* [PATCH] monitor: Remove unused define
@ 2019-11-19 11:07 Yury Kotov
2019-11-19 11:53 ` Marc-André Lureau
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yury Kotov @ 2019-11-19 11:07 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Dr. David Alan Gilbert, Markus Armbruster
Remove the definition of QMP_ACCEPT_UNKNOWNS as it is unused since
refactoring 5c678ee8d940
Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru>
---
monitor/misc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/monitor/misc.c b/monitor/misc.c
index 3baa15f3bf..6680734ea1 100644
--- a/monitor/misc.c
+++ b/monitor/misc.c
@@ -106,9 +106,6 @@ struct MonFdset {
QLIST_ENTRY(MonFdset) next;
};
-/* QMP checker flags */
-#define QMP_ACCEPT_UNKNOWNS 1
-
/* Protects mon_fdsets */
static QemuMutex mon_fdsets_lock;
static QLIST_HEAD(, MonFdset) mon_fdsets;
--
2.24.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] monitor: Remove unused define
2019-11-19 11:07 [PATCH] monitor: Remove unused define Yury Kotov
@ 2019-11-19 11:53 ` Marc-André Lureau
2019-11-19 13:40 ` Philippe Mathieu-Daudé
2019-12-18 11:20 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Marc-André Lureau @ 2019-11-19 11:53 UTC (permalink / raw)
To: Yury Kotov; +Cc: qemu trival, Markus Armbruster, QEMU, Dr. David Alan Gilbert
On Tue, Nov 19, 2019 at 3:07 PM Yury Kotov <yury-kotov@yandex-team.ru> wrote:
>
> Remove the definition of QMP_ACCEPT_UNKNOWNS as it is unused since
> refactoring 5c678ee8d940
>
> Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> monitor/misc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/monitor/misc.c b/monitor/misc.c
> index 3baa15f3bf..6680734ea1 100644
> --- a/monitor/misc.c
> +++ b/monitor/misc.c
> @@ -106,9 +106,6 @@ struct MonFdset {
> QLIST_ENTRY(MonFdset) next;
> };
>
> -/* QMP checker flags */
> -#define QMP_ACCEPT_UNKNOWNS 1
> -
> /* Protects mon_fdsets */
> static QemuMutex mon_fdsets_lock;
> static QLIST_HEAD(, MonFdset) mon_fdsets;
> --
> 2.24.0
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] monitor: Remove unused define
2019-11-19 11:07 [PATCH] monitor: Remove unused define Yury Kotov
2019-11-19 11:53 ` Marc-André Lureau
@ 2019-11-19 13:40 ` Philippe Mathieu-Daudé
2019-12-18 11:20 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-11-19 13:40 UTC (permalink / raw)
To: Yury Kotov, qemu-devel
Cc: qemu-trivial, Dr. David Alan Gilbert, Markus Armbruster
On 11/19/19 12:07 PM, Yury Kotov wrote:
> Remove the definition of QMP_ACCEPT_UNKNOWNS as it is unused since
> refactoring 5c678ee8d940
>
> Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru>
> ---
> monitor/misc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/monitor/misc.c b/monitor/misc.c
> index 3baa15f3bf..6680734ea1 100644
> --- a/monitor/misc.c
> +++ b/monitor/misc.c
> @@ -106,9 +106,6 @@ struct MonFdset {
> QLIST_ENTRY(MonFdset) next;
> };
>
> -/* QMP checker flags */
> -#define QMP_ACCEPT_UNKNOWNS 1
> -
> /* Protects mon_fdsets */
> static QemuMutex mon_fdsets_lock;
> static QLIST_HEAD(, MonFdset) mon_fdsets;
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] monitor: Remove unused define
2019-11-19 11:07 [PATCH] monitor: Remove unused define Yury Kotov
2019-11-19 11:53 ` Marc-André Lureau
2019-11-19 13:40 ` Philippe Mathieu-Daudé
@ 2019-12-18 11:20 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2019-12-18 11:20 UTC (permalink / raw)
To: Yury Kotov, qemu-devel
Cc: qemu-trivial, Dr. David Alan Gilbert, Markus Armbruster
Le 19/11/2019 à 12:07, Yury Kotov a écrit :
> Remove the definition of QMP_ACCEPT_UNKNOWNS as it is unused since
> refactoring 5c678ee8d940
>
> Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru>
> ---
> monitor/misc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/monitor/misc.c b/monitor/misc.c
> index 3baa15f3bf..6680734ea1 100644
> --- a/monitor/misc.c
> +++ b/monitor/misc.c
> @@ -106,9 +106,6 @@ struct MonFdset {
> QLIST_ENTRY(MonFdset) next;
> };
>
> -/* QMP checker flags */
> -#define QMP_ACCEPT_UNKNOWNS 1
> -
> /* Protects mon_fdsets */
> static QemuMutex mon_fdsets_lock;
> static QLIST_HEAD(, MonFdset) mon_fdsets;
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-18 11:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19 11:07 [PATCH] monitor: Remove unused define Yury Kotov
2019-11-19 11:53 ` Marc-André Lureau
2019-11-19 13:40 ` Philippe Mathieu-Daudé
2019-12-18 11:20 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).