* [PATCH] iotests: Add more "_require_drivers" checks to the shell-based tests
@ 2019-12-18 16:15 Thomas Huth
2019-12-18 22:40 ` Eric Blake
2019-12-19 11:56 ` Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2019-12-18 16:15 UTC (permalink / raw)
To: qemu-devel, Kevin Wolf; +Cc: qemu-block, Max Reitz
Test 051 should be skipped if nbd is not available, and 267 should
be skipped if copy-on-read is not enabled.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qemu-iotests/051 | 1 +
tests/qemu-iotests/267 | 1 +
2 files changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
index 53bcdbc911..a13bce2fd0 100755
--- a/tests/qemu-iotests/051
+++ b/tests/qemu-iotests/051
@@ -41,6 +41,7 @@ _supported_proto file
# A compat=0.10 image is created in this test which does not support anything
# other than refcount_bits=16
_unsupported_imgopts 'refcount_bits=\([^1]\|.\([^6]\|$\)\)'
+_require_drivers nbd
do_run_qemu()
{
diff --git a/tests/qemu-iotests/267 b/tests/qemu-iotests/267
index 17ac640a83..c1536f45b9 100755
--- a/tests/qemu-iotests/267
+++ b/tests/qemu-iotests/267
@@ -40,6 +40,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
_supported_fmt qcow2
_supported_proto file
_supported_os Linux
+_require_drivers copy-on-read
# Internal snapshots are (currently) impossible with refcount_bits=1
_unsupported_imgopts 'refcount_bits=1[^0-9]'
--
2.18.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iotests: Add more "_require_drivers" checks to the shell-based tests
2019-12-18 16:15 [PATCH] iotests: Add more "_require_drivers" checks to the shell-based tests Thomas Huth
@ 2019-12-18 22:40 ` Eric Blake
2019-12-19 11:56 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2019-12-18 22:40 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Kevin Wolf; +Cc: qemu-block, Max Reitz
On 12/18/19 10:15 AM, Thomas Huth wrote:
> Test 051 should be skipped if nbd is not available, and 267 should
> be skipped if copy-on-read is not enabled.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qemu-iotests/051 | 1 +
> tests/qemu-iotests/267 | 1 +
> 2 files changed, 2 insertions(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
> index 53bcdbc911..a13bce2fd0 100755
> --- a/tests/qemu-iotests/051
> +++ b/tests/qemu-iotests/051
> @@ -41,6 +41,7 @@ _supported_proto file
> # A compat=0.10 image is created in this test which does not support anything
> # other than refcount_bits=16
> _unsupported_imgopts 'refcount_bits=\([^1]\|.\([^6]\|$\)\)'
> +_require_drivers nbd
>
> do_run_qemu()
> {
> diff --git a/tests/qemu-iotests/267 b/tests/qemu-iotests/267
> index 17ac640a83..c1536f45b9 100755
> --- a/tests/qemu-iotests/267
> +++ b/tests/qemu-iotests/267
> @@ -40,6 +40,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
> _supported_fmt qcow2
> _supported_proto file
> _supported_os Linux
> +_require_drivers copy-on-read
>
> # Internal snapshots are (currently) impossible with refcount_bits=1
> _unsupported_imgopts 'refcount_bits=1[^0-9]'
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iotests: Add more "_require_drivers" checks to the shell-based tests
2019-12-18 16:15 [PATCH] iotests: Add more "_require_drivers" checks to the shell-based tests Thomas Huth
2019-12-18 22:40 ` Eric Blake
@ 2019-12-19 11:56 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2019-12-19 11:56 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel, qemu-block, Max Reitz
Am 18.12.2019 um 17:15 hat Thomas Huth geschrieben:
> Test 051 should be skipped if nbd is not available, and 267 should
> be skipped if copy-on-read is not enabled.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-19 11:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 16:15 [PATCH] iotests: Add more "_require_drivers" checks to the shell-based tests Thomas Huth
2019-12-18 22:40 ` Eric Blake
2019-12-19 11:56 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).