* [Qemu-devel] [PATCH] kconfig: do not select VMMOUSE
@ 2019-07-16 21:13 Paolo Bonzini
2019-07-16 21:36 ` Montes, Julio
2019-07-16 21:52 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2019-07-16 21:13 UTC (permalink / raw)
To: qemu-devel; +Cc: Julio Montes, Philippe Mathieu-Daudé
Just make it a default device, so that it is automatically removed if VMPORT
is not included in the binary (as is the case with --with-default-devices).
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/i386/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index b9c96ac361..83a5d9c7c4 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -59,7 +59,6 @@ config I440FX
select IDE_PIIX
select DIMM
select SMBIOS
- select VMMOUSE
select FW_CFG_DMA
config ISAPC
@@ -85,7 +84,6 @@ config Q35
select AHCI_ICH9
select DIMM
select SMBIOS
- select VMMOUSE
select FW_CFG_DMA
config VTD
@@ -99,4 +97,5 @@ config VMPORT
config VMMOUSE
bool
+ default y
depends on VMPORT
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] kconfig: do not select VMMOUSE
2019-07-16 21:13 [Qemu-devel] [PATCH] kconfig: do not select VMMOUSE Paolo Bonzini
@ 2019-07-16 21:36 ` Montes, Julio
2019-07-16 21:52 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Montes, Julio @ 2019-07-16 21:36 UTC (permalink / raw)
To: qemu-devel, pbonzini; +Cc: philmd
Thanks Paolo
On Tue, 2019-07-16 at 23:13 +0200, Paolo Bonzini wrote:
> Just make it a default device, so that it is automatically removed if
> VMPORT
> is not included in the binary (as is the case with --with-default-
> devices).
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/i386/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index b9c96ac361..83a5d9c7c4 100644
> --- a/hw/i386/Kconfig
> +++ b/hw/i386/Kconfig
> @@ -59,7 +59,6 @@ config I440FX
> select IDE_PIIX
> select DIMM
> select SMBIOS
> - select VMMOUSE
> select FW_CFG_DMA
>
> config ISAPC
> @@ -85,7 +84,6 @@ config Q35
> select AHCI_ICH9
> select DIMM
> select SMBIOS
> - select VMMOUSE
> select FW_CFG_DMA
>
> config VTD
> @@ -99,4 +97,5 @@ config VMPORT
>
> config VMMOUSE
> bool
> + default y
> depends on VMPORT
Reviewed-by: Julio Montes <julio.montes@intel.com>
Tested-by: Julio
Montes <julio.montes@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] kconfig: do not select VMMOUSE
2019-07-16 21:13 [Qemu-devel] [PATCH] kconfig: do not select VMMOUSE Paolo Bonzini
2019-07-16 21:36 ` Montes, Julio
@ 2019-07-16 21:52 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-07-16 21:52 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: Julio Montes
On 7/16/19 11:13 PM, Paolo Bonzini wrote:
> Just make it a default device, so that it is automatically removed if VMPORT
> is not included in the binary (as is the case with --with-default-devices).
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/i386/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index b9c96ac361..83a5d9c7c4 100644
> --- a/hw/i386/Kconfig
> +++ b/hw/i386/Kconfig
> @@ -59,7 +59,6 @@ config I440FX
> select IDE_PIIX
> select DIMM
> select SMBIOS
> - select VMMOUSE
> select FW_CFG_DMA
>
> config ISAPC
> @@ -85,7 +84,6 @@ config Q35
> select AHCI_ICH9
> select DIMM
> select SMBIOS
> - select VMMOUSE
> select FW_CFG_DMA
>
> config VTD
> @@ -99,4 +97,5 @@ config VMPORT
>
> config VMMOUSE
> bool
> + default y
> depends on VMPORT
>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-16 21:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-16 21:13 [Qemu-devel] [PATCH] kconfig: do not select VMMOUSE Paolo Bonzini
2019-07-16 21:36 ` Montes, Julio
2019-07-16 21:52 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).