From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/3] q800: fix ESCC base
Date: Sat, 14 Dec 2019 10:51:19 +0000 [thread overview]
Message-ID: <96416004-9170-15e4-313c-5aa195fcb4b8@ilande.co.uk> (raw)
In-Reply-To: <20191212200142.15688-2-laurent@vivier.eu>
On 12/12/2019 20:01, Laurent Vivier wrote:
> 0xc020 is for Q900/Q950, Q800 uses 0xc000.
> This value was provided to the kernel, this explains why it was working
> even with wrong value
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> hw/m68k/q800.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c
> index 4ca8678007..ef0014f4c4 100644
> --- a/hw/m68k/q800.c
> +++ b/hw/m68k/q800.c
> @@ -67,7 +67,7 @@
> #define VIA_BASE (IO_BASE + 0x00000)
> #define SONIC_PROM_BASE (IO_BASE + 0x08000)
> #define SONIC_BASE (IO_BASE + 0x0a000)
> -#define SCC_BASE (IO_BASE + 0x0c020)
> +#define SCC_BASE (IO_BASE + 0x0c000)
> #define ESP_BASE (IO_BASE + 0x10000)
> #define ESP_PDMA (IO_BASE + 0x10100)
> #define ASC_BASE (IO_BASE + 0x14000)
I *think* this is correct (see the off-list message I've sent you) since if you
assume a CHRP-like mapping then even with a base of 0xc000 then an access to 0xc020
could potentially still be hitting the ESCC registers, but I'm not confident enough
to give it an R-B tag :/
ATB,
Mark.
next prev parent reply other threads:[~2019-12-14 10:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 20:01 [PATCH 0/3] q800: update machine emulation Laurent Vivier
2019-12-12 20:01 ` [PATCH 1/3] q800: fix ESCC base Laurent Vivier
2019-12-14 10:51 ` Mark Cave-Ayland [this message]
2019-12-12 20:01 ` [PATCH 2/3] q800: add djMEMC memory controller Laurent Vivier
2019-12-12 21:12 ` BALATON Zoltan
2019-12-12 22:07 ` Philippe Mathieu-Daudé
2019-12-14 10:54 ` Mark Cave-Ayland
2019-12-12 20:01 ` [PATCH 3/3] q800: add machine id register Laurent Vivier
2019-12-14 10:55 ` Mark Cave-Ayland
2019-12-14 13:15 ` Philippe Mathieu-Daudé
2019-12-14 10:58 ` [PATCH 0/3] q800: update machine emulation Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96416004-9170-15e4-313c-5aa195fcb4b8@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).